Hi Martin,

On 05/02/2016 09:42 AM, Martin Chaplet wrote:

Udevng layer is changed in order to support Sierra QMI modems like MC73cxx.
Identically to Huawei modems, these modems are parsed by setup_sierra.
If QMI interface is detected, the Gobi modem driver is selected.
In order to keep setup function as light as possible, real interface
matching is done by udev rule.

This is a bit unusual.  ofono.rules is now only used with the old plugins/udev.c detection logic.  udev.c is only really used for serial-based devices, not USB.

Can we add the logic directly to udevng.c and not depend on ofono.rules?

+    if (qmi != NULL && net != NULL) {
+        ofono_modem_set_driver(modem->modem, "gobi");
+        /* Fixup SIM interface for Sierra QMI devices */
+        ofono_modem_set_string(modem->modem, "Simdriver", "qmimodem-legacy");

Lets do something like:

ofono_modem_set_boolean(modem->modem, "ForceSimLegacy", TRUE);

Regards,
-Denis