From: Or Gerlitz <ogerlitz@mellanox.com>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: Or Gerlitz <gerlitz.or@gmail.com>,
Alexander Duyck <aduyck@mirantis.com>,
"talal@mellanox.com" <talal@mellanox.com>,
Linux Netdev List <netdev@vger.kernel.org>,
Michael Chan <michael.chan@broadcom.com>,
"David Miller" <davem@davemloft.net>,
Gal Pressman <galp@mellanox.com>,
"Eran Ben Elisha" <eranbe@mellanox.com>
Subject: Re: [net-next PATCH v2 5/9] mlx4: Add support for UDP tunnel segmentation with outer checksum offload
Date: Tue, 3 May 2016 15:41:57 +0300 [thread overview]
Message-ID: <57289C95.8030401@mellanox.com> (raw)
In-Reply-To: <CAKgT0UdeuJA-K8zim5Eact9A2oFscXDC2a7ciKGTo74xptuw4w@mail.gmail.com>
On 5/2/2016 6:41 PM, Alexander Duyck wrote:
>> >Just one more piece to clarify... in the general case (e.g inner
>> >packet size 1.5k...64k), the last segment would not have the same
>> >length as the other segments, what happens on that case?
> Actually in the case of GSO partial we have go through the software
> segmentation code and trim off any last bit that doesn't match the MSS
> of the rest of the frame. That way you end up with one frame that has
> some number of MSS sized chunks, and then one remainder if there is a
> frame that would be a different size.
OK, thanks for further clarifying this, will look on the docs you
pointed etc. From what you wrote here I understand it's indeed possible
for one frame to be of different size from the rest, but the LCO thing
still works somehow..
Or.
next prev parent reply other threads:[~2016-05-03 12:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 22:43 [net-next PATCH v2 0/9] Fix Tunnel features and enable GSO partial for several drivers Alexander Duyck
2016-04-29 22:43 ` [net-next PATCH v2 1/9] net: Disable segmentation if checksumming is not supported Alexander Duyck
2016-05-01 20:30 ` Or Gerlitz
2016-05-02 2:16 ` Alexander Duyck
2016-04-29 22:43 ` [net-next PATCH v2 2/9] gso: Only allow GSO_PARTIAL if we can checksum the inner protocol Alexander Duyck
2016-04-29 22:43 ` [net-next PATCH v2 3/9] net: Fix netdev_fix_features so that TSO_MANGLEID is only available with TSO Alexander Duyck
2016-04-29 22:43 ` [net-next PATCH v2 4/9] vxlan: Add checksum check to the features check function Alexander Duyck
2016-04-29 22:43 ` [net-next PATCH v2 5/9] mlx4: Add support for UDP tunnel segmentation with outer checksum offload Alexander Duyck
2016-05-01 20:28 ` Saeed Mahameed
2016-05-01 20:35 ` Or Gerlitz
2016-05-02 2:25 ` Alexander Duyck
2016-05-02 7:19 ` Or Gerlitz
2016-05-02 15:41 ` Alexander Duyck
2016-05-03 12:41 ` Or Gerlitz [this message]
2016-05-03 15:29 ` Alexander Duyck
2016-05-04 15:50 ` Or Gerlitz
2016-05-04 16:06 ` Alex Duyck
2016-05-05 21:39 ` Or Gerlitz
2016-05-05 22:00 ` Alexander Duyck
2016-04-29 22:43 ` [net-next PATCH v2 6/9] mlx4: Add support for inner IPv6 checksum offloads and TSO Alexander Duyck
2016-05-01 20:21 ` Saeed Mahameed
2016-04-29 22:43 ` [net-next PATCH v2 7/9] mlx5e: Add support for UDP tunnel segmentation with outer checksum offload Alexander Duyck
2016-05-01 20:08 ` Saeed Mahameed
2016-04-29 22:43 ` [net-next PATCH v2 8/9] mlx5e: Fix IPv6 tunnel " Alexander Duyck
2016-05-01 20:09 ` Saeed Mahameed
2016-04-29 22:43 ` [net-next PATCH v2 9/9] bnxt: Add support for segmentation of tunnels with outer checksums Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57289C95.8030401@mellanox.com \
--to=ogerlitz@mellanox.com \
--cc=aduyck@mirantis.com \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=eranbe@mellanox.com \
--cc=galp@mellanox.com \
--cc=gerlitz.or@gmail.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=talal@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.