All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lokesh Vutla <lokeshvutla@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 3/3] spl: Support loading a FIT from FAT FS
Date: Tue, 3 May 2016 19:29:17 +0530	[thread overview]
Message-ID: <5728AEB5.604@ti.com> (raw)
In-Reply-To: <5728A07E.3070402@xilinx.com>



On Tuesday 03 May 2016 06:28 PM, Michal Simek wrote:
> On 3.5.2016 11:05, Lokesh Vutla wrote:
>> Detect a FIT when loading from a FAT File system and handle it using the
>> new FIT SPL support.
>>
>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
>> ---
>>  common/spl/spl_fat.c | 31 +++++++++++++++++++++++++++++--
>>  1 file changed, 29 insertions(+), 2 deletions(-)
>>
>> diff --git a/common/spl/spl_fat.c b/common/spl/spl_fat.c
>> index d761b26..3788e4d 100644
>> --- a/common/spl/spl_fat.c
>> +++ b/common/spl/spl_fat.c
>> @@ -15,6 +15,7 @@
>>  #include <fat.h>
>>  #include <errno.h>
>>  #include <image.h>
>> +#include <libfdt.h>
>>  
>>  static int fat_registered;
>>  
>> @@ -39,6 +40,20 @@ static int spl_register_fat_device(struct blk_desc *block_dev, int partition)
>>  	return err;
>>  }
>>  
>> +static ulong spl_fit_read(struct spl_load_info *load, ulong file_offset,
>> +			  ulong size, void *buf)
>> +{
>> +	loff_t actread;
>> +	int ret;
>> +	char *filename = (char *)load->priv;
>> +
>> +	ret = fat_read_file(filename, buf, file_offset, size, &actread);
>> +	if (ret)
>> +		return ret;
>> +	else
> 
> you can remove this else.

Sure. Will fix it in the next version.

Thanks and regards,
Lokesh

> 
> Thanks,
> Michal
> 

      reply	other threads:[~2016-05-03 13:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-03  9:05 [U-Boot] [PATCH v4 0/3] spl: Add support to load FIT from Filesystem Lokesh Vutla
2016-05-03  9:05 ` [U-Boot] [PATCH v4 1/3] spl: fit: Fix the number of bytes read when reading fdt from fit Lokesh Vutla
2016-05-03  9:05 ` [U-Boot] [PATCH v4 2/3] spl: Allow to load a FIT containing U-Boot from FS Lokesh Vutla
2016-05-03 12:57   ` Michal Simek
2016-05-03 13:49     ` Lokesh Vutla
2016-05-03 12:59   ` Michal Simek
2016-05-03 14:12     ` Lokesh Vutla
2016-05-03  9:05 ` [U-Boot] [PATCH v4 3/3] spl: Support loading a FIT from FAT FS Lokesh Vutla
2016-05-03 12:58   ` Michal Simek
2016-05-03 13:59     ` Lokesh Vutla [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5728AEB5.604@ti.com \
    --to=lokeshvutla@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.