All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Fedorov <serge.fdrv@gmail.com>
To: Sergey Fedorov <sergey.fedorov@linaro.org>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
	"Sergey Fedorov" <serge.fedorov@linaro.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
	"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] cpu-exec: Remove relic orphaned comment
Date: Tue, 3 May 2016 17:36:17 +0300	[thread overview]
Message-ID: <5728B761.60605@gmail.com> (raw)
In-Reply-To: <1462286050-21778-1-git-send-email-sergey.fedorov@linaro.org>

On 03/05/16 17:34, Sergey Fedorov wrote:
> From: Sergey Fedorov <serge.fdrv@gmail.com>
>
> This comment should have been deleted by commit 0ac087f1f3ae ("removed
> unused code") but somehow it is still here. There's no point to keep it.
>
> Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
> Signed-off-by: Sergey Fedorov <serge.fedorov@linaro.org>

Sorry, should be:

	Signed-off-by: Sergey Fedorov <sergey.fedorov@linaro.org>

Also, this patch is based on a commit:
    3c712db2c10b ("cpu-exec: Move TB chaining into tb_find_fast()")
from:
    git://github.com/rth7680/qemu.git tcg-next

Kind regards,
Sergey

> ---
>  cpu-exec.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/cpu-exec.c b/cpu-exec.c
> index d43d5ae729b6..d55faa5114c7 100644
> --- a/cpu-exec.c
> +++ b/cpu-exec.c
> @@ -582,8 +582,6 @@ int cpu_exec(CPUState *cpu)
>                  /* Try to align the host and virtual clocks
>                     if the guest is in advance */
>                  align_clocks(&sc, cpu);
> -                /* reset soft MMU for next block (it can currently
> -                   only be set by a memory fault) */
>              } /* for(;;) */
>          } else {
>  #if defined(__clang__) || !QEMU_GNUC_PREREQ(4, 6)

  reply	other threads:[~2016-05-03 14:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-03 14:34 [Qemu-devel] [PATCH] cpu-exec: Remove relic orphaned comment Sergey Fedorov
2016-05-03 14:36 ` Sergey Fedorov [this message]
2016-05-04 17:56   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5728B761.60605@gmail.com \
    --to=serge.fdrv@gmail.com \
    --cc=alex.bennee@linaro.org \
    --cc=crosthwaite.peter@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=serge.fedorov@linaro.org \
    --cc=sergey.fedorov@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.