All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Doug Goldstein <cardoe@cardoe.com>, xen-devel@lists.xen.org
Cc: Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH v2 2/7] build: convert crash_debug to Kconfig
Date: Tue, 3 May 2016 15:47:26 +0100	[thread overview]
Message-ID: <5728B9FE.5040705@citrix.com> (raw)
In-Reply-To: <1462285753-5588-3-git-send-email-cardoe@cardoe.com>

On 03/05/16 15:29, Doug Goldstein wrote:
> diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug
> index e5179f4..04f672f 100644
> --- a/xen/Kconfig.debug
> +++ b/xen/Kconfig.debug
> @@ -5,3 +5,14 @@ menuconfig DEBUG
>  	  If you want to debug Xen say Y and select any additional debugging
>  	  support options. Enabling this option is intended for development
>  	  purposes only, and not for production use.
> +
> +if DEBUG
> +
> +config CRASH_DEBUG
> +	bool "Crash Debugging Support"
> +	depends on X86

default n

Even with debugging enabled before, this wasn't available by default
(see the hunk below).

~Andrew

> +	---help---
> +	  If you want to be able to attach gdb to Xen to be able to debug
> +	  Xen if it crashes then say Y.
> +
> +endif # DEBUG
> diff --git a/xen/Rules.mk b/xen/Rules.mk
> index 961d533..c044fd1 100644
> --- a/xen/Rules.mk
> +++ b/xen/Rules.mk
> @@ -7,7 +7,6 @@ verbose       ?= n
>  perfc         ?= n
>  perfc_arrays  ?= n
>  lock_profile  ?= n
> -crash_debug   ?= n
>  frame_pointer ?= n
>  lto           ?= n


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-05-03 14:47 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-03 14:29 [PATCH v2 0/7] Kconfig debug options Doug Goldstein
2016-05-03 14:29 ` [PATCH v2 1/7] build: add debug menu to Kconfig Doug Goldstein
2016-05-03 14:38   ` Jan Beulich
2016-05-03 14:39     ` Doug Goldstein
2016-05-03 15:05   ` Jan Beulich
2016-05-03 15:10     ` Andrew Cooper
2016-05-03 15:18       ` Jan Beulich
2016-05-04  2:22         ` Doug Goldstein
2016-05-04  7:17           ` Jan Beulich
2016-05-03 14:29 ` [PATCH v2 2/7] build: convert crash_debug " Doug Goldstein
2016-05-03 14:43   ` Jan Beulich
2016-05-03 14:48     ` Doug Goldstein
2016-05-03 15:19       ` Jan Beulich
2016-05-04  3:10     ` Doug Goldstein
2016-05-04  7:20       ` Jan Beulich
2016-05-03 14:47   ` Andrew Cooper [this message]
2016-05-03 15:02     ` Jan Beulich
2016-05-03 14:29 ` [PATCH v2 3/7] build: convert verbose " Doug Goldstein
2016-05-03 14:47   ` Jan Beulich
2016-05-03 14:29 ` [PATCH v2 4/7] build: convert frame_pointer " Doug Goldstein
2016-05-03 14:49   ` Jan Beulich
2016-05-03 14:29 ` [PATCH v2 5/7] build: wire up pre-existing debug build flag Doug Goldstein
2016-05-03 14:50   ` Jan Beulich
2016-05-04  3:13     ` Doug Goldstein
2016-05-03 14:29 ` [PATCH v2 6/7] build: convert perfc{, _arrays} to Kconfig Doug Goldstein
2016-05-03 14:57   ` Jan Beulich
2016-05-03 14:29 ` [PATCH v2 7/7] build: convert lock_profile " Doug Goldstein
2016-05-03 14:59   ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5728B9FE.5040705@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=cardoe@cardoe.com \
    --cc=jbeulich@suse.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.