From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43777)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1axena-00089t-LF
	for qemu-devel@nongnu.org; Tue, 03 May 2016 14:12:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1axenF-0006k1-Av
	for qemu-devel@nongnu.org; Tue, 03 May 2016 14:11:49 -0400
Received: from [2a03:4000:1::4e2f:c7ac:d] (port=47231 helo=mail.weilnetz.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1axenE-0006cF-VS
	for qemu-devel@nongnu.org; Tue, 03 May 2016 14:11:33 -0400
References: <20160503155857.23801.56272.malonedeb@gac.canonical.com>
From: Stefan Weil <sw@weilnetz.de>
Message-ID: <5728E9C4.4060706@weilnetz.de>
Date: Tue, 3 May 2016 20:11:16 +0200
MIME-Version: 1.0
In-Reply-To: <20160503155857.23801.56272.malonedeb@gac.canonical.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [Bug 1577841] [NEW] target-mips/helper.c:542: bad
 sizeof ?
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bug 1577841 <1577841@bugs.launchpad.net>, qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>

Am 03.05.2016 um 17:58 schrieb dcb:
> Public bug reported:
>
> Recent versions of gcc say this:
>
> qemu/target-mips/helper.c:542:9: warning: =E2=80=98memset=E2=80=99 used=
 with length
> equal to number of elements without multiplication by element size
> [-Wmemset-elt-size]
>
> Source code is
>
>    memset(env->CP0_WatchLo, 0, sizeof(*env->CP0_WatchLo));
>
> Maybe better code
>
>    memset(env->CP0_WatchLo, 0, 8 * sizeof(target_ulong));
>
> ** Affects: qemu
>      Importance: Undecided
>          Status: New

This might be an error. I think it should be

memset(env->CP0_WatchLo, 0, sizeof(env->CP0_WatchLo));

(this corresponds to your suggested code)

Regards
Stefan