All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrei Borzenkov <arvidjaar@gmail.com>
To: Duncan <1i5t5.duncan@cox.net>, linux-btrfs@vger.kernel.org
Subject: Re: /etc/fstab rootfs options vs grub2 rootflags cmdline
Date: Wed, 4 May 2016 19:31:42 +0300	[thread overview]
Message-ID: <572A23EE.5010902@gmail.com> (raw)
In-Reply-To: <pan$6ee8b$a34d8ed2$894ceb38$41a8085e@cox.net>

04.05.2016 18:54, Duncan пишет:
> Niccolò Belli posted on Wed, 04 May 2016 15:52:39 +0200 as excerpted:
> 
>> Thanks,
>> Now my fstab option are
>> rw,noatime,compress=lzo,discard,autodefrag,subvolid=257,subvol=/@
>> I tried to add rootflags=noatime,compress=lzo,discard,autodefrag to
>> GRUB_CMDLINE_LINUX in /etc/default/grub as you suggested but my system
>> didn't manage to boot, probably because grub automatically adds
>> rootflags=subvol=@ and only a single rootflags can be taken into
>> account.
>> Do you have any suggestion?
> 
> What about the subvol=/@?
> 
> I think if you specifically add your own rootflags, grub won't add its 
> own, and you said
> 

It will, but it will prepend it to GRUB_CMDLINE_LINUX and last
occurrence on kernel command line should win, so rootflags from
GRUB_CMDLINE_LINUX should be used.

> noatime,compress=lzo,discard,autodefrag
> 
> but left off the subvol=/@ (unless you simply forgot to put it in the 
> posting), and without that, it would have mounted the btrfs default 
> subvolume, which would be (the filesystem's) / (subvolid=5) if you 
> haven't changed it, and would have failed to boot as a result.
> 

But if I understand it correctly, GRUB already adds correct subvolume,
and none of listed options should cause failure to boot.

  reply	other threads:[~2016-05-04 16:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-04  9:46 /etc/fstab rootfs options vs grub2 rootflags cmdline Niccolò Belli
2016-05-04 11:40 ` Duncan
2016-05-04 13:52   ` Niccolò Belli
2016-05-04 15:54     ` Duncan
2016-05-04 16:31       ` Andrei Borzenkov [this message]
2016-05-04 18:07     ` Chris Murphy
2016-05-04 18:34       ` Duncan
2016-05-04 19:28         ` Chris Murphy
2016-05-04 18:56       ` Austin S. Hemmelgarn
2016-05-04 17:58   ` Chris Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=572A23EE.5010902@gmail.com \
    --to=arvidjaar@gmail.com \
    --cc=1i5t5.duncan@cox.net \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.