From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49269) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ay0Hu-00009r-OE for qemu-devel@nongnu.org; Wed, 04 May 2016 13:08:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ay0Hi-0006KZ-OT for qemu-devel@nongnu.org; Wed, 04 May 2016 13:08:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57889) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ay0Hi-0006HN-Jt for qemu-devel@nongnu.org; Wed, 04 May 2016 13:08:26 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D5A6837E64 for ; Wed, 4 May 2016 17:08:13 +0000 (UTC) References: <1462380558-2030-1-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <572A2C7D.7070501@redhat.com> Date: Wed, 4 May 2016 11:08:13 -0600 MIME-Version: 1.0 In-Reply-To: <1462380558-2030-1-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OwqkxDjOO944b496uaaOqh8R0a0xmHmUl" Subject: Re: [Qemu-devel] [PATCH 0/2] migration: Move qjson.[ch] to migration/, clean up List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: dgilbert@redhat.com, quintela@redhat.com, amit.shah@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OwqkxDjOO944b496uaaOqh8R0a0xmHmUl Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/04/2016 10:49 AM, Markus Armbruster wrote: > qjson.[ch] is a JSON writer used by migration. Eric proposed to > replace it by common code in his "Add qapi-to-JSON and clone visitors" > series. David's review led to the conclusion that migration would > prefer to keep its own JSON writer, to better serve its requirements. > PATCH 1 move it to its proper place, and explains why it exists in a > bit more detail. PATCH 2 simplifies it a bit. Whose tree would this go in through? At any rate, series: Reviewed-by: Eric Blake but see nit on 1/2 >=20 > Markus Armbruster (2): > migration: Move qjson.[ch] to migration/ > migration/qjson: Drop gratuitous use of QOM >=20 > Makefile.objs | 1 - > include/{ =3D> migration}/qjson.h | 2 +- > include/migration/vmstate.h | 2 +- > migration/Makefile.objs | 1 + > qjson.c =3D> migration/qjson.c | 58 +++++++++++++++----------------= ---------- > migration/savevm.c | 2 +- > migration/vmstate.c | 1 - > tests/Makefile | 2 +- > 8 files changed, 26 insertions(+), 43 deletions(-) > rename include/{ =3D> migration}/qjson.h (95%) > rename qjson.c =3D> migration/qjson.c (70%) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --OwqkxDjOO944b496uaaOqh8R0a0xmHmUl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXKix9AAoJEKeha0olJ0NqPAsH/iHaWY3LLnZwkkCahG1LsnhD O2vwDiaR2ciL3YTJnMF2SVu8Db13zgJ5uCYY+x/m1z3lO0EEN5GwPcwHpdifd6cD oe/dZssp/lqGfhERheZxFJUnuW+wTSEYuUf5ciYgZ7ep1EMb7VzzNFhuxmKl05wc DGK54+NmXVC4u28paGZGFbB6NDu51PCrJ4ZLEd91bdscWqv9jMcndKD7MCcklVAs oj4Icj8+Fw+qpEOVEye61N88fdzj1QO/158KOjprRvHZtTZ17xnRx2e68U/GCjA4 LJHWm9okXc/0X4dpzP00w713utcE06LHth1IYqr1U0i4qU+nDjBuBK72S7ylHXA= =Uil6 -----END PGP SIGNATURE----- --OwqkxDjOO944b496uaaOqh8R0a0xmHmUl--