From: Rick Jones <rick.jones2@hpe.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Peter Wu <peter@lekensteyn.nl>,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Kui Zhang <kuizhang@gmail.com>
Subject: Re: [PATCH] tcp: ensure non-empty connection request queue
Date: Wed, 4 May 2016 11:05:26 -0700 [thread overview]
Message-ID: <572A39E6.1020001@hpe.com> (raw)
In-Reply-To: <1462383266.5535.350.camel@edumazet-glaptop3.roam.corp.google.com>
On 05/04/2016 10:34 AM, Eric Dumazet wrote:
> On Wed, 2016-05-04 at 10:24 -0700, Rick Jones wrote:
>
>> Dropping the connection attempt makes sense, but is entering/claiming
>> synflood really indicated in the case of a zero-length accept queue?
>
> This is a one time message.
>
> This is how people can learn about their user space bugs, or too small
> backlog ;)
>
> Being totally silent would be not so nice.
>
Assuming Peter's assertion about just drops when syncookies are not
enabled is accurate, should there be some one-time message in that case too?
rick
next prev parent reply other threads:[~2016-05-04 18:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 21:54 [PATCH] tcp: ensure non-empty connection request queue Peter Wu
2016-05-04 0:25 ` Eric Dumazet
2016-05-04 9:40 ` Peter Wu
2016-05-04 17:24 ` Rick Jones
2016-05-04 17:34 ` Eric Dumazet
2016-05-04 18:05 ` Rick Jones [this message]
2016-05-04 18:18 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572A39E6.1020001@hpe.com \
--to=rick.jones2@hpe.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuizhang@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peter@lekensteyn.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.