From: Sergey Fedorov <serge.fdrv@gmail.com>
To: Richard Henderson <rth@twiddle.net>,
Sergey Fedorov <sergey.fedorov@linaro.org>,
qemu-devel@nongnu.org
Cc: Peter Crosthwaite <crosthwaite.peter@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH RFC] cpu-exec: Restructure cpu_exec()
Date: Wed, 4 May 2016 22:02:49 +0300 [thread overview]
Message-ID: <572A4759.8050304@gmail.com> (raw)
In-Reply-To: <5855363d-6ba6-3c60-7023-88ca01a093cd@twiddle.net>
On 04/05/16 21:04, Richard Henderson wrote:
> On 05/04/2016 03:38 AM, Sergey Fedorov wrote:
>> From: Sergey Fedorov <serge.fdrv@gmail.com>
>>
>> cpu_exec() was a huge function also sprinkled with some preprocessor
>> directives. It's hard to read and see the main loop crowded by all this
>> code. Restructure cpu_exec() by moving its conceptual parts into
>> separate static in-line functions. That makes it possible to see the
>> whole main loop at once, especially its sigsetjmp() handling part.
>>
>> Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
>> Signed-off-by: Sergey Fedorov <sergey.fedorov@linaro.org>
>
> I agree that cpu_exec is a shocking horror. However, this patch is
> hard enough to read that it might be worth splitting. Is it easy
> enough to pull out each subroutine in a separate patch?
Sure, it's easy. I just wanted to check that this is a right approach
and after this patch applied cpu_exec() is in right shape. I'll prepare
a split patch series later.
Kind regards,
Sergey
prev parent reply other threads:[~2016-05-04 19:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 13:38 [Qemu-devel] [PATCH RFC] cpu-exec: Restructure cpu_exec() Sergey Fedorov
2016-05-04 18:04 ` Richard Henderson
2016-05-04 19:02 ` Sergey Fedorov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572A4759.8050304@gmail.com \
--to=serge.fdrv@gmail.com \
--cc=crosthwaite.peter@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sergey.fedorov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.