From: xiaoqiang zhao <zxq_yx_007@163.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Igor Mitsyanko <i.mitsyanko@gmail.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>,
Michael Walle <michael@walle.cc>, qemu-arm <qemu-arm@nongnu.org>,
hirofumi@mail.parknet.co.jp
Subject: Re: [Qemu-arm] [PATCH v2 2/5] hw/display: QOM'ify jazz_led.c
Date: Fri, 6 May 2016 19:14:46 +0800 [thread overview]
Message-ID: <572C7CA6.5040700@163.com> (raw)
In-Reply-To: <CAFEAcA-rZL0S5kNFf0=--Xp2y9uJ8xPhGC4NmjRbuBkGs-8Y3A@mail.gmail.com>
在 2016年05月06日 19:05, Peter Maydell 写道:
> On 6 May 2016 at 11:59, xiaoqiang zhao <zxq_yx_007@163.com> wrote:
>> * Drop the old SysBus init function and use instance_init
>> * Move graphic_console_init into realize stage
>>
>> Signed-off-by: xiaoqiang zhao <zxq_yx_007@163.com>
>> ---
>> hw/display/jazz_led.c | 18 +++++++++++-------
>> 1 file changed, 11 insertions(+), 7 deletions(-)
> I already reviewed this patch (and some others in this
> series). Please *don't* resend patches without including any
> Reviewed-by: tags you got for them, otherwise people won't
> know if they need to look at them again, and information
> about whether code has been reviewed gets lost.
> For more info, see:
> http://wiki.qemu.org/Contribute/SubmitAPatch#Proper_use_of_Reviewed-by:_tags_can_aid_review
>
> thanks
> -- PMM
Yes, I will.
Thank you peter ;-)
WARNING: multiple messages have this Message-ID (diff)
From: xiaoqiang zhao <zxq_yx_007@163.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Igor Mitsyanko <i.mitsyanko@gmail.com>,
qemu-arm <qemu-arm@nongnu.org>,
hirofumi@mail.parknet.co.jp, Michael Walle <michael@walle.cc>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/5] hw/display: QOM'ify jazz_led.c
Date: Fri, 6 May 2016 19:14:46 +0800 [thread overview]
Message-ID: <572C7CA6.5040700@163.com> (raw)
In-Reply-To: <CAFEAcA-rZL0S5kNFf0=--Xp2y9uJ8xPhGC4NmjRbuBkGs-8Y3A@mail.gmail.com>
在 2016年05月06日 19:05, Peter Maydell 写道:
> On 6 May 2016 at 11:59, xiaoqiang zhao <zxq_yx_007@163.com> wrote:
>> * Drop the old SysBus init function and use instance_init
>> * Move graphic_console_init into realize stage
>>
>> Signed-off-by: xiaoqiang zhao <zxq_yx_007@163.com>
>> ---
>> hw/display/jazz_led.c | 18 +++++++++++-------
>> 1 file changed, 11 insertions(+), 7 deletions(-)
> I already reviewed this patch (and some others in this
> series). Please *don't* resend patches without including any
> Reviewed-by: tags you got for them, otherwise people won't
> know if they need to look at them again, and information
> about whether code has been reviewed gets lost.
> For more info, see:
> http://wiki.qemu.org/Contribute/SubmitAPatch#Proper_use_of_Reviewed-by:_tags_can_aid_review
>
> thanks
> -- PMM
Yes, I will.
Thank you peter ;-)
next prev parent reply other threads:[~2016-05-06 11:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 10:59 [Qemu-arm] [PATCH v2 0/5] QOM'ify hw/display devices xiaoqiang zhao
2016-05-06 10:59 ` [Qemu-devel] " xiaoqiang zhao
2016-05-06 10:59 ` [Qemu-devel] [PATCH v2 1/5] hw/display: QOM'ify exynos4210_fimd.c xiaoqiang zhao
2016-05-06 10:59 ` xiaoqiang zhao
2016-05-06 10:59 ` [Qemu-arm] [PATCH v2 2/5] hw/display: QOM'ify jazz_led.c xiaoqiang zhao
2016-05-06 10:59 ` [Qemu-devel] " xiaoqiang zhao
2016-05-06 11:05 ` Peter Maydell
2016-05-06 11:05 ` Peter Maydell
2016-05-06 11:14 ` xiaoqiang zhao [this message]
2016-05-06 11:14 ` xiaoqiang zhao
2016-05-06 10:59 ` [Qemu-devel] [PATCH v2 3/5] hw/display: QOM'ify milkymist-tmu2.c xiaoqiang zhao
2016-05-06 10:59 ` xiaoqiang zhao
2016-05-09 8:54 ` [Qemu-arm] " michael
2016-05-09 8:54 ` [Qemu-devel] " michael
2016-05-06 10:59 ` [Qemu-arm] [PATCH v2 4/5] hw/display: QOM'ify milkymist-vgafb.c xiaoqiang zhao
2016-05-06 10:59 ` [Qemu-devel] " xiaoqiang zhao
2016-05-09 8:54 ` [Qemu-arm] " michael
2016-05-09 8:54 ` [Qemu-devel] " michael
2016-05-06 10:59 ` [Qemu-arm] [PATCH v2 5/5] hw/display: QOM'ify pl110.c xiaoqiang zhao
2016-05-06 10:59 ` [Qemu-devel] " xiaoqiang zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572C7CA6.5040700@163.com \
--to=zxq_yx_007@163.com \
--cc=armbru@redhat.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=i.mitsyanko@gmail.com \
--cc=michael@walle.cc \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.