From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.25.208.137 with SMTP id h131csp221042lfg; Fri, 6 May 2016 04:16:37 -0700 (PDT) X-Received: by 10.194.168.194 with SMTP id zy2mr20562298wjb.143.1462533396998; Fri, 06 May 2016 04:16:36 -0700 (PDT) Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id v7si17836898wjg.17.2016.05.06.04.16.36 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 06 May 2016 04:16:36 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@163.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Received: from localhost ([::1]:57675 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aydk2-00086I-MA for alex.bennee@linaro.org; Fri, 06 May 2016 07:16:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52908) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aydjt-0007sn-Uq for qemu-arm@nongnu.org; Fri, 06 May 2016 07:16:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aydje-0005nz-EN for qemu-arm@nongnu.org; Fri, 06 May 2016 07:16:04 -0400 Received: from m12-11.163.com ([220.181.12.11]:58918) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aydjc-0005ho-JN; Fri, 06 May 2016 07:15:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Subject:From:Message-ID:Date:MIME-Version; bh=gbZ/G Z781REtxZwWr92Kcx/MiNSeZyDmCUtnIoGuCrU=; b=KhHT1GViAvupWYJUw5J5B cUI1zliQdfi49qTqeu7w4EFhx4DD7McwPnKcTpwgBKXyjFFFAuP4XN0OUOSfYzD8 /Hzrri7R4gF0xaeNiUXW+2tPk1CSgwOCXT4LOYet7w+SWuHrH/O1+ZOHs3VvIYNF 9cxZ1hVTGVUsg59bCswVkM= Received: from [192.168.11.80] (unknown [118.187.28.42]) by smtp7 (Coremail) with SMTP id C8CowAAnLCTGfCxXeXhCCw--.36883S2; Fri, 06 May 2016 19:15:19 +0800 (CST) To: Peter Maydell References: <1462532375-29264-1-git-send-email-zxq_yx_007@163.com> <1462532375-29264-3-git-send-email-zxq_yx_007@163.com> From: xiaoqiang zhao Message-ID: <572C7CA6.5040700@163.com> Date: Fri, 6 May 2016 19:14:46 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID: C8CowAAnLCTGfCxXeXhCCw--.36883S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrZr13KFW7CF47Aw48GFW3KFg_yoWfXrg_uF yvkayftr4xXFWxKF1rCF15u34jgayjvr43ZF4xtr15t345Jw1kXa1DKFsav340gFsrGFya kryDJrWfAw12qjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUnivtPUUUUU== X-Originating-IP: [118.187.28.42] X-CM-SenderInfo: 520ts5t0bqili6rwjhhfrp/xtbBEAhhxlUL8ReRjQAAsb X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 220.181.12.11 Subject: Re: [Qemu-arm] [PATCH v2 2/5] hw/display: QOM'ify jazz_led.c X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Igor Mitsyanko , QEMU Developers , Markus Armbruster , Michael Walle , qemu-arm , hirofumi@mail.parknet.co.jp Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: ACqTlWjKAt+j 在 2016年05月06日 19:05, Peter Maydell 写道: > On 6 May 2016 at 11:59, xiaoqiang zhao wrote: >> * Drop the old SysBus init function and use instance_init >> * Move graphic_console_init into realize stage >> >> Signed-off-by: xiaoqiang zhao >> --- >> hw/display/jazz_led.c | 18 +++++++++++------- >> 1 file changed, 11 insertions(+), 7 deletions(-) > I already reviewed this patch (and some others in this > series). Please *don't* resend patches without including any > Reviewed-by: tags you got for them, otherwise people won't > know if they need to look at them again, and information > about whether code has been reviewed gets lost. > For more info, see: > http://wiki.qemu.org/Contribute/SubmitAPatch#Proper_use_of_Reviewed-by:_tags_can_aid_review > > thanks > -- PMM Yes, I will. Thank you peter ;-) From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52996) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aydkC-0008Ec-IH for qemu-devel@nongnu.org; Fri, 06 May 2016 07:16:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aydk0-0005u4-HF for qemu-devel@nongnu.org; Fri, 06 May 2016 07:16:23 -0400 References: <1462532375-29264-1-git-send-email-zxq_yx_007@163.com> <1462532375-29264-3-git-send-email-zxq_yx_007@163.com> From: xiaoqiang zhao Message-ID: <572C7CA6.5040700@163.com> Date: Fri, 6 May 2016 19:14:46 +0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2 2/5] hw/display: QOM'ify jazz_led.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers , Igor Mitsyanko , qemu-arm , hirofumi@mail.parknet.co.jp, Michael Walle , Markus Armbruster 在 2016年05月06日 19:05, Peter Maydell 写道: > On 6 May 2016 at 11:59, xiaoqiang zhao wrote: >> * Drop the old SysBus init function and use instance_init >> * Move graphic_console_init into realize stage >> >> Signed-off-by: xiaoqiang zhao >> --- >> hw/display/jazz_led.c | 18 +++++++++++------- >> 1 file changed, 11 insertions(+), 7 deletions(-) > I already reviewed this patch (and some others in this > series). Please *don't* resend patches without including any > Reviewed-by: tags you got for them, otherwise people won't > know if they need to look at them again, and information > about whether code has been reviewed gets lost. > For more info, see: > http://wiki.qemu.org/Contribute/SubmitAPatch#Proper_use_of_Reviewed-by:_tags_can_aid_review > > thanks > -- PMM Yes, I will. Thank you peter ;-)