From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41023) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ayeu7-0005X5-7O for qemu-devel@nongnu.org; Fri, 06 May 2016 08:30:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ayetv-000342-DM for qemu-devel@nongnu.org; Fri, 06 May 2016 08:30:41 -0400 References: <1461763231-17598-1-git-send-email-kwolf@redhat.com> <1461763231-17598-6-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <572C8E45.6060609@redhat.com> Date: Fri, 6 May 2016 06:29:57 -0600 MIME-Version: 1.0 In-Reply-To: <1461763231-17598-6-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="27DFKwR4Du8eItM1Ww5hWtMwT9MAj0piw" Subject: Re: [Qemu-devel] [PATCH v2 5/9] block: Remove bdrv_aio_multiwrite() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, jcody@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --27DFKwR4Du8eItM1Ww5hWtMwT9MAj0piw Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/27/2016 07:20 AM, Kevin Wolf wrote: > Since virtio-blk implements request merging itself these days, the only= > remaining users are test cases for the function. That doesn't make the > function exactly useful any more. >=20 > Signed-off-by: Kevin Wolf > Reviewed-by: Max Reitz > --- > block/block-backend.c | 14 --- > block/io.c | 194 ---------------------------------= ------ > include/block/block.h | 7 +- > include/sysemu/block-backend.h | 1 - > qemu-io-cmds.c | 203 ---------------------------------= -------- > tests/qemu-iotests/100 | 145 ----------------------------- > tests/qemu-iotests/100.out | 89 ------------------ > tests/qemu-iotests/136 | 20 +--- > tests/qemu-iotests/136.out | 4 +- > tests/qemu-iotests/group | 2 +- > trace-events | 2 - Reviewed-by: Eric Blake Now that BlockRequest is no longer used in any .h files, should we move the struct out of block.h and into io.c as a followup? I already attempted touching the struct in my series on killing blk_read(), before realizing you were killing the last public use of the struct, so maybe I'll go ahead and tackle that simplification. > +++ b/include/block/block.h > @@ -329,7 +329,7 @@ void bdrv_aio_cancel(BlockAIOCB *acb); > void bdrv_aio_cancel_async(BlockAIOCB *acb); > =20 > typedef struct BlockRequest { > - /* Fields to be filled by multiwrite caller */ > + /* Fields to be filled by caller */ Technically, the caller... > union { > struct { > int64_t sector; > @@ -345,13 +345,10 @@ typedef struct BlockRequest { > BlockCompletionFunc *cb; > void *opaque; > =20 > - /* Filled by multiwrite implementation */ > + /* Filled by block layer */ =2E..is now always the block layer. > int error; > } BlockRequest; Hence my suggestion to move this to io.c and perhaps inline it into the other structs already there. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --27DFKwR4Du8eItM1Ww5hWtMwT9MAj0piw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXLI5FAAoJEKeha0olJ0NqNUgH/2qw2CdjkSgMb8kr+1Sh4Pi7 cijRmkCRnfS4rKiPyznk5gZk+SiLO4pN4VpOSughhwFAjGTf3pwoJuVUC/KLfd3H 09l5eswFoWdsGwADnnZXBhbfWR2muR2zFeb9OgqxjdwMb6ZAymsmVzUqn8b5NbTB vrJpPYtCyOvFTynvV3I52W8Cj/Um2OLWOApBv7wAI/iKXC9rqhVX4qXWqCmc4yK9 OQzrKJiIKiJA9hsM/Y5E+Dm8ucVkbAGMSNdPiK3v2HxuCvKyMfzfZUsEuj3COh3z yHw8+ojZYB/vqXpKMeMsFpUCsBDXogfPUulrlG7S1NY0gUzV+LBXFQZ8Uz91qms= =2crR -----END PGP SIGNATURE----- --27DFKwR4Du8eItM1Ww5hWtMwT9MAj0piw--