From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47782) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ayj9H-0002zW-Lg for qemu-devel@nongnu.org; Fri, 06 May 2016 13:02:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ayj96-0007ip-0j for qemu-devel@nongnu.org; Fri, 06 May 2016 13:02:38 -0400 References: <1462419759-14694-1-git-send-email-eblake@redhat.com> <1462419759-14694-6-git-send-email-eblake@redhat.com> <6507af47-341f-a6d4-b03a-2ca89012551d@redhat.com> <572CC499.5020801@redhat.com> From: Eric Blake Message-ID: <572CCE03.3070800@redhat.com> Date: Fri, 6 May 2016 11:01:55 -0600 MIME-Version: 1.0 In-Reply-To: <572CC499.5020801@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Fu82SWaFJ0Fpmsu4k8lTQPgNWj2p0pixE" Subject: Re: [Qemu-devel] [PATCH v4 5/6] qemu-io: Add 'open -u' to set BDRV_O_UNMAP after the fact List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: kwolf@redhat.com, qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Fu82SWaFJ0Fpmsu4k8lTQPgNWj2p0pixE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/06/2016 10:21 AM, Eric Blake wrote: > On 05/06/2016 10:08 AM, Max Reitz wrote: >> On 05.05.2016 05:42, Eric Blake wrote: >>> When opening a file from the command line, qemu-io defaults >>> to BDRV_O_UNMAP but allows -d to give full control to disable >>> unmaps. But when opening via the 'open' command, qemu-io did >>> not set BDRV_O_UNMAP, and had no way to allow it. >>> >>> Make it at least possible to symmetrically test things: >>> 'qemu-io -d ignore' at the CLI now matches 'qemu-io> open' >>> in batch mode, and 'qemu-io' or 'qemu-io -d unmap' at >>> the CLI matches 'qemu-io> open -u'. >>> >>> Signed-off-by: Eric Blake >>> --- >>> qemu-io.c | 8 ++++++-- >>> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> Not sure why you didn't just reuse the -d option for qemu-io itself, b= ut: >=20 > -d=3Dstring is different than -u (as a binary flag). But you have a > point, that being able to fully-specify ALL modes, rather than just > turning on a single mode, is more flexible. I'll see how tough it is to= > fix for v5. And it looks like supporting it in 'reopen' would also make sense. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Fu82SWaFJ0Fpmsu4k8lTQPgNWj2p0pixE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXLM4DAAoJEKeha0olJ0Nq1+QH/2nZLa9JO2XvjWOSxY+k9TD/ k0UHe5EsPgFANRXgHzxsb4LfZ9JLypFrqpvsuNOo1KrhC2zJ2/tw8VcwcRjNIU22 SVRSR+Xd/WipReqdnJFq1JOiecL+LJq2alTjtX+p3hQte170f5zle3aGHAALCHEl UHQHOjt+YQliyrFZcyY9lPfFK1VE5QGZaaZAK6k8+oa3zLc+tUhYR37DoIZI1K4P lmeoPphMtgXk2MXJGKSfZdt3GgoXfFeHKYJM83GWxQx25YzjBjs6OwUO5hOLIWDI oJ1TSYMWGDj46z/BsOabL1uFJQhO3hgNiF04CA3YRTctsJDSxsjKDPMpfFD0yVo= =CiHP -----END PGP SIGNATURE----- --Fu82SWaFJ0Fpmsu4k8lTQPgNWj2p0pixE--