All of lore.kernel.org
 help / color / mirror / Atom feed
From: "André Przywara" <andre.przywara@arm.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/6] arm64: sunxi: reserve space for boot0 header
Date: Fri, 6 May 2016 22:27:55 +0100	[thread overview]
Message-ID: <572D0C5B.8040406@arm.com> (raw)
In-Reply-To: <CAM7GXo=VoExZR8VJxLQjMkVn8R9bSA-NpJAYRo-v-ztuqt1jDQ@mail.gmail.com>

On 06/05/16 22:15, Steve Rae wrote:
> Hi Andre,
> 
> On Wed, May 4, 2016 at 2:15 PM, Andre Przywara <andre.przywara@arm.com
> <mailto:andre.przywara@arm.com>> wrote:
> 
>     The Allwinner provided boot0 boot loader requires a header before the
>     U-Boot binary to both check its validity and to find other blobs to
>     load. There is a tool called boot0img which fills the header
>     appropriately.
>     Reserve some space at the beginning of the binary to later hold the
>     header if needed.
>     Please note that the header is jumped over already by U-Boot anyway,
>     so filling the header is optional and can be skipped if for instance
>     boot0 is not used.
> 
>     Signed-off-by: Andre Przywara <andre.przywara@arm.com
>     <mailto:andre.przywara@arm.com>>
>     ---
>      arch/arm/cpu/armv8/start.S | 3 +++
>      1 file changed, 3 insertions(+)
> 
>     diff --git a/arch/arm/cpu/armv8/start.S b/arch/arm/cpu/armv8/start.S
>     index deb44a8..b4c4867 100644
>     --- a/arch/arm/cpu/armv8/start.S
>     +++ b/arch/arm/cpu/armv8/start.S
>     @@ -21,6 +21,9 @@
>      _start:
>             b       reset
> 
>     +#ifdef CONFIG_ARCH_SUNXI
>     +       .space 0x5fc    /* can be filled with a boot0 header if
>     needed */
>     +#endif
> 
> 
> NAK !
> this is NOT the _only_ board that would need this, so I propose:

Well, I was thinking about this as well, but wondered why nobody has
ever come up with something like this before.

So I am happy indeed with a more generic solution.

> 
> #ifdef CONFIG_RESERVE_SPACE_BOOT0
>         .space  CONFIG_RESERVE_SPACE_BOOT0
> #endif

If you don't mind, I will put these three lines as your patch in a new
post. Feel free to send it yourself if you prefer this.
And it seems that boot0 is an Allwinner term, so maybe some more generic
naming like CONFIG_RESERVED_HEADER_SPACE or the like?

Cheers,
Andre.

>  
> Thanks, Steve
> 
>             .align 3
> 
>      .globl _TEXT_BASE
>     --
>     2.7.3
> 
>     _______________________________________________
>     U-Boot mailing list
>     U-Boot at lists.denx.de <mailto:U-Boot@lists.denx.de>
>     http://lists.denx.de/mailman/listinfo/u-boot
> 
> 

  reply	other threads:[~2016-05-06 21:27 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-04 21:15 [U-Boot] [PATCH 0/6] arm64: Pine64 fixes and updates Andre Przywara
2016-05-04 21:15 ` [U-Boot] [PATCH 1/6] arm/arm64: Move barrier instructions into separate header Andre Przywara
2016-05-08  0:36   ` André Przywara
2016-05-04 21:15 ` [U-Boot] [PATCH 2/6] Revert "sunxi: Reserve ATF memory space on A64" Andre Przywara
2016-05-15 10:12   ` [U-Boot] [U-Boot, " Hans de Goede
2016-05-04 21:15 ` [U-Boot] [PATCH 3/6] arm64: sunxi: reserve space for boot0 header Andre Przywara
2016-05-06 21:15   ` Steve Rae
2016-05-06 21:27     ` André Przywara [this message]
2016-05-06 21:35       ` Steve Rae
2016-05-15 10:13   ` [U-Boot] [U-Boot, " Hans de Goede
2016-05-04 21:15 ` [U-Boot] [PATCH 4/6] arm64: sunxi: adjust default load addresses Andre Przywara
2016-05-15 10:12   ` [U-Boot] [U-Boot, " Hans de Goede
2016-05-04 21:15 ` [U-Boot] [PATCH 5/6] arm64: Pine64: update FDT files Andre Przywara
2016-05-15 10:13   ` [U-Boot] [U-Boot,5/6] " Hans de Goede
2016-05-15 12:48     ` André Przywara
2016-05-04 21:15 ` [U-Boot] [PATCH 6/6] Pine64: rename defconfig Andre Przywara
2016-05-04 21:46   ` Peter Robinson
2016-05-04 22:14     ` André Przywara
2016-05-06 15:11       ` Tom Rini
2016-05-06 15:20         ` Andre Przywara
2016-05-06 15:31           ` Tom Rini
2016-05-15 10:30   ` [U-Boot] [U-Boot,6/6] " Hans de Goede
2016-05-15 12:49     ` André Przywara
2016-05-15 13:28       ` Hans de Goede
2016-05-15 20:19       ` Alexander Graf
2016-05-04 21:53 ` [U-Boot] [PATCH 0/6] arm64: Pine64 fixes and updates Peter Robinson
2016-05-04 22:05   ` André Przywara
2016-05-04 22:15     ` Peter Robinson
2016-05-04 22:36       ` André Przywara
2016-05-05  1:03         ` Chen-Yu Tsai
2016-05-06 15:09 ` Tom Rini
2016-05-06 17:03   ` Andre Przywara
2016-05-06 17:22     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=572D0C5B.8040406@arm.com \
    --to=andre.przywara@arm.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.