From: Florian Fainelli <f.fainelli@gmail.com>
To: Philippe Reynes <tremyfr@gmail.com>,
fugang.duan@nxp.com, davem@davemloft.net
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings
Date: Fri, 6 May 2016 16:41:33 -0700 [thread overview]
Message-ID: <572D2BAD.8080606@gmail.com> (raw)
In-Reply-To: <1462576729-5932-1-git-send-email-tremyfr@gmail.com>
On 06/05/16 16:18, Philippe Reynes wrote:
> The callback {get|set}_link_ksettings are often defined
> in a very close way. There are mainly two differences in
> those callback:
> - the name of the netdev private structure
> - the name of the struct phydev in the private structure
>
> We add two defines ethtool_phy_{get|set}_link_ksettings
> to avoid writing severals times almost the same function.
This looks fine in principle, but then there is a whole ton of code that
could become like that in the kernel, I do not have any strong opinion
either way...
--
Florian
next prev parent reply other threads:[~2016-05-06 23:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 23:18 [PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings Philippe Reynes
2016-05-06 23:18 ` [PATCH 2/2] net: ethernet: fec: use ethtool_phy_{get|set}_link_ksettings Philippe Reynes
2016-05-06 23:41 ` Florian Fainelli [this message]
2016-05-07 11:59 ` [PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings Ben Hutchings
2016-05-07 22:56 ` Philippe Reynes
2016-05-08 0:13 ` Ben Hutchings
2016-05-08 18:19 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572D2BAD.8080606@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=fugang.duan@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tremyfr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.