From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
"David S. Miller" <davem@davemloft.net>
Cc: Yoshihiro Kaneko <ykaneko0929@gmail.com>,
Simon Horman <horms+renesas@verge.net.au>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 1/2 -net] ravb: Add missing free_irq() call to ravb_close()
Date: Sat, 7 May 2016 21:39:47 +0300 [thread overview]
Message-ID: <572E3673.5020304@cogentembedded.com> (raw)
In-Reply-To: <1462619832-5177-2-git-send-email-geert+renesas@glider.be>
Hello.
On 05/07/2016 02:17 PM, Geert Uytterhoeven wrote:
> When reopening the network device on ra7795/salvator-x, e.g. after a
> DHCP timeout:
>
> IP-Config: Reopening network devices...
> genirq: Flags mismatch irq 139. 00000000 (eth0:ch24:emac) vs. 00000000 (eth0:ch24:emac)
> ravb e6800000.ethernet eth0: cannot request IRQ eth0:ch24:emac
Er, this can't be a message from the kernel built from net.git. That
driver used 'ndev->name'
to request both IRQs...
> IP-Config: Failed to open eth0
> IP-Config: No network devices available
>
> The "mismatch" is due to requesting an IRQ that is already in use,
> while IRQF_PROBE_SHARED wasn't set.
>
> However, the real cause is that ravb_close() doesn't release the R-Car
> Gen3-specific secondary IRQ.
>
> Add the missing free_irq() call to fix this.
>
> Fixes: 22d4df8ff3a3cc72 ("ravb: Add support for r8a7795 SoC")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
MBR, Sergei
next prev parent reply other threads:[~2016-05-07 18:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-07 11:17 [PATCH v2 0/2] ravb: Add missing free_irq() calls to ravb_close() Geert Uytterhoeven
2016-05-07 11:17 ` [PATCH v2 1/2 -net] ravb: Add missing free_irq() call " Geert Uytterhoeven
2016-05-07 18:39 ` Sergei Shtylyov [this message]
2016-05-07 19:42 ` Geert Uytterhoeven
2016-05-07 19:42 ` Geert Uytterhoeven
2016-05-07 11:17 ` [PATCH v2 2/2 -net-next] ravb: Add missing free_irq() calls " Geert Uytterhoeven
2016-05-07 18:45 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572E3673.5020304@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=geert+renesas@glider.be \
--cc=horms+renesas@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ykaneko0929@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.