From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: Add ag7xxx driver for Atheros MIPS
Date: Mon, 09 May 2016 00:09:46 +0200 [thread overview]
Message-ID: <572FB92A.8060502@denx.de> (raw)
In-Reply-To: <CABHD4K_Yjg2ndswqX4qe9dB859oPbG2nc8Y+wyeVay7LSQU9VA@mail.gmail.com>
On 05/08/2016 11:25 PM, Amit Tomer wrote:
> Hello!
Hi!
>> +
>> +#define CONFIG_TX_DESCR_NUM 8
>> +#define CONFIG_RX_DESCR_NUM 8
>> +#define CONFIG_ETH_BUFSIZE 2048
>
> Isn't it too BIG size for normal ethernet frame, unless we need Jumbo Frame ?
It is the next larger power of two from the 1536B ethernet frame, which
has the benefit:
- The buffers are aligned to half the page size (on this machine)
- There is enough space of oversized packets (due to tags etc)
Jumbo frames are 9k, they are not supported by u-boot and won't fit anyway.
Given the size of DRAM on MIPS machines with this SoC, microoptimizing
here seems pointless to me.
> Thanks,
> Amit.
>
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2016-05-08 22:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 19:34 [U-Boot] [PATCH] net: Add ag7xxx driver for Atheros MIPS Marek Vasut
2016-05-08 12:58 ` Daniel Schwierzeck
2016-05-08 15:22 ` Marek Vasut
2016-05-20 4:18 ` Wills Wang
2016-05-20 11:59 ` Marek Vasut
2016-05-20 16:43 ` Wills Wang
2016-05-20 17:08 ` Marek Vasut
2016-05-21 3:25 ` Wills Wang
2016-05-21 9:29 ` Marek Vasut
2016-05-24 15:15 ` Joe Hershberger
2016-05-24 15:17 ` Marek Vasut
2016-05-24 15:22 ` Marek Vasut
2016-05-21 11:03 ` Wills Wang
2016-05-21 11:37 ` Marek Vasut
2016-05-08 21:25 ` Amit Tomer
2016-05-08 22:09 ` Marek Vasut [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-05-24 21:29 Marek Vasut
2016-05-30 10:05 ` Daniel Schwierzeck
2017-06-08 15:04 ` Joe Hershberger
2017-06-09 9:02 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572FB92A.8060502@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.