From mboxrd@z Thu Jan 1 00:00:00 1970 From: Enric Balletbo i Serra Subject: Re: [PATCH] ARM: dts: Fix igepv5 audiopwon-gpio Date: Mon, 09 May 2016 10:39:15 +0200 Message-ID: <57304CB3.5010601@collabora.com> References: <1462474581-13865-1-git-send-email-tony@atomide.com> <1b37fbdd-67f0-e9e3-d442-bdc0bd74397b@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1b37fbdd-67f0-e9e3-d442-bdc0bd74397b@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Peter Ujfalusi , Tony Lindgren , linux-omap@vger.kernel.org Cc: Enric Balletbo Serra , =?UTF-8?B?QWd1c3TDrSBGb250cXVlcg==?= =?UTF-8?B?bmk=?= , Eduard Gavin , linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org CgpPbiAwOS8wNS8xNiAxMDozNCwgUGV0ZXIgVWpmYWx1c2kgd3JvdGU6Cj4gT24gMDUvMDUvMTYg MjE6NTYsIFRvbnkgTGluZGdyZW4gd3JvdGU6Cj4+IFBsYXlpbmcgYXVkaW8gd29ya3Mgb24gb21h cDUtdWV2bSwgYnV0IHByb2R1Y2VzIGFuICJVbmhhbmRsZWQgZmF1bHQ6Cj4+IGltcHJlY2lzZSBl eHRlcm5hbCBhYm9ydCAoMHgxNDA2KSBhdCAweDAwMDAwMDAwIiBlcnJvciBvbiBpZ2VwdjUuCj4+ Cj4+IExvb2tzIGxpa2UgdGhlIHR3bDYwNDAgYXVkcHdyb24gR1BJTyBwaW4gaXMgZGlmZmVyZW50 IGZvciB0aGVzZQo+PiBib2FyZHMuIExldCdzIGZpeCB0aGUgaXNzdWUgYnkgY29uZmlndXJpbmcg dGhlIGF1ZHB3cm9uIGluIHRoZQo+PiBib2FyZCBzcGVjaWZpYyBkdHMgZmlsZS4KPj4KPj4gQ2M6 IEFndXN0w60gRm9udHF1ZXJuaSA8YWZAaXNlZWJjbi5jb20+Cj4+IENjOiBFZHVhcmQgR2F2aW4g PGVnYXZpbkBpc2VlYmNuLmNvbT4KPj4gQ2M6IEVucmljIEJhbGxldGJvIGkgU2VycmEgPGViYWxs ZXRib0Bpc2VlYmNuLmNvbT4KCgpIZXksIGNhbiB5b3UgY2hhbmdlIHRoZSBlbWFpbCBhZGRyZXNz IGZvciB0aGlzIG9uZQoKQ2M6IEVucmljIEJhbGxldGJvIGkgU2VycmEgPGViYWxsZXRib0BnbWFp bC5jb20+CgpUaGFua3MhCgo+PiBDYzogUGV0ZXIgVWpmYWx1c2kgPHBldGVyLnVqZmFsdXNpQHRp LmNvbT4KPj4gU2lnbmVkLW9mZi1ieTogVG9ueSBMaW5kZ3JlbiA8dG9ueUBhdG9taWRlLmNvbT4K Pj4gLS0tCj4+ICBhcmNoL2FybS9ib290L2R0cy9vbWFwNS1ib2FyZC1jb21tb24uZHRzaSB8ICAz ICsrLQo+PiAgYXJjaC9hcm0vYm9vdC9kdHMvb21hcDUtaWdlcDAwNTAuZHRzICAgICAgfCAxMCAr KysrKysrKysrCj4+ICBhcmNoL2FybS9ib290L2R0cy9vbWFwNS11ZXZtLmR0cyAgICAgICAgICB8 IDEwICsrKysrKysrKysKPj4gIDMgZmlsZXMgY2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygrKSwgMSBk ZWxldGlvbigtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm0vYm9vdC9kdHMvb21hcDUtYm9h cmQtY29tbW9uLmR0c2kgYi9hcmNoL2FybS9ib290L2R0cy9vbWFwNS1ib2FyZC1jb21tb24uZHRz aQo+PiBpbmRleCAyZWVhMjZjLi4yM2IxZDdjIDEwMDY0NAo+PiAtLS0gYS9hcmNoL2FybS9ib290 L2R0cy9vbWFwNS1ib2FyZC1jb21tb24uZHRzaQo+PiArKysgYi9hcmNoL2FybS9ib290L2R0cy9v bWFwNS1ib2FyZC1jb21tb24uZHRzaQo+PiBAQCAtNjQyLDcgKzY0Miw4IEBACj4+ICAJCXBpbmN0 cmwtMCA9IDwmdHdsNjA0MF9waW5zPjsKPj4gIAo+PiAgCQlpbnRlcnJ1cHRzID0gPEdJQ19TUEkg MTE5IElSUV9UWVBFX05PTkU+OyAvKiBJUlFfU1lTXzJOIGNhc2NhZGVkIHRvIGdpYyAqLwo+PiAt CQl0aSxhdWRwd3Jvbi1ncGlvID0gPCZncGlvNSAxMyBHUElPX0FDVElWRV9ISUdIPjsgIC8qIGdw aW8gbGluZSAxNDEgKi8KPj4gKwo+PiArCQkvKiBhdWRwd3JvbiBncGlvIGRlZmluZWQgaW4gdGhl IGJvYXJkIHNwZWNpZmljIGR0cyAqLwo+PiAgCj4+ICAJCXZpby1zdXBwbHkgPSA8JnNtcHM3X3Jl Zz47Cj4+ICAJCXYydjEtc3VwcGx5ID0gPCZzbXBzOV9yZWc+Owo+PiBkaWZmIC0tZ2l0IGEvYXJj aC9hcm0vYm9vdC9kdHMvb21hcDUtaWdlcDAwNTAuZHRzIGIvYXJjaC9hcm0vYm9vdC9kdHMvb21h cDUtaWdlcDAwNTAuZHRzCj4+IGluZGV4IDcyZmY2YTQuLjY3M2NkZmEgMTAwNjQ0Cj4+IC0tLSBh L2FyY2gvYXJtL2Jvb3QvZHRzL29tYXA1LWlnZXAwMDUwLmR0cwo+PiArKysgYi9hcmNoL2FybS9i b290L2R0cy9vbWFwNS1pZ2VwMDA1MC5kdHMKPj4gQEAgLTU4LDMgKzU4LDEzIEBACj4+ICAJCTwm Z3BpbzcgMyAwPjsJCS8qIDE5NSwgU0RBICovCj4+ICB9Owo+PiAgCj4+ICsmdHdsNjA0MCB7Cj4+ ICsJdGksYXVkcHdyb24tZ3BpbyA9IDwmZ3BpbzUgMTYgR1BJT19BQ1RJVkVfSElHSD47ICAvKiBn cGlvIGxpbmUgMTQ0ICovCj4gCj4gQlRXOiBob3cgZG8geW91IGtub3cgdGhhdCBncGlvMTQ0IGlz IHVzZWQgYXMgYXVkcHdyb24gR1BJTyBvbiBpZ2VwdjU/Cj4gCj4+ICt9Owo+PiArCj4+ICsmdHds NjA0MF9waW5zIHsKPj4gKwlwaW5jdHJsLXNpbmdsZSxwaW5zID0gPAo+PiArCQlPTUFQNV9JT1BB RCgweDFjNCwgUElOX09VVFBVVCB8IE1VWF9NT0RFNikJLyogbWNzcGkxX3NvbWkuZ3BpbzVfMTQ0 ICovCj4+ICsJCU9NQVA1X0lPUEFEKDB4MWNhLCBQSU5fT1VUUFVUIHwgTVVYX01PREU2KQkvKiBw ZXJzbGltYnVzMl9jbG9jay5ncGlvNV8xNDUgKi8KPiAKPiBXaGF0IGRvZXMgdGhlIGdwaW8xNDUg aXMgdXNlZCBmb3I/Cj4gCj4+ICsJPjsKPj4gK307Cj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybS9i b290L2R0cy9vbWFwNS11ZXZtLmR0cyBiL2FyY2gvYXJtL2Jvb3QvZHRzL29tYXA1LXVldm0uZHRz Cj4+IGluZGV4IDYwYjNmYmIuLmE1MWU2MDUgMTAwNjQ0Cj4+IC0tLSBhL2FyY2gvYXJtL2Jvb3Qv ZHRzL29tYXA1LXVldm0uZHRzCj4+ICsrKyBiL2FyY2gvYXJtL2Jvb3QvZHRzL29tYXA1LXVldm0u ZHRzCj4+IEBAIC01MSwzICs1MSwxMyBAQAo+PiAgCQk8JmdwaW85IDEgR1BJT19BQ1RJVkVfSElH SD4sCS8qIFRDQTY0MjRBIFAwMCwgTFMgT0UgKi8KPj4gIAkJPCZncGlvNyAxIEdQSU9fQUNUSVZF X0hJR0g+OwkvKiBHUElPIDE5MywgSFBEICovCj4+ICB9Owo+PiArCj4+ICsmdHdsNjA0MCB7Cj4+ ICsJdGksYXVkcHdyb24tZ3BpbyA9IDwmZ3BpbzUgMTMgR1BJT19BQ1RJVkVfSElHSD47ICAvKiBn cGlvIGxpbmUgMTQxICovCj4+ICt9Owo+PiArCj4+ICsmdHdsNjA0MF9waW5zIHsKPj4gKwlwaW5j dHJsLXNpbmdsZSxwaW5zID0gPAo+PiArCQlPTUFQNV9JT1BBRCgweDFiZSwgUElOX09VVFBVVCB8 IE1VWF9NT0RFNikJLyogbWNzcGkxX3NvbWkuZ3BpbzVfMTQxICovCj4+ICsJPjsKPj4gK307Cj4+ Cj4gCj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: enric.balletbo@collabora.com (Enric Balletbo i Serra) Date: Mon, 09 May 2016 10:39:15 +0200 Subject: [PATCH] ARM: dts: Fix igepv5 audiopwon-gpio In-Reply-To: <1b37fbdd-67f0-e9e3-d442-bdc0bd74397b@ti.com> References: <1462474581-13865-1-git-send-email-tony@atomide.com> <1b37fbdd-67f0-e9e3-d442-bdc0bd74397b@ti.com> Message-ID: <57304CB3.5010601@collabora.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 09/05/16 10:34, Peter Ujfalusi wrote: > On 05/05/16 21:56, Tony Lindgren wrote: >> Playing audio works on omap5-uevm, but produces an "Unhandled fault: >> imprecise external abort (0x1406) at 0x00000000" error on igepv5. >> >> Looks like the twl6040 audpwron GPIO pin is different for these >> boards. Let's fix the issue by configuring the audpwron in the >> board specific dts file. >> >> Cc: Agust? Fontquerni >> Cc: Eduard Gavin >> Cc: Enric Balletbo i Serra Hey, can you change the email address for this one Cc: Enric Balletbo i Serra Thanks! >> Cc: Peter Ujfalusi >> Signed-off-by: Tony Lindgren >> --- >> arch/arm/boot/dts/omap5-board-common.dtsi | 3 ++- >> arch/arm/boot/dts/omap5-igep0050.dts | 10 ++++++++++ >> arch/arm/boot/dts/omap5-uevm.dts | 10 ++++++++++ >> 3 files changed, 22 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi >> index 2eea26c..23b1d7c 100644 >> --- a/arch/arm/boot/dts/omap5-board-common.dtsi >> +++ b/arch/arm/boot/dts/omap5-board-common.dtsi >> @@ -642,7 +642,8 @@ >> pinctrl-0 = <&twl6040_pins>; >> >> interrupts = ; /* IRQ_SYS_2N cascaded to gic */ >> - ti,audpwron-gpio = <&gpio5 13 GPIO_ACTIVE_HIGH>; /* gpio line 141 */ >> + >> + /* audpwron gpio defined in the board specific dts */ >> >> vio-supply = <&smps7_reg>; >> v2v1-supply = <&smps9_reg>; >> diff --git a/arch/arm/boot/dts/omap5-igep0050.dts b/arch/arm/boot/dts/omap5-igep0050.dts >> index 72ff6a4..673cdfa 100644 >> --- a/arch/arm/boot/dts/omap5-igep0050.dts >> +++ b/arch/arm/boot/dts/omap5-igep0050.dts >> @@ -58,3 +58,13 @@ >> <&gpio7 3 0>; /* 195, SDA */ >> }; >> >> +&twl6040 { >> + ti,audpwron-gpio = <&gpio5 16 GPIO_ACTIVE_HIGH>; /* gpio line 144 */ > > BTW: how do you know that gpio144 is used as audpwron GPIO on igepv5? > >> +}; >> + >> +&twl6040_pins { >> + pinctrl-single,pins = < >> + OMAP5_IOPAD(0x1c4, PIN_OUTPUT | MUX_MODE6) /* mcspi1_somi.gpio5_144 */ >> + OMAP5_IOPAD(0x1ca, PIN_OUTPUT | MUX_MODE6) /* perslimbus2_clock.gpio5_145 */ > > What does the gpio145 is used for? > >> + >; >> +}; >> diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts >> index 60b3fbb..a51e605 100644 >> --- a/arch/arm/boot/dts/omap5-uevm.dts >> +++ b/arch/arm/boot/dts/omap5-uevm.dts >> @@ -51,3 +51,13 @@ >> <&gpio9 1 GPIO_ACTIVE_HIGH>, /* TCA6424A P00, LS OE */ >> <&gpio7 1 GPIO_ACTIVE_HIGH>; /* GPIO 193, HPD */ >> }; >> + >> +&twl6040 { >> + ti,audpwron-gpio = <&gpio5 13 GPIO_ACTIVE_HIGH>; /* gpio line 141 */ >> +}; >> + >> +&twl6040_pins { >> + pinctrl-single,pins = < >> + OMAP5_IOPAD(0x1be, PIN_OUTPUT | MUX_MODE6) /* mcspi1_somi.gpio5_141 */ >> + >; >> +}; >> > >