From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH] x86: cap address bits CPUID output
Date: Mon, 9 May 2016 13:35:11 +0100 [thread overview]
Message-ID: <573083FF.8010507@citrix.com> (raw)
In-Reply-To: <57278A4D02000078000E7B8B@prv-mh.provo.novell.com>
On 02/05/16 16:11, Jan Beulich wrote:
> --- a/xen/arch/x86/e820.c
> +++ b/xen/arch/x86/e820.c
> @@ -451,11 +451,11 @@ static uint64_t __init mtrr_top_of_ram(v
> return 0;
>
> /* Find the physical address size for this CPU. */
> - cpuid(0x80000000, &eax, &ebx, &ecx, &edx);
> - if ( eax >= 0x80000008 )
> + if ( cpuid_eax(0x80000000) >= 0x80000008 )
You indicated in review of my cpuid series that this check is buggy, and
the upper half needs comparing exactly to 0x8000.
It occurs to me that early_cpu_detect() really should be callled
earlier, to avoid needing to recalculate this information.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-05-09 12:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 15:11 [PATCH] x86: cap address bits CPUID output Jan Beulich
2016-05-09 10:13 ` Ping: " Jan Beulich
2016-05-09 12:35 ` Andrew Cooper [this message]
2016-05-09 12:38 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573083FF.8010507@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.