From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Roopa Prabhu <roopa@cumulusnetworks.com>
Cc: stephen@networkplumber.org, netdev@vger.kernel.org,
davem@davemloft.net, edumazet@google.com, tgraf@suug.ch,
nicolas.dichtel@6wind.com, nikolay@cumulusnetworks.com
Subject: Re: [PATCH iproute2 net-next] ifstat: move to new RTM_GETSTATS api
Date: Mon, 9 May 2016 08:38:04 -0400 [thread overview]
Message-ID: <573084AC.6030407@mojatatu.com> (raw)
In-Reply-To: <573016F1.8050700@cumulusnetworks.com>
On 16-05-09 12:49 AM, Roopa Prabhu wrote:
> On 4/30/16, 8:15 AM, Roopa Prabhu wrote:
>> On 4/30/16, 3:21 AM, Jamal Hadi Salim wrote:
> AFAICS ifstat history file handling today assumes all 32 bit stats.
Indeed it does.
> And to preserve backward compatibility, new ifstat should work with old and
> new history files with 32bit and 64 bit stats.
True.
It may be ok to just provide a conversion tool maybe for taking 32b
history into 64b? I dont know if someone is going to "migrate" their
history files so even that may not be worth it.
> The file format cannot be changed because of the same backward compat issues.
> So, I am leaning towards a new history file with a new option (maybe ifstat -64) to
> save/query 64 bit stats using the new api when available.
>
> I see some previous brief discussions on moving ifstat to 64 bit.
>
> The other option is to only change 'ip -s link show' to use the new stats api.
>
> let me know if there are other thoughts.
>
Is it not possible to convert to 64b - and IFLA_STAT
becomes available just store it still in 64b?
i.e 32b will fit in 64b space.
cheers,
jamal
next prev parent reply other threads:[~2016-05-09 12:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-30 6:41 [PATCH iproute2 net-next] ifstat: move to new RTM_GETSTATS api Roopa Prabhu
2016-04-30 10:21 ` Jamal Hadi Salim
2016-04-30 15:15 ` Roopa Prabhu
2016-05-09 4:49 ` Roopa Prabhu
2016-05-09 12:38 ` Jamal Hadi Salim [this message]
2016-05-10 16:25 ` Roopa Prabhu
2016-05-11 11:24 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573084AC.6030407@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.