From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] KVM: x86: silence GCC warning on memset ioapic->irq_eoi Date: Mon, 9 May 2016 15:02:55 +0200 Message-ID: <57308A7F.9020309@redhat.com> References: <1462210453-27907-1-git-send-email-rkrcmar@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: David Binderman To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:53608 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751157AbcEINC6 (ORCPT ); Mon, 9 May 2016 09:02:58 -0400 In-Reply-To: <1462210453-27907-1-git-send-email-rkrcmar@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 02/05/2016 19:34, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: > New GCC notices a mistake, > arch/x86/kvm/ioapic.c:595:2: warning: =E2=80=98memset=E2=80=99 used= with length equal > to number of elements without multiplication by element size > [-Wmemset-elt-size] >=20 > that has no effect on execution, because we zero a zeroed array. > Preserve the useless memset as kvm_ioapic_reset() wants to be generic= =2E >=20 > Reported-by: David Binderman > Signed-off-by: Radim Kr=C4=8Dm=C3=A1=C5=99 > --- > arch/x86/kvm/ioapic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/arch/x86/kvm/ioapic.c b/arch/x86/kvm/ioapic.c > index 9db47090ead0..4861e6e622a3 100644 > --- a/arch/x86/kvm/ioapic.c > +++ b/arch/x86/kvm/ioapic.c > @@ -592,7 +592,7 @@ static void kvm_ioapic_reset(struct kvm_ioapic *i= oapic) > ioapic->irr =3D 0; > ioapic->irr_delivered =3D 0; > ioapic->id =3D 0; > - memset(ioapic->irq_eoi, 0x00, IOAPIC_NUM_PINS); > + memset(ioapic->irq_eoi, 0x00, sizeof(ioapic->irq_eoi)); > rtc_irq_eoi_tracking_reset(ioapic); > } > =20 >=20 Reviewed-by: Paolo Bonzini