From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 07/23] drm: omapdrm: Handle FIFO underflow IRQs internally Date: Mon, 9 May 2016 17:42:43 +0300 Message-ID: <5730A1E3.9090305@ti.com> References: <1461702945-14185-1-git-send-email-laurent.pinchart@ideasonboard.com> <1461702945-14185-8-git-send-email-laurent.pinchart@ideasonboard.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0568583268==" Return-path: Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7525189C6C for ; Mon, 9 May 2016 14:42:49 +0000 (UTC) In-Reply-To: <1461702945-14185-8-git-send-email-laurent.pinchart@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0568583268== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="x1lc9tt0mdexqTT5kwrQVafISwD3VpkPx" --x1lc9tt0mdexqTT5kwrQVafISwD3VpkPx Content-Type: multipart/mixed; boundary="J7cutNwGxaRhi06TquU3BDgAR0bX3MBdS" From: Tomi Valkeinen To: Laurent Pinchart , dri-devel@lists.freedesktop.org Cc: Rob Clark Message-ID: <5730A1E3.9090305@ti.com> Subject: Re: [PATCH 07/23] drm: omapdrm: Handle FIFO underflow IRQs internally References: <1461702945-14185-1-git-send-email-laurent.pinchart@ideasonboard.com> <1461702945-14185-8-git-send-email-laurent.pinchart@ideasonboard.com> In-Reply-To: <1461702945-14185-8-git-send-email-laurent.pinchart@ideasonboard.com> --J7cutNwGxaRhi06TquU3BDgAR0bX3MBdS Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 26/04/16 23:35, Laurent Pinchart wrote: > As the FIFO underflow IRQ handler just prints an error message to the > kernel log, simplify the code by not registering one IRQ handler per > plane but print the messages directly from the main IRQ handler. >=20 > Signed-off-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/omap_drv.h | 2 +- > drivers/gpu/drm/omapdrm/omap_irq.c | 49 ++++++++++++++++++++++++++++= +++++--- > drivers/gpu/drm/omapdrm/omap_plane.c | 24 ------------------ > 3 files changed, 47 insertions(+), 28 deletions(-) > @@ -233,6 +271,11 @@ int omap_drm_irq_install(struct drm_device *dev) > =20 > INIT_LIST_HEAD(&priv->irq_list); > =20 > + priv->irq_mask =3D DISPC_IRQ_GFX_FIFO_UNDERFLOW > + | DISPC_IRQ_VID1_FIFO_UNDERFLOW > + | DISPC_IRQ_VID2_FIFO_UNDERFLOW > + | DISPC_IRQ_VID3_FIFO_UNDERFLOW; Not all VID overlays exist on all DSS versions, so we shouldn't register irqs that don't exist on the HW. Also, I do like it that we deal with crtc or plane interrupts in omap_crtc or omap_plane. Would similar approach here work as you use in the following patches, i.e. just call underflow-handler func in omap_plane.c directly, instead of using the registration mechanism? Tomi --J7cutNwGxaRhi06TquU3BDgAR0bX3MBdS-- --x1lc9tt0mdexqTT5kwrQVafISwD3VpkPx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXMKHjAAoJEPo9qoy8lh71IfAP/17BY1d8d2e6khvzFnmF2iTD hEst8cLRDzWVXSOtM2G4gaprg4bFi2I9TLZm5jdE42cbleIOm+gTmNPlBm5z0PkC YwVmy1tcoSuvUMqvq2lviEY/A/RYMK9ZFjyLJ+IbQ7jU/gf0lb1yqwj01lXppa3x /O+e38y3oCqrusrpaDF6OmH1xjO4u6eBKHALfPj4p60Ws1n3Xo7jZFF6RPKslct+ Pw4TQ3eFhjf66aqAwY9oXF/jaoo387dwbF4alB+g9gmyXph5EM87/W6uRaj+v3Ti 6Ix62hX2APgef+8t7sf/3FhiQTlcObpNn8/m/YmsAOFQW0djDu0D1MnGPQq8ZaJR OsbusV1/Qbn5d8g8hSwSFkuHVkA6pSl2x1PDh75+9ZuOmq/BVg96GeCOCn7rAo5C VPxo4t6iNZQNZAhQ1BqH+ruww+b/HR/luwj6bmh1xsWTrXkLGS+F8fABvtAzCCpD 7XhDf6WIY9TAXlSnSkuPu84M3M3i0KdmM7GnzbOR37BUy84yXM3LLnSqig0Lmysd XIUKRgCUR/U+CXlB85Ps9VtzVZZOAqmXSr3bHn1CFpKaiW6kktBJFR3UmMDjQ8Te JOwrfb+1YBlNoST+NSFUmcL2Y5BVrCbelSJVVFp6wfxexE5sMcBeR3yMl7XUcQvD 2Kgwij1KhBb+U3fSR4Nq =LOIs -----END PGP SIGNATURE----- --x1lc9tt0mdexqTT5kwrQVafISwD3VpkPx-- --===============0568583268== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0568583268==--