All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bart.vanassche@sandisk.com>
To: dgilbert@interlog.com, linux-scsi@vger.kernel.org
Cc: martin.petersen@oracle.com, tomas.winkler@intel.com, emilne@redhat.com
Subject: Re: [PATCH v3 3/6] scsi_debug: add multiple queue support
Date: Mon, 9 May 2016 15:36:33 -0700	[thread overview]
Message-ID: <573110F1.2030305@sandisk.com> (raw)
In-Reply-To: <57310F93.2000709@interlog.com>

On 05/09/2016 03:30 PM, Douglas Gilbert wrote:> The maximum return value 
from the first scnprintf(sdebug_info ...)
> is (sizeof(sdebug_info) - 1)). So strictly speaking the early return
> comparison should be "==" for scnprintf and ">=" for snprintf. Given
> that snprintf is more dangerous then scnprintf (e.g. with repeated
> "k += snprintf(buff + k, buff_len - k, ...)" statements) then I would
> prefer to keep scnprintf and yes, ">=" is overkill but will work.

Thanks for the feedback. I'm fine with the other changes in this patch, 
hence:

Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>

  reply	other threads:[~2016-05-09 22:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-06  4:40 [PATCH v3 0/6] scsi_debug: multiple queue support and cleanup Douglas Gilbert
2016-05-06  4:40 ` [PATCH v3 1/6] scsi_debug: use pdt constants Douglas Gilbert
2016-05-06  4:40 ` [PATCH v3 2/6] scsi_debug: rework resp_report_luns Douglas Gilbert
2016-05-06  4:40 ` [PATCH v3 3/6] scsi_debug: add multiple queue support Douglas Gilbert
2016-05-09 16:12   ` Bart Van Assche
2016-05-09 22:30     ` Douglas Gilbert
2016-05-09 22:36       ` Bart Van Assche [this message]
2016-05-06  4:40 ` [PATCH v3 4/6] scsi_debug: vpd and mode page work Douglas Gilbert
2016-05-06  4:40 ` [PATCH v3 5/6] scsi_debug: uuid for lu name Douglas Gilbert
2016-05-31 12:57   ` Andy Shevchenko
2016-05-06  4:40 ` [PATCH v3 6/6] scsi_debug: use locally assigned naa Douglas Gilbert
2016-05-11  1:27 ` [PATCH v3 0/6] scsi_debug: multiple queue support and cleanup Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=573110F1.2030305@sandisk.com \
    --to=bart.vanassche@sandisk.com \
    --cc=dgilbert@interlog.com \
    --cc=emilne@redhat.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.