From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH v6 5/9] extcon: max8997: Fix handling error code of regmap_irq_get_virq() Date: Tue, 10 May 2016 10:23:45 +0900 Message-ID: <57313821.4050309@samsung.com> References: <1462519289-2356-2-git-send-email-k.kozlowski@samsung.com> <1462519636-3250-1-git-send-email-k.kozlowski@samsung.com> <1462519636-3250-4-git-send-email-k.kozlowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mailout4.samsung.com ([203.254.224.34]:44073 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751766AbcEJBXu (ORCPT ); Mon, 9 May 2016 21:23:50 -0400 In-reply-to: <1462519636-3250-4-git-send-email-k.kozlowski@samsung.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Krzysztof Kozlowski , Kukjin Kim , MyungJoo Ham , Dmitry Torokhov , Richard Purdie , Jacek Anaszewski , Lee Jones , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Liam Girdwood , Mark Brown , Alessandro Zummo , Alexandre Belloni , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org, rtc-linux@googlegroups.com Cc: r.baldyga@hackerion.com, Bartlomiej Zolnierkiewicz Hi Krzysztof, On 2016=EB=85=84 05=EC=9B=94 06=EC=9D=BC 16:27, Krzysztof Kozlowski wro= te: > The regmap_irq_get_virq() can return negative ERRNO, so its result > should not be stored in unsigned int because error would be ignored. >=20 > Signed-off-by: Krzysztof Kozlowski > --- > drivers/extcon/extcon-max8997.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-= max8997.c > index 68754ac2c8ea..0afa3e8b5dc3 100644 > --- a/drivers/extcon/extcon-max8997.c > +++ b/drivers/extcon/extcon-max8997.c > @@ -660,11 +660,11 @@ static int max8997_muic_probe(struct platform_d= evice *pdev) > =20 > for (i =3D 0; i < ARRAY_SIZE(muic_irqs); i++) { > struct max8997_muic_irq *muic_irq =3D &muic_irqs[i]; > - unsigned int virq =3D 0; > + int virq =3D 0; > =20 > virq =3D regmap_irq_get_virq(max8997->irq_data_muic, > muic_irq->irq); > - if (!virq) { > + if (virq <=3D 0) { > ret =3D -EINVAL; > goto err_irq; > } >=20 Acked-by: Chanwoo Choi Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by gmr-mx.google.com with ESMTPS id 17si5091763pfw.0.2016.05.09.18.23.47 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 09 May 2016 18:23:47 -0700 (PDT) MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O6X00AD7T7MW160@mailout4.samsung.com> for rtc-linux@googlegroups.com; Tue, 10 May 2016 10:23:46 +0900 (KST) Message-id: <57313821.4050309@samsung.com> Date: Tue, 10 May 2016 10:23:45 +0900 From: Chanwoo Choi To: Krzysztof Kozlowski , Kukjin Kim , MyungJoo Ham , Dmitry Torokhov , Richard Purdie , Jacek Anaszewski , Lee Jones , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Liam Girdwood , Mark Brown , Alessandro Zummo , Alexandre Belloni , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org, rtc-linux@googlegroups.com Cc: r.baldyga@hackerion.com, Bartlomiej Zolnierkiewicz Subject: [rtc-linux] Re: [PATCH v6 5/9] extcon: max8997: Fix handling error code of regmap_irq_get_virq() References: <1462519289-2356-2-git-send-email-k.kozlowski@samsung.com> <1462519636-3250-1-git-send-email-k.kozlowski@samsung.com> <1462519636-3250-4-git-send-email-k.kozlowski@samsung.com> In-reply-to: <1462519636-3250-4-git-send-email-k.kozlowski@samsung.com> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Hi Krzysztof, On 2016=EB=85=84 05=EC=9B=94 06=EC=9D=BC 16:27, Krzysztof Kozlowski wrote: > The regmap_irq_get_virq() can return negative ERRNO, so its result > should not be stored in unsigned int because error would be ignored. >=20 > Signed-off-by: Krzysztof Kozlowski > --- > drivers/extcon/extcon-max8997.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8= 997.c > index 68754ac2c8ea..0afa3e8b5dc3 100644 > --- a/drivers/extcon/extcon-max8997.c > +++ b/drivers/extcon/extcon-max8997.c > @@ -660,11 +660,11 @@ static int max8997_muic_probe(struct platform_devic= e *pdev) > =20 > for (i =3D 0; i < ARRAY_SIZE(muic_irqs); i++) { > struct max8997_muic_irq *muic_irq =3D &muic_irqs[i]; > - unsigned int virq =3D 0; > + int virq =3D 0; > =20 > virq =3D regmap_irq_get_virq(max8997->irq_data_muic, > muic_irq->irq); > - if (!virq) { > + if (virq <=3D 0) { > ret =3D -EINVAL; > goto err_irq; > } >=20 Acked-by: Chanwoo Choi Thanks, Chanwoo Choi --=20 --=20 You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. ---=20 You received this message because you are subscribed to the Google Groups "= rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: cw00.choi@samsung.com (Chanwoo Choi) Date: Tue, 10 May 2016 10:23:45 +0900 Subject: [PATCH v6 5/9] extcon: max8997: Fix handling error code of regmap_irq_get_virq() In-Reply-To: <1462519636-3250-4-git-send-email-k.kozlowski@samsung.com> References: <1462519289-2356-2-git-send-email-k.kozlowski@samsung.com> <1462519636-3250-1-git-send-email-k.kozlowski@samsung.com> <1462519636-3250-4-git-send-email-k.kozlowski@samsung.com> Message-ID: <57313821.4050309@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Krzysztof, On 2016? 05? 06? 16:27, Krzysztof Kozlowski wrote: > The regmap_irq_get_virq() can return negative ERRNO, so its result > should not be stored in unsigned int because error would be ignored. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/extcon/extcon-max8997.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c > index 68754ac2c8ea..0afa3e8b5dc3 100644 > --- a/drivers/extcon/extcon-max8997.c > +++ b/drivers/extcon/extcon-max8997.c > @@ -660,11 +660,11 @@ static int max8997_muic_probe(struct platform_device *pdev) > > for (i = 0; i < ARRAY_SIZE(muic_irqs); i++) { > struct max8997_muic_irq *muic_irq = &muic_irqs[i]; > - unsigned int virq = 0; > + int virq = 0; > > virq = regmap_irq_get_virq(max8997->irq_data_muic, > muic_irq->irq); > - if (!virq) { > + if (virq <= 0) { > ret = -EINVAL; > goto err_irq; > } > Acked-by: Chanwoo Choi Thanks, Chanwoo Choi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753454AbcEJBXy (ORCPT ); Mon, 9 May 2016 21:23:54 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:44073 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751766AbcEJBXu (ORCPT ); Mon, 9 May 2016 21:23:50 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee690-f79056d000001327-79-573138220647 Content-transfer-encoding: 8BIT Message-id: <57313821.4050309@samsung.com> Date: Tue, 10 May 2016 10:23:45 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Krzysztof Kozlowski , Kukjin Kim , MyungJoo Ham , Dmitry Torokhov , Richard Purdie , Jacek Anaszewski , Lee Jones , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Liam Girdwood , Mark Brown , Alessandro Zummo , Alexandre Belloni , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org, rtc-linux@googlegroups.com Cc: r.baldyga@hackerion.com, Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v6 5/9] extcon: max8997: Fix handling error code of regmap_irq_get_virq() References: <1462519289-2356-2-git-send-email-k.kozlowski@samsung.com> <1462519636-3250-1-git-send-email-k.kozlowski@samsung.com> <1462519636-3250-4-git-send-email-k.kozlowski@samsung.com> In-reply-to: <1462519636-3250-4-git-send-email-k.kozlowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA01Sa0hTYRjm29k5O04HJ1P7EitYF0nUnJv2iZH+61CBhYXRH1vroKLOtU3L CJxYXjPdxLSZF8zA7KIdC7yRNldog7ylGelMnWXMMC+Jlsw2J+S/932eh/d5HnhJzF2He5MJ cjWjlEuThASf+9RDogwQIlFMkO4TheoGhnkod+QhB70ob8RR6aSFQDrLPIaqjR9w1F07C5D2 cQmGCoe/A2SdFaGiaSuGJn6/BWjlYy4HsdMjOPq8uIKjobYHBHo19xygpUIjQOV9rznoS2Y9 gcZtiwC1t83gqDMvFyBTuzoS0hZ2ANCt+nEe3aHtJWhj6zuCbq73o9mGPIIeG+mwb3UZdEf1 Kk7ffdkA6LKqNQ69xO4943aRf+wKk5SQxiiPHL/Ejx/b2MAVg+R1TUEBTwOWiXxAkpCSwF9/ wvOBi330gv3mRjvMJ92pegCzujWYk5BAzYKF5yQeAfh14QlwEAJqB1wtMXMdhzBqHzQOJjpg jPKFuqpazKn/CuD6z/xNMwHlBzVWP4eGSx2EZnaG45gJO9w5O7op8aQuwIKedAfsQfUSMLPM xXk9Gq6VbprupGJh0XrOVswuACcap3kOwoU6AU1N77cir5Iw++9ppxUFV0oMXGfdPZDt2pLs hm/qR7nFwEu/rYv+fxf9ti41AGsAnoxCplBdjlNKAlXSZFWqPC5QlpLMAvurmGzfiluAuSvc ACgSCN0ELXxRjDsuTVOlJxtAiD2EFvP2lKXYv0uujhWJQ4NRiCREHHw0LFS4S2D1Xot2p+Kk aiaRYRSMMlaZmsSoDIBDunhrQOCdyshaU3h0VUVbc8phTUbUD1+Rto8Tc9LoeWohQhzVPHm2 1JXlrYTdGIkIyLPWXKtEifKl/oB5+bkK2W1FAooTZN070KqeY3ua5nx0Y0MbV332y9IDaor0 vYfKOQ3nDctJeTerc2ydvVOV/s9qTFO2W3W8IP/qbJPrfXHTgpCripeK/DClSvoPr9fJhiUD AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIKsWRmVeSWpSXmKPExsVy+t9jAV0lC8NwgzcdHBZLLl5lt+i4tpjJ YuOM9awWUx8+YbOY9OQ9s8X8I+dYLQ4vesFoMXHlZGaL3qvPGS1evzC06H/8mtni/tejjBbf rnQwWWx6fI3V4uanb6wWl3fNYbPY+mYdo8Xn3iOMFjPO72OyuN24gs3i7r9PjBa7dz1ltdjf 2cFocXp3iYOEx5NNFxk9ds66y+6xZ+JJNo8jO4+xeWxeoeWxaVUnm8eda3uAvCX1Hnvm/2D1 6NuyitFj+ryfTB6fN8kF8EQ1MNpkpCampBYppOYl56dk5qXbKnkHxzvHm5oZGOoaWlqYKynk Jeam2iq5+AToumXmAP2upFCWmFMKFApILC5W0rfDNCE0xE3XAqYxQtc3JAiux8gADSSsYcy4 8/8/a8EljoqG7m72BsYvbF2MnBwSAiYSDR+fsEPYYhIX7q0HinNxCAksZZR48HE1I0iCV0BQ 4sfkeyxdjBwczALyEkcuZYOEmQXUJSbNW8QMUf+AUeLP2y42kBpeAS2JhtdaIDUsAqoS9zY9 ZQKx2YDC+1/cACsRFYiQ6D5RCRIWETjJJtE4nRNierDEz6lgS4UF4iX6/7RDXXOAUeL++sdg Z3IKuEuc3nCKeQKjwCwkx81COG4WkuMWMDKvYpRILUguKE5KzzXKSy3XK07MLS7NS9dLzs/d xAhOXs+kdzAe3uV+iFGAg1GJh1eA1zBciDWxrLgy9xCjBAezkgjvVGOgEG9KYmVValF+fFFp TmrxIUZToPcmMkuJJucDE2teSbyhsYmZkaWRuaGFkbG5kjjv4//rwoQE0hNLUrNTUwtSi2D6 mDg4pRoYyzvU3lqXaZX57nE4LOO/a1fHVKvpT6fHBu6UPvzldv1VOf93+9Nr9igwh2Q9b9NV eZiw1lx/Y65cWCxPoZOemOqqW3/9Ewr26/j23kr2qFnY1iTDb3zovkGg0bI5Dd3ZXMvlAzj/ rzb7frFYrbz3h9fmH+3c9pcfTjVZ9vhnHPvCXlZWbnclluKMREMt5qLiRABU5TaVdAMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On 2016년 05월 06일 16:27, Krzysztof Kozlowski wrote: > The regmap_irq_get_virq() can return negative ERRNO, so its result > should not be stored in unsigned int because error would be ignored. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/extcon/extcon-max8997.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c > index 68754ac2c8ea..0afa3e8b5dc3 100644 > --- a/drivers/extcon/extcon-max8997.c > +++ b/drivers/extcon/extcon-max8997.c > @@ -660,11 +660,11 @@ static int max8997_muic_probe(struct platform_device *pdev) > > for (i = 0; i < ARRAY_SIZE(muic_irqs); i++) { > struct max8997_muic_irq *muic_irq = &muic_irqs[i]; > - unsigned int virq = 0; > + int virq = 0; > > virq = regmap_irq_get_virq(max8997->irq_data_muic, > muic_irq->irq); > - if (!virq) { > + if (virq <= 0) { > ret = -EINVAL; > goto err_irq; > } > Acked-by: Chanwoo Choi Thanks, Chanwoo Choi