From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BBD1C4332F for ; Tue, 22 Nov 2022 14:00:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233932AbiKVOA1 (ORCPT ); Tue, 22 Nov 2022 09:00:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232586AbiKVOAZ (ORCPT ); Tue, 22 Nov 2022 09:00:25 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 11A0866CB6; Tue, 22 Nov 2022 06:00:23 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 217861FB; Tue, 22 Nov 2022 06:00:29 -0800 (PST) Received: from [10.57.3.106] (unknown [10.57.3.106]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 185633F73D; Tue, 22 Nov 2022 06:00:19 -0800 (PST) Message-ID: <57315669-e6e7-08b8-a252-bc35d4fecc01@arm.com> Date: Tue, 22 Nov 2022 14:00:18 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [External] : [RFC PATCH v2 1/6] perf vendor events arm64: Add topdown L1 metrics for neoverse-n2 Content-Language: en-US To: John Garry , Jing Zhang Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andrew Kilroy , Shuai Xue , Zhuo Song , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Will Deacon , Mike Leach , Leo Yan , Ian Rogers References: <1667214694-89839-1-git-send-email-renyu.zj@linux.alibaba.com> <1668411720-3581-2-git-send-email-renyu.zj@linux.alibaba.com> <590ff032-d271-48ee-a4d8-141cc070c335@oracle.com> <75c4f0e6-3f28-a748-e891-7be6016ca28e@oracle.com> From: James Clark In-Reply-To: <75c4f0e6-3f28-a748-e891-7be6016ca28e@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On 21/11/2022 17:55, John Garry wrote: > On 21/11/2022 15:17, Jing Zhang wrote: >> I'm sorry that I misunderstood the purpose of putting metric as >> arch_std_event at first, >> and now it works after the modification over your suggestion. >> >> But there are also a few questions: >> >> 1. The value of the slot in the topdownL1 is various in different >> architectures, for example, >> the slot is 5 on neoverse-n2. If I put topdownL1 metric as >> arch_std_event, then I need to >> specify the slot to 5 in n2. I can specify slot values in metric like >> below, but is there any >> other concise way to do this? >> >> diff --git >> a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json >> b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json >> index 8ff1dfe..b473baf 100644 >> --- a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json >> +++ b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json >> @@ -1,4 +1,23 @@ >> [ >> +       { >> +               "MetricExpr": "5", >> +               "PublicDescription": "A pipeline slot represents the >> hardware resources needed to process one uOp", >> +               "BriefDescription": "A pipeline slot represents the >> hardware resources needed to process one uOp", >> +               "MetricName": "slot" > > Ehhh....I'm not sure if that is a good idea. Ian or anyone else have an > opinion on this? It is possible to reuse metrics, so it should work, but... > > One problem is that "slot" would show up as a metric, which you would > not want. > > Alternatively I was going to suggest that you can overwrite specific std > arch event attributes. So for example of frontend_bound, you could have: I would agree with not having this and just hard coding the 5 wherever it's needed. Once we have a few different sets of metrics in place maybe we can start to look at deduplication, but for now I don't see the value. > > + b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json > @@ -0,0 +1,30 @@ > [ >     { >     "ArchStdEvent": "FRONTEND_BOUND", >         "MetricExpr": "(stall_slot_frontend - cpu_cycles) / (5 * > cpu_cycles)", >     }, > >> +       } >> +       { >> +               "ArchStdEvent": "FRONTEND_BOUND" >> +       }, >> +       { >> +               "ArchStdEvent": "BACKEND_BOUND" >> +       }, >> +       { >> +               "ArchStdEvent": "WASTED" >> +       }, >> +       { >> +               "ArchStdEvent": "RETIRING" >> +       }, >> >> >> 2. Should I add the topdownL1 metric to >> tools/perf/pmu-event/recommended.json, >> or create a new json file to place the general metric? > > It would not belong in recommended.json as that is specifically for > arch-recommended events. It would really just depend on where the value > comes from, i.e. arm arm or sbsa. > For what we're going to publish shortly we'll be generating a metrics.json file for each CPU. It will be autogenerated so I don't think duplication will be an issue and I'm expecting that there will be differences in the topdown metrics between CPUs anyway. So I would also vote to not put it in recommended.json >> >> Looking forward to your reply. > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D2CEC4332F for ; Tue, 22 Nov 2022 14:02:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hsZtFTXDE+Fn8ZVca3KEB32joVcKs+Kerlmr1+NL/Z4=; b=jc+jAUw8qLdBD3 R2Qi6jMzIl5uLbPLiZ8SCcNSqLKhIafGJYqGZg5yABSd7QzEr80KD0mARwLKZI/qlBjPB0M/jew0/ YV5bE83up4XVp8gKWQR5Ckwgmw0/UoGJGUDwow0M74d8UyfHSSa/iGVYF+LfBBQ32ivDfy9cjYBdD lcyTcEKCljlg7V4xqcji2LFVLsJRAoqIiu/os4ajEiZ1RtxRMiqdhRpdVfA2zUmCcSx0x31mnP65d o6M97j58hhTGTV9jBxZw4uYn1ix0MAQoDNAmMQosh0xjQePYjxvooE5Z3f9zuWPae/kg5c7qGbEwB 6QVp5PiyS5mend5t6LxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxTpA-009mrY-3B; Tue, 22 Nov 2022 14:00:32 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxTp5-009moZ-Gf for linux-arm-kernel@lists.infradead.org; Tue, 22 Nov 2022 14:00:29 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 217861FB; Tue, 22 Nov 2022 06:00:29 -0800 (PST) Received: from [10.57.3.106] (unknown [10.57.3.106]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 185633F73D; Tue, 22 Nov 2022 06:00:19 -0800 (PST) Message-ID: <57315669-e6e7-08b8-a252-bc35d4fecc01@arm.com> Date: Tue, 22 Nov 2022 14:00:18 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [External] : [RFC PATCH v2 1/6] perf vendor events arm64: Add topdown L1 metrics for neoverse-n2 Content-Language: en-US To: John Garry , Jing Zhang Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andrew Kilroy , Shuai Xue , Zhuo Song , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Will Deacon , Mike Leach , Leo Yan , Ian Rogers References: <1667214694-89839-1-git-send-email-renyu.zj@linux.alibaba.com> <1668411720-3581-2-git-send-email-renyu.zj@linux.alibaba.com> <590ff032-d271-48ee-a4d8-141cc070c335@oracle.com> <75c4f0e6-3f28-a748-e891-7be6016ca28e@oracle.com> From: James Clark In-Reply-To: <75c4f0e6-3f28-a748-e891-7be6016ca28e@oracle.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221122_060027_679330_FCD80D8E X-CRM114-Status: GOOD ( 30.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAyMS8xMS8yMDIyIDE3OjU1LCBKb2huIEdhcnJ5IHdyb3RlOgo+IE9uIDIxLzExLzIwMjIg MTU6MTcsIEppbmcgWmhhbmcgd3JvdGU6Cj4+IEknbSBzb3JyeSB0aGF0IEkgbWlzdW5kZXJzdG9v ZCB0aGUgcHVycG9zZSBvZiBwdXR0aW5nIG1ldHJpYyBhcwo+PiBhcmNoX3N0ZF9ldmVudCBhdCBm aXJzdCwKPj4gYW5kIG5vdyBpdCB3b3JrcyBhZnRlciB0aGUgbW9kaWZpY2F0aW9uIG92ZXIgeW91 ciBzdWdnZXN0aW9uLgo+Pgo+PiBCdXQgdGhlcmUgYXJlIGFsc28gYSBmZXcgcXVlc3Rpb25zOgo+ Pgo+PiAxLiBUaGUgdmFsdWUgb2YgdGhlIHNsb3QgaW4gdGhlIHRvcGRvd25MMSBpcyB2YXJpb3Vz IGluIGRpZmZlcmVudAo+PiBhcmNoaXRlY3R1cmVzLCBmb3IgZXhhbXBsZSwKPj4gdGhlIHNsb3Qg aXMgNSBvbiBuZW92ZXJzZS1uMi4gSWYgSSBwdXQgdG9wZG93bkwxIG1ldHJpYyBhcwo+PiBhcmNo X3N0ZF9ldmVudCwgdGhlbiBJIG5lZWQgdG8KPj4gc3BlY2lmeSB0aGUgc2xvdCB0byA1IGluIG4y LiBJIGNhbiBzcGVjaWZ5IHNsb3QgdmFsdWVzIGluIG1ldHJpYyBsaWtlCj4+IGJlbG93LCBidXQg aXMgdGhlcmUgYW55Cj4+IG90aGVyIGNvbmNpc2Ugd2F5IHRvIGRvIHRoaXM/Cj4+Cj4+IGRpZmYg LS1naXQKPj4gYS90b29scy9wZXJmL3BtdS1ldmVudHMvYXJjaC9hcm02NC9hcm0vbmVvdmVyc2Ut bjIvbWV0cmljcy5qc29uCj4+IGIvdG9vbHMvcGVyZi9wbXUtZXZlbnRzL2FyY2gvYXJtNjQvYXJt L25lb3ZlcnNlLW4yL21ldHJpY3MuanNvbgo+PiBpbmRleCA4ZmYxZGZlLi5iNDczYmFmIDEwMDY0 NAo+PiAtLS0gYS90b29scy9wZXJmL3BtdS1ldmVudHMvYXJjaC9hcm02NC9hcm0vbmVvdmVyc2Ut bjIvbWV0cmljcy5qc29uCj4+ICsrKyBiL3Rvb2xzL3BlcmYvcG11LWV2ZW50cy9hcmNoL2FybTY0 L2FybS9uZW92ZXJzZS1uMi9tZXRyaWNzLmpzb24KPj4gQEAgLTEsNCArMSwyMyBAQAo+PiBbCj4+ ICvCoMKgwqDCoMKgwqAgewo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAiTWV0cmlj RXhwciI6ICI1IiwKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgIlB1YmxpY0Rlc2Ny aXB0aW9uIjogIkEgcGlwZWxpbmUgc2xvdCByZXByZXNlbnRzIHRoZQo+PiBoYXJkd2FyZSByZXNv dXJjZXMgbmVlZGVkIHRvIHByb2Nlc3Mgb25lIHVPcCIsCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgICJCcmllZkRlc2NyaXB0aW9uIjogIkEgcGlwZWxpbmUgc2xvdCByZXByZXNlbnRz IHRoZQo+PiBoYXJkd2FyZSByZXNvdXJjZXMgbmVlZGVkIHRvIHByb2Nlc3Mgb25lIHVPcCIsCj4+ ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICJNZXRyaWNOYW1lIjogInNsb3QiCj4gCj4g RWhoaC4uLi5JJ20gbm90IHN1cmUgaWYgdGhhdCBpcyBhIGdvb2QgaWRlYS4gSWFuIG9yIGFueW9u ZSBlbHNlIGhhdmUgYW4KPiBvcGluaW9uIG9uIHRoaXM/IEl0IGlzIHBvc3NpYmxlIHRvIHJldXNl IG1ldHJpY3MsIHNvIGl0IHNob3VsZCB3b3JrLCBidXQuLi4KPiAKPiBPbmUgcHJvYmxlbSBpcyB0 aGF0ICJzbG90IiB3b3VsZCBzaG93IHVwIGFzIGEgbWV0cmljLCB3aGljaCB5b3Ugd291bGQKPiBu b3Qgd2FudC4KPiAKPiBBbHRlcm5hdGl2ZWx5IEkgd2FzIGdvaW5nIHRvIHN1Z2dlc3QgdGhhdCB5 b3UgY2FuIG92ZXJ3cml0ZSBzcGVjaWZpYyBzdGQKPiBhcmNoIGV2ZW50IGF0dHJpYnV0ZXMuIFNv IGZvciBleGFtcGxlIG9mIGZyb250ZW5kX2JvdW5kLCB5b3UgY291bGQgaGF2ZToKCkkgd291bGQg YWdyZWUgd2l0aCBub3QgaGF2aW5nIHRoaXMgYW5kIGp1c3QgaGFyZCBjb2RpbmcgdGhlIDUgd2hl cmV2ZXIKaXQncyBuZWVkZWQuIE9uY2Ugd2UgaGF2ZSBhIGZldyBkaWZmZXJlbnQgc2V0cyBvZiBt ZXRyaWNzIGluIHBsYWNlIG1heWJlCndlIGNhbiBzdGFydCB0byBsb29rIGF0IGRlZHVwbGljYXRp b24sIGJ1dCBmb3Igbm93IEkgZG9uJ3Qgc2VlIHRoZSB2YWx1ZS4KCj4gCj4gKyBiL3Rvb2xzL3Bl cmYvcG11LWV2ZW50cy9hcmNoL2FybTY0L2FybS9uZW92ZXJzZS1uMi9tZXRyaWNzLmpzb24KPiBA QCAtMCwwICsxLDMwIEBACj4gWwo+IMKgwqDCoCB7Cj4gwqDCoMKgwqAiQXJjaFN0ZEV2ZW50Ijog IkZST05URU5EX0JPVU5EIiwKPiDCoMKgwqDCoMKgwqDCoCAiTWV0cmljRXhwciI6ICIoc3RhbGxf c2xvdF9mcm9udGVuZCAtIGNwdV9jeWNsZXMpIC8gKDUgKgo+IGNwdV9jeWNsZXMpIiwKPiDCoMKg wqAgfSwKPiAKPj4gK8KgwqDCoMKgwqDCoCB9Cj4+ICvCoMKgwqDCoMKgwqAgewo+PiArwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAiQXJjaFN0ZEV2ZW50IjogIkZST05URU5EX0JPVU5EIgo+ PiArwqDCoMKgwqDCoMKgIH0sCj4+ICvCoMKgwqDCoMKgwqAgewo+PiArwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCAiQXJjaFN0ZEV2ZW50IjogIkJBQ0tFTkRfQk9VTkQiCj4+ICvCoMKgwqDC oMKgwqAgfSwKPj4gK8KgwqDCoMKgwqDCoCB7Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgICJBcmNoU3RkRXZlbnQiOiAiV0FTVEVEIgo+PiArwqDCoMKgwqDCoMKgIH0sCj4+ICvCoMKg wqDCoMKgwqAgewo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAiQXJjaFN0ZEV2ZW50 IjogIlJFVElSSU5HIgo+PiArwqDCoMKgwqDCoMKgIH0sCj4+Cj4+Cj4+IDIuIFNob3VsZCBJIGFk ZCB0aGUgdG9wZG93bkwxIG1ldHJpYyB0bwo+PiB0b29scy9wZXJmL3BtdS1ldmVudC9yZWNvbW1l bmRlZC5qc29uLAo+PiBvciBjcmVhdGUgYSBuZXcganNvbiBmaWxlIHRvIHBsYWNlIHRoZSBnZW5l cmFsIG1ldHJpYz8KPiAKPiBJdCB3b3VsZCBub3QgYmVsb25nIGluIHJlY29tbWVuZGVkLmpzb24g YXMgdGhhdCBpcyBzcGVjaWZpY2FsbHkgZm9yCj4gYXJjaC1yZWNvbW1lbmRlZCBldmVudHMuIEl0 IHdvdWxkIHJlYWxseSBqdXN0IGRlcGVuZCBvbiB3aGVyZSB0aGUgdmFsdWUKPiBjb21lcyBmcm9t LCBpLmUuIGFybSBhcm0gb3Igc2JzYS4KPiAKCkZvciB3aGF0IHdlJ3JlIGdvaW5nIHRvIHB1Ymxp c2ggc2hvcnRseSB3ZSdsbCBiZSBnZW5lcmF0aW5nIGEKbWV0cmljcy5qc29uIGZpbGUgZm9yIGVh Y2ggQ1BVLiBJdCB3aWxsIGJlIGF1dG9nZW5lcmF0ZWQgc28gSSBkb24ndAp0aGluayBkdXBsaWNh dGlvbiB3aWxsIGJlIGFuIGlzc3VlIGFuZCBJJ20gZXhwZWN0aW5nIHRoYXQgdGhlcmUgd2lsbCBi ZQpkaWZmZXJlbmNlcyBpbiB0aGUgdG9wZG93biBtZXRyaWNzIGJldHdlZW4gQ1BVcyBhbnl3YXku IFNvIEkgd291bGQgYWxzbwp2b3RlIHRvIG5vdCBwdXQgaXQgaW4gcmVjb21tZW5kZWQuanNvbgoK Pj4KPj4gTG9va2luZyBmb3J3YXJkIHRvIHlvdXIgcmVwbHkuCj4gCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==