From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zimbra13.linbit.com (zimbra.linbit.com [212.69.161.123]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTPS id D3DDC1056443 for ; Tue, 10 May 2016 11:12:43 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zimbra13.linbit.com (Postfix) with ESMTP id 71B4440FBB3 for ; Tue, 10 May 2016 11:12:43 +0200 (CEST) Received: from zimbra13.linbit.com ([127.0.0.1]) by localhost (zimbra13.linbit.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 6l_vDVcnEcBg for ; Tue, 10 May 2016 11:12:43 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zimbra13.linbit.com (Postfix) with ESMTP id 4B2E240FBB4 for ; Tue, 10 May 2016 11:12:43 +0200 (CEST) Received: from zimbra13.linbit.com ([127.0.0.1]) by localhost (zimbra13.linbit.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id UsUTr3_mdd9O for ; Tue, 10 May 2016 11:12:43 +0200 (CEST) Received: from soda.linbit (tuerlsteher.linbit.com [86.59.100.100]) by zimbra13.linbit.com (Postfix) with ESMTPS id 1A19B40FBB2 for ; Tue, 10 May 2016 11:12:43 +0200 (CEST) Resent-Message-ID: <20160510091243.GB16459@soda.linbit> Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTPS id D92761056443 for ; Tue, 10 May 2016 11:09:56 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id a17so15419993wme.0 for ; Tue, 10 May 2016 02:09:56 -0700 (PDT) References: <20160503100644.GE16459@soda.linbit> <1462786820-15519-1-git-send-email-nicolas.dichtel@6wind.com> <20160509131547.GX16459@soda.linbit> To: davem@davemloft.net, netdev@vger.kernel.org, philipp.reisner@linbit.com, drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org From: Nicolas Dichtel Message-ID: <5731A561.6090509@6wind.com> Date: Tue, 10 May 2016 11:09:53 +0200 MIME-Version: 1.0 In-Reply-To: <20160509131547.GX16459@soda.linbit> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Drbd-dev] [PATCH net-next v3] block/drbd: align properly u64 in nl messages Reply-To: nicolas.dichtel@6wind.com List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Le 09/05/2016 15:15, Lars Ellenberg a =E9crit : > On Mon, May 09, 2016 at 11:40:20AM +0200, Nicolas Dichtel wrote: [snip] >> Maybe prefixing genl_magic_func.h and genl_magic_struct.h by 'drbd_' >> could be interesting so that new module won't use it. What is your >> opinion? >=20 > This was supposed to not be DRBD specific. But it might even still > need some massaging before it was truly generic. And obviously, > it does not meet the taste of genetlink folks, to say the least :( Yes, this file is not generic and netlink APIs are never defined like thi= s. These tons of macro complexifies the code too much. It's overengineering = for what purpose? Small examples: - the drbd netlink API is not exported via uapi (I wonder how apps using= this API get it) - v2 of the patch is nacked because adding a new attribute may break exi= sting apps (in networking code, a lot of new attributes are added in each ve= rsion) - it's not possible to grep to show the definition of an attribute ('git= grep -w T_bits_total' returns only 1 line) Regards, Nicolas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751759AbcEJJNG (ORCPT ); Tue, 10 May 2016 05:13:06 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:38836 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751271AbcEJJJ5 (ORCPT ); Tue, 10 May 2016 05:09:57 -0400 Reply-To: nicolas.dichtel@6wind.com Subject: Re: [PATCH net-next v3] block/drbd: align properly u64 in nl messages References: <20160503100644.GE16459@soda.linbit> <1462786820-15519-1-git-send-email-nicolas.dichtel@6wind.com> <20160509131547.GX16459@soda.linbit> To: davem@davemloft.net, netdev@vger.kernel.org, philipp.reisner@linbit.com, drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org From: Nicolas Dichtel Organization: 6WIND Message-ID: <5731A561.6090509@6wind.com> Date: Tue, 10 May 2016 11:09:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160509131547.GX16459@soda.linbit> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 09/05/2016 15:15, Lars Ellenberg a écrit : > On Mon, May 09, 2016 at 11:40:20AM +0200, Nicolas Dichtel wrote: [snip] >> Maybe prefixing genl_magic_func.h and genl_magic_struct.h by 'drbd_' >> could be interesting so that new module won't use it. What is your >> opinion? > > This was supposed to not be DRBD specific. But it might even still > need some massaging before it was truly generic. And obviously, > it does not meet the taste of genetlink folks, to say the least :( Yes, this file is not generic and netlink APIs are never defined like this. These tons of macro complexifies the code too much. It's overengineering for what purpose? Small examples: - the drbd netlink API is not exported via uapi (I wonder how apps using this API get it) - v2 of the patch is nacked because adding a new attribute may break existing apps (in networking code, a lot of new attributes are added in each version) - it's not possible to grep to show the definition of an attribute ('git grep -w T_bits_total' returns only 1 line) Regards, Nicolas From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Dichtel Subject: Re: [PATCH net-next v3] block/drbd: align properly u64 in nl messages Date: Tue, 10 May 2016 11:09:53 +0200 Message-ID: <5731A561.6090509@6wind.com> References: <20160503100644.GE16459@soda.linbit> <1462786820-15519-1-git-send-email-nicolas.dichtel@6wind.com> <20160509131547.GX16459@soda.linbit> Reply-To: nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, philipp.reisner-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org, drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Return-path: Resent-Message-ID: <20160510091243.GB16459@soda.linbit> In-Reply-To: <20160509131547.GX16459-w1SgEEioFePxa46PmUWvFg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: drbd-dev-bounces-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org Errors-To: drbd-dev-bounces-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org List-Id: netdev.vger.kernel.org Le 09/05/2016 15:15, Lars Ellenberg a =E9crit : > On Mon, May 09, 2016 at 11:40:20AM +0200, Nicolas Dichtel wrote: [snip] >> Maybe prefixing genl_magic_func.h and genl_magic_struct.h by 'drbd_' >> could be interesting so that new module won't use it. What is your >> opinion? > = > This was supposed to not be DRBD specific. But it might even still > need some massaging before it was truly generic. And obviously, > it does not meet the taste of genetlink folks, to say the least :( Yes, this file is not generic and netlink APIs are never defined like this. These tons of macro complexifies the code too much. It's overengineering for what purpose? Small examples: - the drbd netlink API is not exported via uapi (I wonder how apps using t= his API get it) - v2 of the patch is nacked because adding a new attribute may break exist= ing apps (in networking code, a lot of new attributes are added in each vers= ion) - it's not possible to grep to show the definition of an attribute ('git g= rep -w T_bits_total' returns only 1 line) Regards, Nicolas