From mboxrd@z Thu Jan  1 00:00:00 1970
From: Remy Horton <remy.horton@intel.com>
Subject: Re: [PATCH v4 2/3] bnx2x: enhance stats get
Date: Tue, 10 May 2016 11:27:01 +0100
Message-ID: <5731B775.3080302@intel.com>
References: <1462340302-25683-1-git-send-email-rasesh.mody@qlogic.com>
 <1462340302-25683-2-git-send-email-rasesh.mody@qlogic.com>
 <20160506144709.GC8880@bricha3-MOBL3>
 <BY1PR11MB015127ADE8DA87944802CFE6857E0@BY1PR11MB0151.namprd11.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 Dept-Eng DPDK Dev <Dept-EngDPDKDev@qlogic.com>,
 Harish Patil <harish.patil@qlogic.com>
To: Rasesh Mody <rasesh.mody@qlogic.com>,
 Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 2FD439AB7
 for <dev@dpdk.org>; Tue, 10 May 2016 12:27:14 +0200 (CEST)
In-Reply-To: <BY1PR11MB015127ADE8DA87944802CFE6857E0@BY1PR11MB0151.namprd11.prod.outlook.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


On 07/05/2016 01:14, Rasesh Mody wrote:
[..]
>>> Enhance the stats_get() routine to display drop counters under imissed
>>> counter.
>>> Added extended stats get support to provide additional info.
>>> Encorporated review comment to rename some of the stats.
[..]
> We shall split this patch into an enhancement and a bug fix.

Keep in mind that the xstats API is changing so that stats_get() no 
longer includes strings:

http://thread.gmane.org/gmane.comp.networking.dpdk.devel/37079
http://thread.gmane.org/gmane.comp.networking.dpdk.devel/37571

..Remy