From: Robert Yang <liezhi.yang@windriver.com>
To: Andreas Oberritter <obi@opendreambox.org>,
<openembedded-core@lists.openembedded.org>
Subject: Re: [RFC PATCH 1/8] qemu-boot.bbclass: add it for runqemu
Date: Tue, 10 May 2016 20:45:23 +0800 [thread overview]
Message-ID: <5731D7E3.2020506@windriver.com> (raw)
In-Reply-To: <5731B679.30303@opendreambox.org>
On 05/10/2016 06:22 PM, Andreas Oberritter wrote:
> Hello Robert,
>
> On 10.05.2016 10:13, Robert Yang wrote:
>> --- /dev/null
>> +++ b/meta/classes/qemu-boot.bbclass
>> @@ -0,0 +1,39 @@
>> +QEMU_NAME ?= ""
>> +QEMU_MAHINE_SUBTYPE ?= ""
>
> typo: QEMU_MACHINE_SUBTYPE (here and in some of the .inc files).
Yes, thanks, RP also pointed out this:-).
>
> Maybe you should use "??=", so "?=" may be used in the arch specific
> .inc files, in order to let a machine override it more easily.
Make sense, thanks.
// Robert
>
> Regards,
> Andreas
>
next prev parent reply other threads:[~2016-05-10 12:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 8:13 [RFC PATCH 0/8] [WIP] runqemu/runqemu-internal: refactor it Robert Yang
2016-05-10 8:13 ` [RFC PATCH 1/8] qemu-boot.bbclass: add it for runqemu Robert Yang
2016-05-10 10:22 ` Andreas Oberritter
2016-05-10 12:45 ` Robert Yang [this message]
2016-05-10 8:14 ` [RFC PATCH 2/8] qemu.inc: set QEMU_BOOT_SUPPORTED to 1 Robert Yang
2016-05-10 8:14 ` [RFC PATCH 3/8] qemuarm.conf: set vars for runqemu Robert Yang
2016-05-10 8:14 ` [RFC PATCH 4/8] arch-arm64.inc: " Robert Yang
2016-05-10 8:14 ` [RFC PATCH 5/8] arch-x86.inc: " Robert Yang
2016-05-10 8:14 ` [RFC PATCH 6/8] arch-mips.inc: " Robert Yang
2016-05-10 8:14 ` [RFC PATCH 7/8] arch-powerpc.inc: " Robert Yang
2016-05-10 8:14 ` [RFC PATCH 8/8] runqemu/runqemu-internal: refactor it Robert Yang
2016-05-19 14:57 ` [RFC PATCH 0/8] [WIP] " Nathan Rossi
2016-05-20 2:31 ` Robert Yang
2016-05-20 2:43 ` Robert Yang
2016-05-25 7:00 ` Andrew Jeffery
2016-06-23 8:17 ` Richard Purdie
2016-06-23 8:43 ` Robert Yang
2016-06-23 8:56 ` Richard Purdie
2016-06-23 9:20 ` Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5731D7E3.2020506@windriver.com \
--to=liezhi.yang@windriver.com \
--cc=obi@opendreambox.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.