From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 11/23] drm: omapdrm: Check DSS manager state in the enable/disable helpers Date: Tue, 10 May 2016 16:28:22 +0300 Message-ID: <5731E1F6.5080600@ti.com> References: <1461702945-14185-1-git-send-email-laurent.pinchart@ideasonboard.com> <1461702945-14185-12-git-send-email-laurent.pinchart@ideasonboard.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0748188665==" Return-path: Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152]) by gabe.freedesktop.org (Postfix) with ESMTPS id 385646E64E for ; Tue, 10 May 2016 13:28:28 +0000 (UTC) In-Reply-To: <1461702945-14185-12-git-send-email-laurent.pinchart@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0748188665== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ANKRrBQVS5JN2QpcXPvBOeaGvPoEsEU55" --ANKRrBQVS5JN2QpcXPvBOeaGvPoEsEU55 Content-Type: multipart/mixed; boundary="UCNqQb0970cOX6iEd5I26vrTgGDhUO2UO" From: Tomi Valkeinen To: Laurent Pinchart , dri-devel@lists.freedesktop.org Cc: Rob Clark Message-ID: <5731E1F6.5080600@ti.com> Subject: Re: [PATCH 11/23] drm: omapdrm: Check DSS manager state in the enable/disable helpers References: <1461702945-14185-1-git-send-email-laurent.pinchart@ideasonboard.com> <1461702945-14185-12-git-send-email-laurent.pinchart@ideasonboard.com> In-Reply-To: <1461702945-14185-12-git-send-email-laurent.pinchart@ideasonboard.com> --UCNqQb0970cOX6iEd5I26vrTgGDhUO2UO Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 26/04/16 23:35, Laurent Pinchart wrote: > The omapdrm DSS manager enable/disable operations check the DSS manager= > state to avoid double enabling/disabling. Move that code to the DSS > manager to decrease the dependency of the DRM layer to the DSS layer. Shouldn't omapdrm know if the CRTC is enabled or not, and avoid double-enable/disable by just looking at its internal state? If so, we could remove dispc_mgr_is_enabled() call as you do, and add a WARN_ON() to omapdss if the mgr is already enabled/disabled to catch bugs in omapdrm. Tomi --UCNqQb0970cOX6iEd5I26vrTgGDhUO2UO-- --ANKRrBQVS5JN2QpcXPvBOeaGvPoEsEU55 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXMeH2AAoJEPo9qoy8lh713GkP/2CrIMf1mFd6UtBF+ZiiiEfV BXZbvbV/oRU+l7rLt2cJmVUnzyvXYkhZu82bT+6rENLOwcoyABNi/0frF7v+TGgo P2k5zgxFO23FdySm8xAVJH7fOukUliTZJlUzZjqYR9tldvIz0O0Wm8Lji+ozLiBA n+cGnd7d89Yi+vvIsq5wZpWvt87R2297IBJhPmlOSo8ZRrb3ERXl/S9r+fZrT4Po w+3y0t6cA9gza6fK+nQtmPB8gcI4NML6T0M2yv82WD2tIsDT3cUDhNEtaYCGYxKT FkgADGxbmjNGpkZceXrn1XNLXhG2nWB3S9qxVLEBrK5J+1a7jtc2Ts7DrFSNTctE vQRi1zD1qcjeEq1pk5QatTht/oBGMWjaragvzXYAC/tgLE+0OfQnZDRlAog51Sq/ 9kn6N+uIGA6lR9Kjzq+BCYF3FtDUXxvVVsQAZ5clhKYoOYkThtM20nrF6kWLcGJI KYD1m+wedC6EHPHIk/OmIOy1bhuC4YNJjYWyULXBuPkeOCEcDXuDeK0CBKYZUsiF or6qqudDcghjeR0GWM/ZavoE0xk33Xab1pJswfPZIbkDWuurKUdhXqCAayGUoELZ Zjt6VNMWQ6yO87+uWVxOHrkvhX+zIhx0oq9sFV8VeQsx6WZUMa8a0WcmJiWjLQ82 UOPOlj5OisC0RQRBkRSe =B5HC -----END PGP SIGNATURE----- --ANKRrBQVS5JN2QpcXPvBOeaGvPoEsEU55-- --===============0748188665== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0748188665==--