From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v3 3/6] drm/i915/guc: pass request (not client) to i915_guc_{wq_check_space, submit}() Date: Tue, 10 May 2016 15:46:44 +0100 Message-ID: <5731F454.5010802@linux.intel.com> References: <1462563095-13233-1-git-send-email-david.s.gordon@intel.com> <1462563095-13233-3-git-send-email-david.s.gordon@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id D4FC06E67A for ; Tue, 10 May 2016 14:47:14 +0000 (UTC) In-Reply-To: <1462563095-13233-3-git-send-email-david.s.gordon@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA2LzA1LzE2IDIwOjMxLCBEYXZlIEdvcmRvbiB3cm90ZToKPiBUaGUga25vd2xlZGdlIG9m IGhvdyB0byBkZXJpdmUgdGhlIHJlbGV2YW50IGNsaWVudCBmcm9tIHRoZSByZXF1ZXN0Cj4gc2hv dWxkIGJlIGxvY2FsaXNlZCB3aXRoaW4gaTkxNV9ndWNfc3VibWlzc2lvbi5jOyB0aGUgTFJDIGNv ZGUgc2hvdWxkbid0Cj4gaGF2ZSB0byBrbm93IGFib3V0IHRoZSBpbnRlcm5hbCBkZXRhaWxzIG9m IHRoZSBHdUMgc3VibWlzc2lvbiBwcm9jZXNzLgo+IEFuZCBhbGwgdGhlIGluZm9ybWF0aW9uIHRo ZSBHdUMgY29kZSBuZWVkcyBzaG91bGQgYmUgZW5jYXBzdWxhdGVkIGluIChvcgo+IHJlYWNoYWJs ZSBmcm9tKSB0aGUgcmVxdWVzdC4KPgo+IHYzOgo+ICAgICAgR0VNX0JVR19PTigpIGZvciBiYWQg R3VDIGNsaWVudCAoVHZydGtvIFVyc3VsaW4pLgo+ICAgICAgQWRkL3VwZGF0ZSBrZXJuZWxkb2Mg ZXhwbGFpbmluZyBjaGVja19zcGFjZS9zdWJtaXQgcHJvdG9jb2wKPgo+IFNpZ25lZC1vZmYtYnk6 IERhdmUgR29yZG9uIDxkYXZpZC5zLmdvcmRvbkBpbnRlbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMgfCA0NiArKysrKysrKysrKysrKysr KysrKysrKystLS0tLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oICAgICAg ICAgICB8ICA1ICsrLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jICAgICAg ICAgICB8ICA5ICsrLS0tLQo+ICAgMyBmaWxlcyBjaGFuZ2VkLCA0MiBpbnNlcnRpb25zKCspLCAx OCBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2d1Y19zdWJtaXNzaW9uLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNz aW9uLmMKPiBpbmRleCBlNmFmNjcyLi45ZTMwNzYyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+IEBAIC00NTEsMTQgKzQ1MSwzMCBAQCBzdGF0aWMg dm9pZCBndWNfZmluaV9jdHhfZGVzYyhzdHJ1Y3QgaW50ZWxfZ3VjICpndWMsCj4gICAJCQkgICAg IHNpemVvZihkZXNjKSAqIGNsaWVudC0+Y3R4X2luZGV4KTsKPiAgIH0KPgo+IC1pbnQgaTkxNV9n dWNfd3FfY2hlY2tfc3BhY2Uoc3RydWN0IGk5MTVfZ3VjX2NsaWVudCAqZ2MpCj4gKy8qKgo+ICsg KiBpOTE1X2d1Y193cV9jaGVja19zcGFjZSgpIC0gY2hlY2sgdGhhdCB0aGUgR3VDIGNhbiBhY2Nl cHQgYSByZXF1ZXN0Cj4gKyAqIEByZXF1ZXN0OglyZXF1ZXN0IGFzc29jaWF0ZWQgd2l0aCB0aGUg Y29tbWFuZHMKPiArICoKPiArICogUmV0dXJuOgkwIGlmIHNwYWNlIGlzIGF2YWlsYWJsZQo+ICsg KgkJLUVBR0FJTiBpZiBzcGFjZSBpcyBub3QgY3VycmVudGx5IGF2YWlsYWJsZQo+ICsgKgo+ICsg KiBUaGlzIGZ1bmN0aW9uIG11c3QgYmUgY2FsbGVkIChhbmQgbXVzdCByZXR1cm4gMCkgYmVmb3Jl IGEgcmVxdWVzdAo+ICsgKiBpcyBzdWJtaXR0ZWQgdG8gdGhlIEd1QyB2aWEgaTkxNV9ndWNfc3Vi bWl0KCkgYmVsb3cuIE9uY2UgYSByZXN1bHQKPiArICogb2YgMCBoYXMgYmVlbiByZXR1cm5lZCwg aXQgcmVtYWlucyB2YWxpZCB1bnRpbCAoYnV0IG9ubHkgdW50aWwpCj4gKyAqIHRoZSBuZXh0IGNh bGwgdG8gc3VibWl0KCkuCj4gKyAqCj4gKyAqIFRoaXMgcHJlY2hlY2sgYWxsb3dzIHRoZSBjYWxs ZXIgdG8gZGV0ZXJtaW5lIGluIGFkdmFuY2UgdGhhdCBzcGFjZQo+ICsgKiB3aWxsIGJlIGF2YWls YWJsZSBmb3IgdGhlIG5leHQgc3VibWlzc2lvbiBiZWZvcmUgY29tbWl0dGluZyByZXNvdXJjZXMK PiArICogdG8gaXQsIGFuZCBoZWxwcyBhdm9pZCBsYXRlIGZhaWx1cmVzIHdpdGggY29tcGxpY2F0 ZWQgcmVjb3ZlcnkgcGF0aHMuCj4gKyAqLwo+ICtpbnQgaTkxNV9ndWNfd3FfY2hlY2tfc3BhY2Uo c3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0KQo+ICAgewo+ICsJY29uc3Qgc2l6 ZV90IHNpemUgPSBzaXplb2Yoc3RydWN0IGd1Y193cV9pdGVtKTsKPiArCXN0cnVjdCBpOTE1X2d1 Y19jbGllbnQgKmdjID0gcmVxdWVzdC0+aTkxNS0+Z3VjLmV4ZWNidWZfY2xpZW50Owo+ICAgCXN0 cnVjdCBndWNfcHJvY2Vzc19kZXNjICpkZXNjOwo+IC0JdTMyIHNpemUgPSBzaXplb2Yoc3RydWN0 IGd1Y193cV9pdGVtKTsKPiAgIAlpbnQgcmV0ID0gLUVUSU1FRE9VVCwgdGltZW91dF9jb3VudGVy ID0gMjAwOwo+Cj4gLQlpZiAoIWdjKQo+IC0JCXJldHVybiAwOwo+ICsJR0VNX0JVR19PTihnYyA9 PSBOVUxMKTsKPgo+ICAgCWRlc2MgPSBnYy0+Y2xpZW50X2Jhc2UgKyBnYy0+cHJvY19kZXNjX29m ZnNldDsKPgo+IEBAIC01MzIsMTYgKzU0OCwyOCBAQCBzdGF0aWMgaW50IGd1Y19hZGRfd29ya3F1 ZXVlX2l0ZW0oc3RydWN0IGk5MTVfZ3VjX2NsaWVudCAqZ2MsCj4KPiAgIC8qKgo+ICAgICogaTkx NV9ndWNfc3VibWl0KCkgLSBTdWJtaXQgY29tbWFuZHMgdGhyb3VnaCBHdUMKPiAtICogQGNsaWVu dDoJdGhlIGd1YyBjbGllbnQgd2hlcmUgY29tbWFuZHMgd2lsbCBnbyB0aHJvdWdoCj4gICAgKiBA cnE6CQlyZXF1ZXN0IGFzc29jaWF0ZWQgd2l0aCB0aGUgY29tbWFuZHMKPiAgICAqCj4gLSAqIFJl dHVybjoJMCBpZiBzdWNjZWVkCj4gKyAqIFJldHVybjoJMCBvbiBzdWNjZXNzLCBvdGhlcndpc2Ug YW4gZXJybm8uCj4gKyAqIAkJKE5vdGU6IG5vbnplcm8gcmVhbGx5IHNob3VsZG4ndCBoYXBwZW4h KQo+ICsgKgo+ICsgKiBUaGUgY2FsbGVyIG11c3QgaGF2ZSBhbHJlYWR5IGNhbGxlZCBpOTE1X2d1 Y193cV9jaGVja19zcGFjZSgpIGFib3ZlCj4gKyAqIHdpdGggYSByZXN1bHQgb2YgMCAoc3VjY2Vz cykgc2luY2UgdGhlIGxhc3QgcmVxdWVzdCBzdWJtaXNzaW9uLiBUaGlzCj4gKyAqIGd1YXJhbnRl ZXMgdGhhdCB0aGVyZSBpcyBzcGFjZSBpbiB0aGUgd29yayBxdWV1ZSBmb3IgdGhlIG5ldyByZXF1 ZXN0LAo+ICsgKiBzbyBlbnF1ZXVpbmcgdGhlIGl0ZW0gY2Fubm90IGZhaWwuCj4gKyAqCj4gKyAq IEJhZCBUaGluZ3MgV2lsbCBIYXBwZW4gaWYgdGhlIGNhbGxlciB2aW9sYXRlcyB0aGlzIHByb3Rv Y29sIGUuZy4gY2FsbHMKPiArICogc3VibWl0KCkgd2hlbiBjaGVjaygpIHNheXMgdGhlcmUncyBu byBzcGFjZSwgb3IgY2FsbHMgc3VibWl0KCkgbXVsdGlwbGUKPiArICogdGltZXMgd2l0aCBubyBp bnRlcnZlbmluZyBjaGVjaygpLgo+ICsgKgo+ICsgKiBUaGUgb25seSBlcnJvciBoZXJlIGFyaXNl cyBpZiB0aGUgZG9vcmJlbGwgaGFyZHdhcmUgaXNuJ3QgZnVuY3Rpb25pbmcKPiArICogYXMgZXhw ZWN0ZWQsIHdoaWNoIHJlYWxseSBzaG91bG4ndCBoYXBwZW4uCj4gICAgKi8KPiAtaW50IGk5MTVf Z3VjX3N1Ym1pdChzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50ICpjbGllbnQsCj4gLQkJICAgIHN0cnVj dCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcnEpCj4gK2ludCBpOTE1X2d1Y19zdWJtaXQoc3RydWN0 IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpycSkKPiAgIHsKPiAtCXN0cnVjdCBpbnRlbF9ndWMgKmd1 YyA9IGNsaWVudC0+Z3VjOwo+ICAgCXVuc2lnbmVkIGludCBlbmdpbmVfaWQgPSBycS0+ZW5naW5l LT5ndWNfaWQ7Cj4gKwlzdHJ1Y3QgaW50ZWxfZ3VjICpndWMgPSAmcnEtPmk5MTUtPmd1YzsKPiAr CXN0cnVjdCBpOTE1X2d1Y19jbGllbnQgKmNsaWVudCA9IGd1Yy0+ZXhlY2J1Zl9jbGllbnQ7Cj4g ICAJaW50IHFfcmV0LCBiX3JldDsKPgo+ICAgCXFfcmV0ID0gZ3VjX2FkZF93b3JrcXVldWVfaXRl bShjbGllbnQsIHJxKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf Z3VjLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuaAo+IGluZGV4IDlkNzljNGMu LmIzN2M3MzEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmgK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuaAo+IEBAIC0xNDgsMTAgKzE0 OCw5IEBAIGV4dGVybiBpbnQgaW50ZWxfZ3VjX3Jlc3VtZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 KTsKPiAgIC8qIGk5MTVfZ3VjX3N1Ym1pc3Npb24uYyAqLwo+ICAgaW50IGk5MTVfZ3VjX3N1Ym1p c3Npb25faW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKPiAgIGludCBpOTE1X2d1Y19zdWJt aXNzaW9uX2VuYWJsZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKPiAtaW50IGk5MTVfZ3VjX3N1 Ym1pdChzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50ICpjbGllbnQsCj4gLQkJICAgIHN0cnVjdCBkcm1f aTkxNV9nZW1fcmVxdWVzdCAqcnEpOwo+ICtpbnQgaTkxNV9ndWNfd3FfY2hlY2tfc3BhY2Uoc3Ry dWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpycSk7Cj4gK2ludCBpOTE1X2d1Y19zdWJtaXQoc3Ry dWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpycSk7Cj4gICB2b2lkIGk5MTVfZ3VjX3N1Ym1pc3Np b25fZGlzYWJsZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKPiAgIHZvaWQgaTkxNV9ndWNfc3Vi bWlzc2lvbl9maW5pKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+IC1pbnQgaTkxNV9ndWNfd3Ff Y2hlY2tfc3BhY2Uoc3RydWN0IGk5MTVfZ3VjX2NsaWVudCAqY2xpZW50KTsKPgo+ICAgI2VuZGlm Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiBpbmRleCBkODc2MzUyLi43OTMwMmUxIDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiBAQCAtNjk4LDkgKzY5OCw3IEBAIGludCBpbnRl bF9sb2dpY2FsX3JpbmdfYWxsb2NfcmVxdWVzdF9leHRyYXMoc3RydWN0IGRybV9pOTE1X2dlbV9y ZXF1ZXN0ICpyZXF1ZXN0Cj4gICAJCSAqIGdvaW5nIGFueSBmdXJ0aGVyLCBhcyB0aGUgaTkxNV9h ZGRfcmVxdWVzdCgpIGNhbGwKPiAgIAkJICogbGF0ZXIgb24gbXVzdG4ndCBmYWlsIC4uLgo+ICAg CQkgKi8KPiAtCQlzdHJ1Y3QgaW50ZWxfZ3VjICpndWMgPSAmcmVxdWVzdC0+aTkxNS0+Z3VjOwo+ IC0KPiAtCQlyZXQgPSBpOTE1X2d1Y193cV9jaGVja19zcGFjZShndWMtPmV4ZWNidWZfY2xpZW50 KTsKPiArCQlyZXQgPSBpOTE1X2d1Y193cV9jaGVja19zcGFjZShyZXF1ZXN0KTsKPiAgIAkJaWYg KHJldCkKPiAgIAkJCXJldHVybiByZXQ7Cj4gICAJfQo+IEBAIC03NDksNyArNzQ3LDYgQEAgaW50 IGludGVsX2xvZ2ljYWxfcmluZ19hbGxvY19yZXF1ZXN0X2V4dHJhcyhzdHJ1Y3QgZHJtX2k5MTVf Z2VtX3JlcXVlc3QgKnJlcXVlc3QKPiAgIGludGVsX2xvZ2ljYWxfcmluZ19hZHZhbmNlX2FuZF9z dWJtaXQoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0KQo+ICAgewo+ICAgCXN0 cnVjdCBpbnRlbF9yaW5nYnVmZmVyICpyaW5nYnVmID0gcmVxdWVzdC0+cmluZ2J1ZjsKPiAtCXN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHJlcXVlc3QtPmk5MTU7Cj4gICAJc3Ry dWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lID0gcmVxdWVzdC0+ZW5naW5lOwo+Cj4gICAJaW50 ZWxfbG9naWNhbF9yaW5nX2FkdmFuY2UocmluZ2J1Zik7Cj4gQEAgLTc3Nyw4ICs3NzQsOCBAQCBp bnQgaW50ZWxfbG9naWNhbF9yaW5nX2FsbG9jX3JlcXVlc3RfZXh0cmFzKHN0cnVjdCBkcm1faTkx NV9nZW1fcmVxdWVzdCAqcmVxdWVzdAo+ICAgCXJlcXVlc3QtPnByZXZpb3VzX2NvbnRleHQgPSBl bmdpbmUtPmxhc3RfY29udGV4dDsKPiAgIAllbmdpbmUtPmxhc3RfY29udGV4dCA9IHJlcXVlc3Qt PmN0eDsKPgo+IC0JaWYgKGRldl9wcml2LT5ndWMuZXhlY2J1Zl9jbGllbnQpCj4gLQkJaTkxNV9n dWNfc3VibWl0KGRldl9wcml2LT5ndWMuZXhlY2J1Zl9jbGllbnQsIHJlcXVlc3QpOwo+ICsJaWYg KGk5MTUuZW5hYmxlX2d1Y19zdWJtaXNzaW9uKQo+ICsJCWk5MTVfZ3VjX3N1Ym1pdChyZXF1ZXN0 KTsKPiAgIAllbHNlCj4gICAJCWV4ZWNsaXN0c19jb250ZXh0X3F1ZXVlKHJlcXVlc3QpOwo+Cj4K ClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgoK UmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl bC1nZngK