From: Jorge Ramirez <jorge.ramirez-ortiz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Boris Brezillon
<boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
daniel.thompson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
erin.lo-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org
Subject: Re: [PATCH v4 2/2] mtd: mediatek: driver for MTK Smart Device Gen1 NAND
Date: Tue, 10 May 2016 10:53:43 -0400 [thread overview]
Message-ID: <5731F5F7.6000204@linaro.org> (raw)
In-Reply-To: <20160510141335.442d3d7b@bbrezillon>
On 05/10/2016 08:13 AM, Boris Brezillon wrote:
>> +
>> >+void mtk_ecc_hw_init(struct mtk_ecc *ecc)
> No need to expose this function. Make it static and remove the
> prototype in your header.
>
yes, it was a leftover.
WARNING: multiple messages have this Message-ID (diff)
From: Jorge Ramirez <jorge.ramirez-ortiz@linaro.org>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: computersforpeace@gmail.com, dwmw2@infradead.org,
matthias.bgg@gmail.com, robh@kernel.org,
linux-mtd@lists.infradead.org, xiaolei.li@mediatek.com,
linux-mediatek@lists.infradead.org, erin.lo@mediatek.com,
daniel.thompson@linaro.org, blogic@openwrt.org
Subject: Re: [PATCH v4 2/2] mtd: mediatek: driver for MTK Smart Device Gen1 NAND
Date: Tue, 10 May 2016 10:53:43 -0400 [thread overview]
Message-ID: <5731F5F7.6000204@linaro.org> (raw)
In-Reply-To: <20160510141335.442d3d7b@bbrezillon>
On 05/10/2016 08:13 AM, Boris Brezillon wrote:
>> +
>> >+void mtk_ecc_hw_init(struct mtk_ecc *ecc)
> No need to expose this function. Make it static and remove the
> prototype in your header.
>
yes, it was a leftover.
next prev parent reply other threads:[~2016-05-10 14:53 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 16:17 [PATCH v4 0/2] MTK Smart Device Gen1 NAND Driver Jorge Ramirez-Ortiz
2016-04-29 16:17 ` Jorge Ramirez-Ortiz
[not found] ` <1461946642-1842-1-git-send-email-jorge.ramirez-ortiz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-29 16:17 ` [PATCH v4 1/2] mtd: mediatek: device tree docs for MTK Smart Device Gen1 NAND Jorge Ramirez-Ortiz
2016-04-29 16:17 ` Jorge Ramirez-Ortiz
[not found] ` <1461946642-1842-2-git-send-email-jorge.ramirez-ortiz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-05-06 13:38 ` Boris Brezillon
2016-05-06 13:38 ` Boris Brezillon
2016-05-10 11:57 ` Jorge Ramirez
2016-05-10 11:57 ` Jorge Ramirez
[not found] ` <5731CCA5.5070603-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-05-10 12:22 ` Boris Brezillon
2016-05-10 12:22 ` Boris Brezillon
2016-04-29 16:17 ` [PATCH v4 2/2] mtd: mediatek: driver " Jorge Ramirez-Ortiz
2016-04-29 16:17 ` Jorge Ramirez-Ortiz
[not found] ` <1461946642-1842-3-git-send-email-jorge.ramirez-ortiz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-05-01 7:32 ` John Crispin
2016-05-01 7:32 ` John Crispin
[not found] ` <1462165406.8414.196.camel@mhfsdcap03>
2016-05-02 6:13 ` John Crispin
2016-05-02 6:13 ` John Crispin
[not found] ` <676c2485-e176-4182-2400-201074b36ca3-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2016-05-02 11:38 ` Jorge Ramirez
2016-05-02 11:38 ` Jorge Ramirez
[not found] ` <57273C40.6000407-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-05-02 17:43 ` John Crispin
2016-05-02 17:43 ` John Crispin
2016-05-10 12:13 ` Boris Brezillon
2016-05-10 12:13 ` Boris Brezillon
2016-05-10 14:37 ` Jorge Ramirez
2016-05-10 14:37 ` Jorge Ramirez
[not found] ` <5731F22C.902-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-05-10 14:55 ` Boris Brezillon
2016-05-10 14:55 ` Boris Brezillon
2016-05-10 14:45 ` Jorge Ramirez
2016-05-10 14:45 ` Jorge Ramirez
[not found] ` <5731F40B.801-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-05-10 14:59 ` Boris Brezillon
2016-05-10 14:59 ` Boris Brezillon
2016-05-10 15:18 ` Jorge Ramirez
2016-05-10 15:18 ` Jorge Ramirez
2016-05-10 14:50 ` Jorge Ramirez
2016-05-10 14:50 ` Jorge Ramirez
[not found] ` <5731F537.9040009-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-05-10 15:13 ` Boris Brezillon
2016-05-10 15:13 ` Boris Brezillon
2016-05-10 15:37 ` Jorge Ramirez
2016-05-10 15:37 ` Jorge Ramirez
2016-05-10 14:53 ` Jorge Ramirez
2016-05-10 14:53 ` Jorge Ramirez
[not found] ` <5731F5E3.3020607-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-05-10 18:14 ` Jorge Ramirez
2016-05-10 18:14 ` Jorge Ramirez
[not found] ` <573224F5.4030003-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-05-10 18:19 ` Boris Brezillon
2016-05-10 18:19 ` Boris Brezillon
2016-05-10 14:53 ` Jorge Ramirez [this message]
2016-05-10 14:53 ` Jorge Ramirez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5731F5F7.6000204@linaro.org \
--to=jorge.ramirez-ortiz-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org \
--cc=boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=daniel.thompson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=erin.lo-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.