From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Foss Subject: Re: [PATCH v2] drm/vc4: Return -EBUSY if there's already a pending flip event. Date: Tue, 10 May 2016 11:35:04 -0400 Message-ID: <5731FFA8.8040304@collabora.com> References: <1462297700-17491-1-git-send-email-robert.foss@collabora.com> <8737pzlzfr.fsf@eliezer.anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id E57506E686 for ; Tue, 10 May 2016 15:35:10 +0000 (UTC) In-Reply-To: <8737pzlzfr.fsf@eliezer.anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt , daniel.vetter@ffwll.ch, airlied@linux.ieaniel.vetter@ffwll.ch, fengguang.wu@intel.com, maarten.lankhorst@linux.intel.com, julia.lawall@lip6.fr, alexander.deucher@amd.com, daniels@collabora.com, derekf@osg.samsung.com, varadgautam@gmail.com Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org CgpPbiAyMDE2LTA1LTAzIDAzOjIyIFBNLCBFcmljIEFuaG9sdCB3cm90ZToKPiByb2JlcnQuZm9z c0Bjb2xsYWJvcmEuY29tIHdyaXRlczoKPgo+PiBGcm9tOiBSb2JlcnQgRm9zcyA8cm9iZXJ0LmZv c3NAY29sbGFib3JhLmNvbT4KPj4KPj4gQXMgcGVyIHRoZSBkb2N1bWVudGF0aW9uIGluIGRybV9j cnRjLmgsIGF0b21pY19jb21taXQgc2hvdWxkIHJldHVybgo+PiAtRUJVU1kgaWYgYW4gYXN5Y25o cm9ub3VzIHVwZGF0ZSBpcyByZXF1ZXN0ZWQgYW5kIHRoZXJlIGlzIGFuIGVhcmxpZXIKPj4gdXBk YXRlIHBlbmRpbmcuCj4+Cj4+IE5vdGU6IGRvY3MgY2l0ZWQgaGVyZSBhcmUgZHJtX2NydGMuaCwg YW5kIHRoZSB3aG9sZSBxdW90ZSBpczoKPj4KPj4gICAgICAqICAtIC1FQlVTWSwgaWYgYW4gYXN5 bmNocm9ub3VzIHVwZGF0ZWQgaXMgcmVxdWVzdGVkIGFuZCB0aGVyZSBpcwo+PiAgICAgICogICAg YW4gZWFybGllciB1cGRhdGVkIHBlbmRpbmcuIERyaXZlcnMgYXJlIGFsbG93ZWQgdG8gc3VwcG9y dCBhIHF1ZXVlCj4+ICAgICAgKiAgICBvZiBvdXRzdGFuZGluZyB1cGRhdGVzLCBidXQgY3VycmVu dGx5IG5vIGRyaXZlciBzdXBwb3J0cyB0aGF0Lgo+PiAgICAgICogICAgTm90ZSB0aGF0IGRyaXZl cnMgbXVzdCB3YWl0IGZvciBwcmVjZWRpbmcgdXBkYXRlcyB0byBjb21wbGV0ZSBpZiBhCj4+ICAg ICAgKiAgICBzeW5jaHJvbm91cyB1cGRhdGUgaXMgcmVxdWVzdGVkLCB0aGV5IGFyZSBub3QgYWxs b3dlZCB0byBmYWlsIHRoZQo+PiAgICAgICogICAgY29tbWl0IGluIHRoYXQgY2FzZS4KPj4KPj4g U2lnbmVkLW9mZi1ieTogUm9iZXJ0IEZvc3MgPHJvYmVydC5mb3NzQGNvbGxhYm9yYS5jb20+Cj4K PiBUaGlzIGxvb2tzIGdvb2QgdG8gbWUuICBMZXQncyBnaXZlIGl0IGEgZmV3IGRheXMgb24gdGhl IGxpc3QgZm9yIGFueQo+IG90aGVyIEtNUyBmb2xrcyB0byBjYXRjaCBhbnl0aGluZy4KPgoKSSBo YXZlbid0IHNlZW4gYW55IGZ1cnRoZXIgZmVlZGJhY2sgcmVnYXJkaW5nIHRoaXMgcGF0Y2guCkRv ZXMgYW55b25lIGhhdmUgb2JqZWN0aW9ucyB0byBpdCBiZWluZyBtZXJnZWQ/Cl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752306AbcEJPfN (ORCPT ); Tue, 10 May 2016 11:35:13 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:53773 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751054AbcEJPfL (ORCPT ); Tue, 10 May 2016 11:35:11 -0400 Subject: Re: [PATCH v2] drm/vc4: Return -EBUSY if there's already a pending flip event. To: Eric Anholt , daniel.vetter@ffwll.ch, airlied@linux.ie, aniel.vetter@ffwll.ch, fengguang.wu@intel.com, maarten.lankhorst@linux.intel.com, julia.lawall@lip6.fr, alexander.deucher@amd.com, daniels@collabora.com, derekf@osg.samsung.com, varadgautam@gmail.com References: <1462297700-17491-1-git-send-email-robert.foss@collabora.com> <8737pzlzfr.fsf@eliezer.anholt.net> Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org From: Robert Foss Message-ID: <5731FFA8.8040304@collabora.com> Date: Tue, 10 May 2016 11:35:04 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <8737pzlzfr.fsf@eliezer.anholt.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-05-03 03:22 PM, Eric Anholt wrote: > robert.foss@collabora.com writes: > >> From: Robert Foss >> >> As per the documentation in drm_crtc.h, atomic_commit should return >> -EBUSY if an asycnhronous update is requested and there is an earlier >> update pending. >> >> Note: docs cited here are drm_crtc.h, and the whole quote is: >> >> * - -EBUSY, if an asynchronous updated is requested and there is >> * an earlier updated pending. Drivers are allowed to support a queue >> * of outstanding updates, but currently no driver supports that. >> * Note that drivers must wait for preceding updates to complete if a >> * synchronous update is requested, they are not allowed to fail the >> * commit in that case. >> >> Signed-off-by: Robert Foss > > This looks good to me. Let's give it a few days on the list for any > other KMS folks to catch anything. > I haven't seen any further feedback regarding this patch. Does anyone have objections to it being merged?