From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Foss Subject: Re: [PATCH v2] drm/vc4: Return -EBUSY if there's already a pending flip event. Date: Tue, 10 May 2016 13:19:42 -0400 Message-ID: <5732182E.6090100@collabora.com> References: <1462297700-17491-1-git-send-email-robert.foss@collabora.com> <8737pzlzfr.fsf@eliezer.anholt.net> <5731FFA8.8040304@collabora.com> <87eg99yha2.fsf@eliezer.anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5A5BD6E6AC for ; Tue, 10 May 2016 17:19:48 +0000 (UTC) In-Reply-To: <87eg99yha2.fsf@eliezer.anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt , daniel.vetter@ffwll.ch, airlied@linux.ieaniel.vetter@ffwll.ch, fengguang.wu@intel.com, maarten.lankhorst@linux.intel.com, julia.lawall@lip6.fr, alexander.deucher@amd.com, daniels@collabora.com, derekf@osg.samsung.com, varadgautam@gmail.com Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org VGhhbmtzIEVyaWMhCgpPbiAyMDE2LTA1LTEwIDAxOjA2IFBNLCBFcmljIEFuaG9sdCB3cm90ZToK PiBSb2JlcnQgRm9zcyA8cm9iZXJ0LmZvc3NAY29sbGFib3JhLmNvbT4gd3JpdGVzOgo+Cj4+IE9u IDIwMTYtMDUtMDMgMDM6MjIgUE0sIEVyaWMgQW5ob2x0IHdyb3RlOgo+Pj4gcm9iZXJ0LmZvc3NA Y29sbGFib3JhLmNvbSB3cml0ZXM6Cj4+Pgo+Pj4+IEZyb206IFJvYmVydCBGb3NzIDxyb2JlcnQu Zm9zc0Bjb2xsYWJvcmEuY29tPgo+Pj4+Cj4+Pj4gQXMgcGVyIHRoZSBkb2N1bWVudGF0aW9uIGlu IGRybV9jcnRjLmgsIGF0b21pY19jb21taXQgc2hvdWxkIHJldHVybgo+Pj4+IC1FQlVTWSBpZiBh biBhc3ljbmhyb25vdXMgdXBkYXRlIGlzIHJlcXVlc3RlZCBhbmQgdGhlcmUgaXMgYW4gZWFybGll cgo+Pj4+IHVwZGF0ZSBwZW5kaW5nLgo+Pj4+Cj4+Pj4gTm90ZTogZG9jcyBjaXRlZCBoZXJlIGFy ZSBkcm1fY3J0Yy5oLCBhbmQgdGhlIHdob2xlIHF1b3RlIGlzOgo+Pj4+Cj4+Pj4gICAgICAgKiAg LSAtRUJVU1ksIGlmIGFuIGFzeW5jaHJvbm91cyB1cGRhdGVkIGlzIHJlcXVlc3RlZCBhbmQgdGhl cmUgaXMKPj4+PiAgICAgICAqICAgIGFuIGVhcmxpZXIgdXBkYXRlZCBwZW5kaW5nLiBEcml2ZXJz IGFyZSBhbGxvd2VkIHRvIHN1cHBvcnQgYSBxdWV1ZQo+Pj4+ICAgICAgICogICAgb2Ygb3V0c3Rh bmRpbmcgdXBkYXRlcywgYnV0IGN1cnJlbnRseSBubyBkcml2ZXIgc3VwcG9ydHMgdGhhdC4KPj4+ PiAgICAgICAqICAgIE5vdGUgdGhhdCBkcml2ZXJzIG11c3Qgd2FpdCBmb3IgcHJlY2VkaW5nIHVw ZGF0ZXMgdG8gY29tcGxldGUgaWYgYQo+Pj4+ICAgICAgICogICAgc3luY2hyb25vdXMgdXBkYXRl IGlzIHJlcXVlc3RlZCwgdGhleSBhcmUgbm90IGFsbG93ZWQgdG8gZmFpbCB0aGUKPj4+PiAgICAg ICAqICAgIGNvbW1pdCBpbiB0aGF0IGNhc2UuCj4+Pj4KPj4+PiBTaWduZWQtb2ZmLWJ5OiBSb2Jl cnQgRm9zcyA8cm9iZXJ0LmZvc3NAY29sbGFib3JhLmNvbT4KPj4+Cj4+PiBUaGlzIGxvb2tzIGdv b2QgdG8gbWUuICBMZXQncyBnaXZlIGl0IGEgZmV3IGRheXMgb24gdGhlIGxpc3QgZm9yIGFueQo+ Pj4gb3RoZXIgS01TIGZvbGtzIHRvIGNhdGNoIGFueXRoaW5nLgo+Pj4KPj4KPj4gSSBoYXZlbid0 IHNlZW4gYW55IGZ1cnRoZXIgZmVlZGJhY2sgcmVnYXJkaW5nIHRoaXMgcGF0Y2guCj4+IERvZXMg YW55b25lIGhhdmUgb2JqZWN0aW9ucyB0byBpdCBiZWluZyBtZXJnZWQ/Cj4KPiBJIG1lcmdlZCBp dCB0byBkcm0tdmM0LW5leHQgbGFzdCBuaWdodCwgYWN0dWFsbHkgOikKPgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751795AbcEJRTu (ORCPT ); Tue, 10 May 2016 13:19:50 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:53941 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751739AbcEJRTs (ORCPT ); Tue, 10 May 2016 13:19:48 -0400 Subject: Re: [PATCH v2] drm/vc4: Return -EBUSY if there's already a pending flip event. To: Eric Anholt , daniel.vetter@ffwll.ch, airlied@linux.ie, aniel.vetter@ffwll.ch, fengguang.wu@intel.com, maarten.lankhorst@linux.intel.com, julia.lawall@lip6.fr, alexander.deucher@amd.com, daniels@collabora.com, derekf@osg.samsung.com, varadgautam@gmail.com References: <1462297700-17491-1-git-send-email-robert.foss@collabora.com> <8737pzlzfr.fsf@eliezer.anholt.net> <5731FFA8.8040304@collabora.com> <87eg99yha2.fsf@eliezer.anholt.net> Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org From: Robert Foss Message-ID: <5732182E.6090100@collabora.com> Date: Tue, 10 May 2016 13:19:42 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <87eg99yha2.fsf@eliezer.anholt.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks Eric! On 2016-05-10 01:06 PM, Eric Anholt wrote: > Robert Foss writes: > >> On 2016-05-03 03:22 PM, Eric Anholt wrote: >>> robert.foss@collabora.com writes: >>> >>>> From: Robert Foss >>>> >>>> As per the documentation in drm_crtc.h, atomic_commit should return >>>> -EBUSY if an asycnhronous update is requested and there is an earlier >>>> update pending. >>>> >>>> Note: docs cited here are drm_crtc.h, and the whole quote is: >>>> >>>> * - -EBUSY, if an asynchronous updated is requested and there is >>>> * an earlier updated pending. Drivers are allowed to support a queue >>>> * of outstanding updates, but currently no driver supports that. >>>> * Note that drivers must wait for preceding updates to complete if a >>>> * synchronous update is requested, they are not allowed to fail the >>>> * commit in that case. >>>> >>>> Signed-off-by: Robert Foss >>> >>> This looks good to me. Let's give it a few days on the list for any >>> other KMS folks to catch anything. >>> >> >> I haven't seen any further feedback regarding this patch. >> Does anyone have objections to it being merged? > > I merged it to drm-vc4-next last night, actually :) >