From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56471)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1b0D5s-0007OB-AJ
	for qemu-devel@nongnu.org; Tue, 10 May 2016 15:13:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1b0D5n-00066U-O9
	for qemu-devel@nongnu.org; Tue, 10 May 2016 15:13:19 -0400
Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:34883)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1b0D5n-00066G-BP
	for qemu-devel@nongnu.org; Tue, 10 May 2016 15:13:15 -0400
Received: by mail-lf0-x244.google.com with SMTP id u64so2404842lff.2
	for <qemu-devel@nongnu.org>; Tue, 10 May 2016 12:13:15 -0700 (PDT)
References: <1462895205-8411-1-git-send-email-sergey.fedorov@linaro.org>
	<1462895205-8411-2-git-send-email-sergey.fedorov@linaro.org>
	<c79a866c-2684-6510-72d4-a278f9a91083@twiddle.net>
From: Sergey Fedorov <serge.fdrv@gmail.com>
Message-ID: <573232C8.7040906@gmail.com>
Date: Tue, 10 May 2016 22:13:12 +0300
MIME-Version: 1.0
In-Reply-To: <c79a866c-2684-6510-72d4-a278f9a91083@twiddle.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/5] cpu-exec: Move halt handling out of
 cpu_exec()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, Sergey Fedorov <sergey.fedorov@linaro.org>, qemu-devel@nongnu.org
Cc: =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Peter Crosthwaite <crosthwaite.peter@gmail.com>

On 10/05/16 19:13, Richard Henderson wrote:
> On 05/10/2016 05:46 AM, Sergey Fedorov wrote:
>> +#if defined(TARGET_I386) && !defined(CONFIG_USER_ONLY)
>> +        X86CPU *x86_cpu = X86_CPU(cpu);
>> +
>> +        if ((cpu->interrupt_request & CPU_INTERRUPT_POLL)
>> +            && replay_interrupt()) {
>> +            apic_poll_irq(x86_cpu->apic_state);
>
> Since you're moving this around, you might as well place the x86_cpu
> variable in the inner-most if, next to its only use.

Agree, will fix in v2.

>
> Otherwise,
>
> Reviewed-by: Richard Henderson <rth@twiddle.net>

Kind regards,
Sergey