From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58243)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1b0DDq-0008CU-Me
	for qemu-devel@nongnu.org; Tue, 10 May 2016 15:21:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1b0DDn-000881-QV
	for qemu-devel@nongnu.org; Tue, 10 May 2016 15:21:34 -0400
Received: from mail-lf0-x243.google.com ([2a00:1450:4010:c07::243]:33398)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1b0DDn-00087n-FM
	for qemu-devel@nongnu.org; Tue, 10 May 2016 15:21:31 -0400
Received: by mail-lf0-x243.google.com with SMTP id j8so2405761lfd.0
	for <qemu-devel@nongnu.org>; Tue, 10 May 2016 12:21:31 -0700 (PDT)
References: <1462895205-8411-1-git-send-email-sergey.fedorov@linaro.org>
	<1462895205-8411-3-git-send-email-sergey.fedorov@linaro.org>
	<25148458-e203-e333-d5df-af7f69f7ec5c@twiddle.net>
From: Sergey Fedorov <serge.fdrv@gmail.com>
Message-ID: <573234B3.8030501@gmail.com>
Date: Tue, 10 May 2016 22:21:23 +0300
MIME-Version: 1.0
In-Reply-To: <25148458-e203-e333-d5df-af7f69f7ec5c@twiddle.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/5] cpu-exec: Move exception handling out
 of cpu_exec()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, Sergey Fedorov <sergey.fedorov@linaro.org>, qemu-devel@nongnu.org
Cc: =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Peter Crosthwaite <crosthwaite.peter@gmail.com>

On 10/05/16 19:21, Richard Henderson wrote:
> On 05/10/2016 05:46 AM, Sergey Fedorov wrote:
>> From: Sergey Fedorov <serge.fdrv@gmail.com>
>>
>> Simplify cpu_exec() by extracting exception handling code out of
>> cpu_exec() into a new static inline function cpu_handle_exception().
>> Also make cpu_handle_debug_exception() inline as it is used only once.
>
> If it's used only once, the compiler is going to do this anyway, and
> therefore there's no point in making the change.  Let's just leave off
> all the inline markers and trust the compiler, eh?

I agree the compiler is smart enough to decide and inline such functions
by itself. But actually, I hope such "static inline" in .c file could
indicate for a reader of the code that this function is going to be used
this way.

>
> Otherwise,
>
> Reviewed-by: Richard Henderson <rth@twiddle.net>

Kind regards,
Sergey