From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [net-next PATCH v2 1/6] net sched: vlan action fix late binding
Date: Tue, 10 May 2016 16:52:06 -0400 [thread overview]
Message-ID: <573249F6.7030105@mojatatu.com> (raw)
In-Reply-To: <CAM_iQpVtk1AowsH_jDz24yNqAZTCOPtMk=KM0dhFtYUJLfOk4Q@mail.gmail.com>
On 16-05-08 11:08 PM, Cong Wang wrote:
>> + if (aexists)
>> + tcf_hash_release(a, bind);
>
>
> Introduce a goto to reduce duplicated cleanup code?
>
I addressed all your comments except for above goto. There are different
return codes for all failures - and the cleverness of a goto seems
unecessary.
cheers,
jamal
next prev parent reply other threads:[~2016-05-10 20:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-08 17:26 [net-next PATCH v2 0/6] net sched: Fix broken late binding of actions Jamal Hadi Salim
2016-05-08 17:26 ` [net-next PATCH v2 1/6] net sched: vlan action fix late binding Jamal Hadi Salim
2016-05-09 3:08 ` Cong Wang
2016-05-09 11:50 ` Jamal Hadi Salim
2016-05-10 20:52 ` Jamal Hadi Salim [this message]
2016-05-08 17:26 ` [net-next PATCH v2 2/6] net sched: ipt " Jamal Hadi Salim
2016-05-08 17:26 ` [net-next PATCH v2 3/6] net sched: mirred " Jamal Hadi Salim
2016-05-09 3:19 ` Cong Wang
2016-05-09 11:51 ` Jamal Hadi Salim
2016-05-10 4:37 ` Cong Wang
2016-05-08 17:26 ` [net-next PATCH v2 4/6] net sched: simple " Jamal Hadi Salim
2016-05-08 17:26 ` [net-next PATCH v2 5/6] net sched: skbedit " Jamal Hadi Salim
2016-05-09 3:28 ` Cong Wang
2016-05-09 11:53 ` Jamal Hadi Salim
2016-05-08 17:26 ` [net-next PATCH v2 6/6] net sched: ife " Jamal Hadi Salim
2016-05-09 3:32 ` Cong Wang
2016-05-09 11:54 ` Jamal Hadi Salim
2016-05-08 17:29 ` [net-next PATCH v2 0/6] net sched: Fix broken late binding of actions Jamal Hadi Salim
2016-05-09 4:30 ` David Miller
2016-05-09 11:54 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573249F6.7030105@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.