From: Jens Axboe <axboe@kernel.dk>
To: Michael Callahan <michaelcallahan@fb.com>, linux-block@vger.kernel.org
Cc: axboe@fb.com, coder.callahan@gmail.com
Subject: Re: [PATCH 1/1] block: Use per-cpu partition in_flight counters.
Date: Tue, 10 May 2016 16:18:31 -0600 [thread overview]
Message-ID: <57325E37.6090309@kernel.dk> (raw)
In-Reply-To: <tc260ulmupc.fsf@vmbox.dyndns.org>
On 05/10/2016 04:09 PM, Michael Callahan wrote:
> Move the partition in_flight counters from hd_struct to disk_stats so
> that they become tracked on a per-cpu basis.
>
> Sign-off-by: Michael Callahan <michaelcallahan@fb.com>
^^ Signed-off-by
> ---
>
> This patch is incomplete as it just comments out use of in_flight in dm.c as
> that code tracks io statistics in it's own special way. Any thoughts on
> how to fix dm.c are welcome.
This has been done and rejected before. The problem is that you are now
having to do a full per cpu loop in part_in_flight(), which is a
non-starter. Unless you can make that part more clever, than it's not
going to be a great idea.
Generally, doing patches like this, you should include test results
showing why this is a good idea. A good commit message is a "why" for
the patch.
--
Jens Axboe
next prev parent reply other threads:[~2016-05-10 22:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 22:09 [PATCH 1/1] block: Use per-cpu partition in_flight counters Michael Callahan
2016-05-10 22:18 ` Jens Axboe [this message]
2016-05-16 20:06 ` Michael Callahan
2016-05-16 21:17 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57325E37.6090309@kernel.dk \
--to=axboe@kernel.dk \
--cc=axboe@fb.com \
--cc=coder.callahan@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=michaelcallahan@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.