All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Cutler <ncutler@suse.cz>
To: Ken Dreyer <kdreyer@redhat.com>
Cc: Ceph Development <ceph-devel@vger.kernel.org>
Subject: Re: How are you dealing with hammer -> jewel upgrades?
Date: Wed, 11 May 2016 01:49:59 +0200	[thread overview]
Message-ID: <573273A7.3040902@suse.cz> (raw)
In-Reply-To: <CALqRxCxvKHSy=iGctuQq5fT=uTcEbR1jOLK5ZaRXiPovH_POjQ@mail.gmail.com>

On 05/10/2016 07:13 PM, Ken Dreyer wrote:
 > I was thinking about handling it in the OSD directly, particularly
 > since it already has the UID from --setuid.
 > http://tracker.ceph.com/issues/15733

Thanks, Ken, for reminding me of that tracker issue! I would rather 
implement the recursive ownership change for filestore-backed OSDs 
(assuming it's not a totally insane thing to be doing) in ceph-disk than 
in the OSD itself, for the following reasons.

ceph-disk already contains heuristics for determining the user/group to 
pass to ceph-osd [1] and "--setuser ceph --setgroup ceph" is hardcoded 
when starting ceph-osd via the systemd service [2].

If someone is passing a user/group other than "ceph" to the OSD via 
--setuser/--setgroup, they will be doing the same with ceph-disk (which 
also takes --setuser/--setgroup). Alternatively they will not be using 
ceph-disk at all.

Right?

Nathan

[1] 
https://github.com/ceph/ceph/blob/master/src/ceph-disk/ceph_disk/main.py#L951
[2] https://github.com/ceph/ceph/blob/master/systemd/ceph-osd%40.service#L12

  reply	other threads:[~2016-05-10 23:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-10 15:29 How are you dealing with hammer -> jewel upgrades? Nathan Cutler
2016-05-10 17:13 ` Ken Dreyer
2016-05-10 23:49   ` Nathan Cutler [this message]
2016-05-11  0:09     ` Ken Dreyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=573273A7.3040902@suse.cz \
    --to=ncutler@suse.cz \
    --cc=ceph-devel@vger.kernel.org \
    --cc=kdreyer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.