From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH] ARM: dts: exynos: Only Odroid XU3-family boards use DTSI with CPU thermal nodes Date: Wed, 11 May 2016 07:49:19 +0200 Message-ID: <5732C7DF.2080800@samsung.com> References: <1462774789-15360-1-git-send-email-k.kozlowski@samsung.com> <573198BE.6020900@samsung.com> <5731D764.8070007@samsung.com> <5731EA1B.4070201@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout2.w1.samsung.com ([210.118.77.12]:38033 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751152AbcEKFtZ (ORCPT ); Wed, 11 May 2016 01:49:25 -0400 In-reply-to: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Anand Moon Cc: Kukjin Kim , Lukasz Majewski , Javier Martinez Canillas , devicetree , linux-arm-kernel , "linux-samsung-soc@vger.kernel.org" , Linux Kernel , Bartlomiej Zolnierkiewicz On 05/10/2016 09:45 PM, Anand Moon wrote: > Hi Krzysztof, > > Sorry I am not able to explain my self clearly. > But I have once gain tested these changes. > > Only could you append with following changes. > -------------------------------------------------------- > + cpu_crit0: cpu-crit-0 { > + temperature = <120000>; /* > millicelsius */ > + hysteresis = <5000>; /* millicelsius */ > + type = "critical"; > + }; > -------------------------------------------------------- > hysteresis time help to adjust the present and past temperature inputs > before critical shutdown. I need more details why you want this patch. What is the point of hysteresis on critical trip point? When reaching this trip point the system shutdowns... there is nothing more to do, I think. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Wed, 11 May 2016 07:49:19 +0200 Subject: [PATCH] ARM: dts: exynos: Only Odroid XU3-family boards use DTSI with CPU thermal nodes In-Reply-To: References: <1462774789-15360-1-git-send-email-k.kozlowski@samsung.com> <573198BE.6020900@samsung.com> <5731D764.8070007@samsung.com> <5731EA1B.4070201@samsung.com> Message-ID: <5732C7DF.2080800@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 05/10/2016 09:45 PM, Anand Moon wrote: > Hi Krzysztof, > > Sorry I am not able to explain my self clearly. > But I have once gain tested these changes. > > Only could you append with following changes. > -------------------------------------------------------- > + cpu_crit0: cpu-crit-0 { > + temperature = <120000>; /* > millicelsius */ > + hysteresis = <5000>; /* millicelsius */ > + type = "critical"; > + }; > -------------------------------------------------------- > hysteresis time help to adjust the present and past temperature inputs > before critical shutdown. I need more details why you want this patch. What is the point of hysteresis on critical trip point? When reaching this trip point the system shutdowns... there is nothing more to do, I think. Best regards, Krzysztof