From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Huth Subject: Re: [kvm-unit-tests PATCH 2/2] devicetree: use node #address/size-cells Date: Wed, 11 May 2016 09:12:50 +0200 Message-ID: <5732DB72.2010202@redhat.com> References: <1462901526-11013-1-git-send-email-drjones@redhat.com> <1462901526-11013-3-git-send-email-drjones@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: lvivier@redhat.com, pbonzini@redhat.com To: Andrew Jones , kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:37325 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751664AbcEKHMy (ORCPT ); Wed, 11 May 2016 03:12:54 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 68CB581111 for ; Wed, 11 May 2016 07:12:53 +0000 (UTC) In-Reply-To: <1462901526-11013-3-git-send-email-drjones@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10.05.2016 19:32, Andrew Jones wrote: > Don't assume all pbus (cpu physical bus) translations will use the same > number of address and size cells as are defined in the root node. That's a good idea, of course. > Also, > drop the caching of the address/size cells in the bus structure, as that > was a bad idea, and unused anyway. Maybe do it in a separate patch? > (I was tempted to completely remove dt_pbus_translate_node, which still > uses the root node's address/size cells, but I kept it, as it offers a > nice shortcut for when we are sure we can use the root node's cells.) Sounds like this function could cause quite a bit of confusion in the future... maybe it would be better to remove it so that no one can use it in the wrong way anymore? Thomas