From mboxrd@z Thu Jan  1 00:00:00 1970
From: Clemens Ladisch <clemens@ladisch.de>
Subject: Re: [PATCH] ALSA: firewire-lib: drop skip argument
	from	helper functions to queue a packet
Date: Wed, 11 May 2016 09:48:23 +0200
Message-ID: <5732E3C7.2030604@ladisch.de>
References: <1462919709-8692-1-git-send-email-o-takashi@sakamocchi.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from dehamd003.servertools24.de (dehamd003.servertools24.de
 [31.47.254.18]) by alsa0.perex.cz (Postfix) with ESMTP id D380E2607C8
 for <alsa-devel@alsa-project.org>; Wed, 11 May 2016 09:48:24 +0200 (CEST)
In-Reply-To: <1462919709-8692-1-git-send-email-o-takashi@sakamocchi.jp>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org, ffado-devel@lists.sf.net
List-Id: alsa-devel@alsa-project.org

Takashi Sakamoto wrote:
> On most of audio and music units on IEEE 1394 bus which ALSA firewire stack
> supports (or plans to support), CIP with two quadlets header is used.
> Thus, there's no cases to queue packets with blank payload. If such packets
> are going to be queued, it means that they're for skips of the cycle.
>
> This commit simplifies helper functions to queue a packet.

> @@ -383,8 +382,10 @@ static int queue_packet(struct amdtp_stream *s,
>  	p.tag = TAG_CIP;
>  	p.header_length = header_length;
> -	p.payload_length = (!skip) ? payload_length : 0;
> -	p.skip = skip;
> +	if (payload_length > 0)
> +		p.payload_length = payload_length;
> +	else
> +		p.skip = true;

This can be simplified to:
	p.payload_length = payload_length;
	p.skip = payload_length == 0;


Acked-by: Clemens Ladisch <clemens@ladisch.de>


Regards,
Clemens