From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 15/23] drm: omapdrm: Don't expose the omap_irq_(un)register() functions Date: Wed, 11 May 2016 14:05:48 +0300 Message-ID: <5733120C.80605@ti.com> References: <1461702945-14185-1-git-send-email-laurent.pinchart@ideasonboard.com> <1461702945-14185-16-git-send-email-laurent.pinchart@ideasonboard.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1923285094==" Return-path: Received: from arroyo.ext.ti.com (arroyo.ext.ti.com [198.47.19.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2107D6E5EC for ; Wed, 11 May 2016 11:17:17 +0000 (UTC) In-Reply-To: <1461702945-14185-16-git-send-email-laurent.pinchart@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1923285094== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="I39DdMoTlo1A5jXe69wKksm0lvf943STs" --I39DdMoTlo1A5jXe69wKksm0lvf943STs Content-Type: multipart/mixed; boundary="Lw270WIkNKTv7rQEBFLTSOdw1ehXhirHO" From: Tomi Valkeinen To: Laurent Pinchart , dri-devel@lists.freedesktop.org Cc: Rob Clark Message-ID: <5733120C.80605@ti.com> Subject: Re: [PATCH 15/23] drm: omapdrm: Don't expose the omap_irq_(un)register() functions References: <1461702945-14185-1-git-send-email-laurent.pinchart@ideasonboard.com> <1461702945-14185-16-git-send-email-laurent.pinchart@ideasonboard.com> In-Reply-To: <1461702945-14185-16-git-send-email-laurent.pinchart@ideasonboard.com> --Lw270WIkNKTv7rQEBFLTSOdw1ehXhirHO Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 26/04/16 23:35, Laurent Pinchart wrote: > The functions are not used outside of their compilation unit, make them= > static. The patch doesn't seem to match the description. If I'm not mistaken, the patch is doing: remove __omap_irq_* funcs, remove parameter from the irq callback, make funcs static. Combining everything into one patch makes it difficult to review, especially if the description doesn't explain what's done. Tomi --Lw270WIkNKTv7rQEBFLTSOdw1ehXhirHO-- --I39DdMoTlo1A5jXe69wKksm0lvf943STs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXMxIMAAoJEPo9qoy8lh71jU4QAKf+Z/5Po29UFwVQUStiw0iV 2TwDhULLg+lp+puI5mt7qYZHsdvo9A/fQRJEraFMoY5O9V4dqyMyJ9GenXmXgkLB h3d2k6u/M08vTsrD8J0jbd5iTc1wT6eg0R7pCMkrlyZQxLsJx6ttefAt3Q7vN0mj CUC3Ve8gAcwXRrYz9X05ikeCExCzUT0Pi1/jFz0JyUe2klVihlZXJGKnp2enN7VG RBZ72DqYikSKHUSgW8gHzmhuw7CUYl7rqFFALarvK+rGD2evdEXkI6Hdhj/LAQwC TlIIfJz2+GnDoigmco2luh6jZZ3/cm2yKFU7HgeuuM+iSezR4kXvP9zpYyvXzuRt IpOMPeRtID3O/cDSqKRaQIrzJ27UI04VbGPL7kwZhnTRxllGiRX8poBpafCDLjBH Hita/MASHEsuZU34A/82vZemQJMAI5/Q4+aLdF5XaXeXzywiEUnwZU2X6zqXcXRN YviJ2gHppvbwYBvCGX2JvGsQ2ZnxvbQkksv6oQLFd7+ruYn37DeddSqqdlSKKqaF LhLGxDtdLYtGvwKnWz2VF3yfF2Rg+xVxLP/D/r155h4kJX5dwsASvW9E1tEj0Jrt mzkqsat/8umMkRfCoxIetbu2DXqI3kKSZLBkE41UNogdMkLBA1BYv1+9Wv8G8DEm pZ8rWMUZ7XXsQtH0f211 =5Fmy -----END PGP SIGNATURE----- --I39DdMoTlo1A5jXe69wKksm0lvf943STs-- --===============1923285094== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1923285094==--