From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 23/23] drm: omapdrm: Remove buffer synchronization support Date: Wed, 11 May 2016 14:12:47 +0300 Message-ID: <573313AF.9090100@ti.com> References: <1461702945-14185-1-git-send-email-laurent.pinchart@ideasonboard.com> <1461702945-14185-24-git-send-email-laurent.pinchart@ideasonboard.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1558679170==" Return-path: Received: from arroyo.ext.ti.com (arroyo.ext.ti.com [198.47.19.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 033126E547 for ; Wed, 11 May 2016 11:12:53 +0000 (UTC) In-Reply-To: <1461702945-14185-24-git-send-email-laurent.pinchart@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1558679170== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="seuGWNpbKPNcWovE32SDvpGKNQmQoljaf" --seuGWNpbKPNcWovE32SDvpGKNQmQoljaf Content-Type: multipart/mixed; boundary="PbidbsXtBuVgd8oLOGLnkqIVXqAnfXrlR" From: Tomi Valkeinen To: Laurent Pinchart , dri-devel@lists.freedesktop.org Cc: Rob Clark Message-ID: <573313AF.9090100@ti.com> Subject: Re: [PATCH 23/23] drm: omapdrm: Remove buffer synchronization support References: <1461702945-14185-1-git-send-email-laurent.pinchart@ideasonboard.com> <1461702945-14185-24-git-send-email-laurent.pinchart@ideasonboard.com> In-Reply-To: <1461702945-14185-24-git-send-email-laurent.pinchart@ideasonboard.com> --PbidbsXtBuVgd8oLOGLnkqIVXqAnfXrlR Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 26/04/16 23:35, Laurent Pinchart wrote: > The omapdrm driver uses a custom API to synchronize with the SGX GPU. > This is unusable as such in the mainline kernel as the API is only > partially implemented and requires additional out-of-tree patches. > Furthermore, as no SGX driver is available in the mainline kernel, the > API can't be considered as a stable mainline API. >=20 > Remove buffer synchronization support to prepare for its replacement by= > an implementation based on standard fences and reservation objects. I thought one thing the OMAP_GEM_CPU_PREP/FINI ioctls were supposed to do it cache flushing, if the buffer is OMAP_BO_CACHED. I don't think that works, though, which might be considered as an omapdrm bug. Also, if an app is using the prep/fini ioctls at the moment, even if it doesn't exactly require flushing (or any kind of synchronization), after this patch the app might fail. So even if we remove all the code behind, perhaps we should leave no-op ioctls. Tomi --PbidbsXtBuVgd8oLOGLnkqIVXqAnfXrlR-- --seuGWNpbKPNcWovE32SDvpGKNQmQoljaf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXMxOwAAoJEPo9qoy8lh71YtkP/1muLHIFr9745ELyGcq+dIbL ocZc3HxN3jglySWhku8m6wEIdhiq/Dp/5wDZuL2PE34YUuZXOEk0TCS5EhmHKHfg AYjMqQZzPtjx5d7LA1HV89xcyUKvYZ1FmhagR3iKv3F3ArQsbnpXZUNbIAaKCCKx umveCb+KsNVcqtT51tnOE8caiS9G3il4Uu8FIXrFng3znjeNynEuROSqFUX6bfqC G+O8V/0dGQX2p8XGh/hWCnmo+0FrqlDOL8ISHaiE8cAbGkjE0OPp0gIriSiNQOOB Nm9lcoS93b/tXpYVyRaN8961NQ70m2kaQOlGX4+GuwxXpN4f1crsO0exzC8KTtx/ wpck2JMq6WWB4RZvRR0dDpmO3naLiCtx64E4KHHdaO4pmDqqw0O0+2bk8ODFRCGp dSfExokTqUZLWUiCj/WumhDwOQ/tuXdUxck7c7o/jhSu85pwE5PMHs2cTSl3MJvL w7OFSORoRacIEauMMHnXNgQHPrr4z0gTO03bIsFQc6BjcRRGzWQp4v4MKMq+wvVo siyii3ciam4wjtYS+oK+EeKW4pGQQuPP5WptuRsCBM+z+du6kzf6poZNq3E87bJ2 UgPqYAI0sUROkJYEmdUoLiDAYDjHTztRUuYp0qujRjefAY8uUFV+EdQxVVWxTW5M Aab5CmpzBp4ATyjntyrY =TbyQ -----END PGP SIGNATURE----- --seuGWNpbKPNcWovE32SDvpGKNQmQoljaf-- --===============1558679170== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1558679170==--