All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: NeilBrown <nfbrown@novell.com>, Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	Artem Bityutskiy <dedekind1@gmail.com>,
	Christoph Hellwig <hch@infradead.org>,
	NFS List <linux-nfs@vger.kernel.org>
Subject: Re: Reconsidering exportable UBIFS
Date: Wed, 11 May 2016 16:09:34 +0200	[thread overview]
Message-ID: <57333D1E.9090706@nod.at> (raw)
In-Reply-To: <87y47ju8kk.fsf@notabene.neil.brown.name>

Am 09.05.2016 um 07:03 schrieb NeilBrown:
> On Mon, May 09 2016, Al Viro wrote:
> 
>> On Mon, May 09, 2016 at 08:18:22AM +1000, NeilBrown wrote:
>>
>>> Not puppies, just kittens.
>>>
>>> If you don't provide these functions, then exporting with
>>> "subtree_check" won't work.  That is no great loss except that people
>>> might find the failure confusing.
>>
>> 	OK, a client sends you a RENAME.  With fhandles of both parents +
>> old and new names in those.  Your task, should you choose to accept it, is
>> to figure out whether we should fail with nfserr_inval due to an attempt
>> to make a directory its own descendent.  Without being able to locate all
>> ancestors of a directory.
> 
> You are right, sorry.  I was thinking that get_parent() was for finding
> the parent of a non-directory, but it is for directories.  It does the
> equivalent of lookup("..").  So if you have a ".." link or something
> like it, it should be easy.  If you don't, it won't be easy at all.

Thanks for the detailed explanation.
UBIFS does not have ".." links in the on-flash layout.
So, we'd have to change this.

Thanks,
//richard

  reply	other threads:[~2016-05-11 14:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-04 22:17 Reconsidering exportable UBIFS Richard Weinberger
2016-04-18  9:04 ` Artem Bityutskiy
2016-05-08 22:18 ` NeilBrown
2016-05-08 23:25   ` Al Viro
2016-05-09  5:03     ` NeilBrown
2016-05-11 14:09       ` Richard Weinberger [this message]
2016-05-11 14:10   ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57333D1E.9090706@nod.at \
    --to=richard@nod.at \
    --cc=dedekind1@gmail.com \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=nfbrown@novell.com \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.