From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50628)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1b0Zp6-0007Fd-T7
	for qemu-devel@nongnu.org; Wed, 11 May 2016 15:29:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1b0Zp1-0006fd-PZ
	for qemu-devel@nongnu.org; Wed, 11 May 2016 15:29:31 -0400
Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:57174)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1b0Zp1-0006cD-Bl
	for qemu-devel@nongnu.org; Wed, 11 May 2016 15:29:27 -0400
Received: from localhost
	by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <borntraeger@de.ibm.com>;
	Wed, 11 May 2016 20:29:22 +0100
Received: from b06cxnps4074.portsmouth.uk.ibm.com
	(d06relay11.portsmouth.uk.ibm.com [9.149.109.196])
	by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 333932190046
	for <qemu-devel@nongnu.org>; Wed, 11 May 2016 20:28:34 +0100 (BST)
Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com
	[9.149.37.248])
	by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id u4BJSwvf23921102
	for <qemu-devel@nongnu.org>; Wed, 11 May 2016 19:28:58 GMT
Received: from d06av07.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id u4BJSwGj005037
	for <qemu-devel@nongnu.org>; Wed, 11 May 2016 15:28:58 -0400
References: <1462812240-31204-1-git-send-email-aurelien@aurel32.net>
	<5730CE8B.1000203@weilnetz.de>
	<CAFEAcA9994fxyEDLaFUP_GVJfAWTw_xACQ95tzfEYnQYwjNf1A@mail.gmail.com>
	<CAFEAcA-ecA+FkV=pNUEdSULMgc+Q4kqEmgL++fqHA-pyN-_2bg@mail.gmail.com>
From: Christian Borntraeger <borntraeger@de.ibm.com>
Message-ID: <573387F9.8080304@de.ibm.com>
Date: Wed, 11 May 2016 21:28:57 +0200
MIME-Version: 1.0
In-Reply-To: <CAFEAcA-ecA+FkV=pNUEdSULMgc+Q4kqEmgL++fqHA-pyN-_2bg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] target-mips: fix call to memset in soft
 reset code
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, Stefan Weil <sw@weilnetz.de>
Cc: Leon Alrae <leon.alrae@imgtec.com>, QEMU Developers <qemu-devel@nongnu.org>, Aurelien Jarno <aurelien@aurel32.net>

On 05/09/2016 07:57 PM, Peter Maydell wrote:
> On 9 May 2016 at 18:55, Peter Maydell <peter.maydell@linaro.org> wrote:
>> On 9 May 2016 at 18:53, Stefan Weil <sw@weilnetz.de> wrote:
>>> I suggest to apply this patch to 2.6, if this is still possible
>>
>> It is not; sorry.

I think we have delayed 2.6 already far too long (so please release)
but


> Note that it's only an error if you're building with -Werror, and
> releases don't default to -Werror, so users using released QEMU 2.6
> shouldn't hit this even with the newer gcc. Developers developing
> on trunk shouldn't be unduly inconvenienced if the commit fixing it
> is post-2.6-release rather than the actual release.

to me it looks like that this is not a compile time error, instead we
really do not memset a variable that we are supposed to memset.
the only reason to not consider it for 2.6 is that its is really old
and it did not seem to cause harm.

Christian