From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A270FC43461 for ; Tue, 15 Sep 2020 08:21:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F1CD21D1B for ; Tue, 15 Sep 2020 08:21:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EcDpTG1a" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726373AbgIOIVX (ORCPT ); Tue, 15 Sep 2020 04:21:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:54044 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726340AbgIOITJ (ORCPT ); Tue, 15 Sep 2020 04:19:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600157947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3bhDFHrLKx2Ugr++K3UZXsMiyEdJCQXQW25owbTuEPc=; b=EcDpTG1arSWhyuAHQuyBdv0+Q+G1IMK5Z9AboLCn8j8AvfH5MaYqnwnnMurdsejbSCnQ/6 /wsZAo5+CfMSvEU+a/7RBKuQvAYDS0KMi+0gDUjWZa4soXd1IFIi6TIY76br98cPMruJ33 gkDNNv812WTxRAcnkDSq3fSNCwOmP9o= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-592-zNagHMNCPB-SgFEqX8TqPw-1; Tue, 15 Sep 2020 04:19:03 -0400 X-MC-Unique: zNagHMNCPB-SgFEqX8TqPw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 53E0480F040; Tue, 15 Sep 2020 08:19:01 +0000 (UTC) Received: from [10.72.13.94] (ovpn-13-94.pek2.redhat.com [10.72.13.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1A9D55DDB8; Tue, 15 Sep 2020 08:18:47 +0000 (UTC) Subject: Re: [RFC PATCH 00/22] Enhance VHOST to enable SoC-to-SoC communication To: Kishon Vijay Abraham I , Cornelia Huck Cc: "Michael S. Tsirkin" , Ohad Ben-Cohen , Bjorn Andersson , Jon Mason , Dave Jiang , Allen Hubbe , Lorenzo Pieralisi , Bjorn Helgaas , Paolo Bonzini , Stefan Hajnoczi , Stefano Garzarella , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-ntb@googlegroups.com, linux-pci@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org References: <20200702082143.25259-1-kishon@ti.com> <20200702055026-mutt-send-email-mst@kernel.org> <603970f5-3289-cd53-82a9-aa62b292c552@redhat.com> <14c6cad7-9361-7fa4-e1c6-715ccc7e5f6b@ti.com> <59fd6a0b-8566-44b7-3dae-bb52b468219b@redhat.com> <45a8a97c-2061-13ee-5da8-9877a4a3b8aa@ti.com> <20200828123409.4cd2a812.cohuck@redhat.com> <9cd58cd1-0041-3d98-baf7-6e5bc2e7e317@redhat.com> From: Jason Wang Message-ID: <5733dbfc-76c1-45dc-6dce-ef5449eacc73@redhat.com> Date: Tue, 15 Sep 2020 16:18:46 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Hi Kishon: On 2020/9/14 下午3:23, Kishon Vijay Abraham I wrote: >> Then you need something that is functional equivalent to virtio PCI >> which is actually the concept of vDPA (e.g vDPA provides alternatives if >> the queue_sel is hard in the EP implementation). > Okay, I just tried to compare the 'struct vdpa_config_ops' and 'struct > vhost_config_ops' ( introduced in [RFC PATCH 03/22] vhost: Add ops for > the VHOST driver to configure VHOST device). > > struct vdpa_config_ops { > /* Virtqueue ops */ > int (*set_vq_address)(struct vdpa_device *vdev, > u16 idx, u64 desc_area, u64 driver_area, > u64 device_area); > void (*set_vq_num)(struct vdpa_device *vdev, u16 idx, u32 num); > void (*kick_vq)(struct vdpa_device *vdev, u16 idx); > void (*set_vq_cb)(struct vdpa_device *vdev, u16 idx, > struct vdpa_callback *cb); > void (*set_vq_ready)(struct vdpa_device *vdev, u16 idx, bool ready); > bool (*get_vq_ready)(struct vdpa_device *vdev, u16 idx); > int (*set_vq_state)(struct vdpa_device *vdev, u16 idx, > const struct vdpa_vq_state *state); > int (*get_vq_state)(struct vdpa_device *vdev, u16 idx, > struct vdpa_vq_state *state); > struct vdpa_notification_area > (*get_vq_notification)(struct vdpa_device *vdev, u16 idx); > /* vq irq is not expected to be changed once DRIVER_OK is set */ > int (*get_vq_irq)(struct vdpa_device *vdv, u16 idx); > > /* Device ops */ > u32 (*get_vq_align)(struct vdpa_device *vdev); > u64 (*get_features)(struct vdpa_device *vdev); > int (*set_features)(struct vdpa_device *vdev, u64 features); > void (*set_config_cb)(struct vdpa_device *vdev, > struct vdpa_callback *cb); > u16 (*get_vq_num_max)(struct vdpa_device *vdev); > u32 (*get_device_id)(struct vdpa_device *vdev); > u32 (*get_vendor_id)(struct vdpa_device *vdev); > u8 (*get_status)(struct vdpa_device *vdev); > void (*set_status)(struct vdpa_device *vdev, u8 status); > void (*get_config)(struct vdpa_device *vdev, unsigned int offset, > void *buf, unsigned int len); > void (*set_config)(struct vdpa_device *vdev, unsigned int offset, > const void *buf, unsigned int len); > u32 (*get_generation)(struct vdpa_device *vdev); > > /* DMA ops */ > int (*set_map)(struct vdpa_device *vdev, struct vhost_iotlb *iotlb); > int (*dma_map)(struct vdpa_device *vdev, u64 iova, u64 size, > u64 pa, u32 perm); > int (*dma_unmap)(struct vdpa_device *vdev, u64 iova, u64 size); > > /* Free device resources */ > void (*free)(struct vdpa_device *vdev); > }; > > +struct vhost_config_ops { > + int (*create_vqs)(struct vhost_dev *vdev, unsigned int nvqs, > + unsigned int num_bufs, struct vhost_virtqueue *vqs[], > + vhost_vq_callback_t *callbacks[], > + const char * const names[]); > + void (*del_vqs)(struct vhost_dev *vdev); > + int (*write)(struct vhost_dev *vdev, u64 vhost_dst, void *src, int len); > + int (*read)(struct vhost_dev *vdev, void *dst, u64 vhost_src, int len); > + int (*set_features)(struct vhost_dev *vdev, u64 device_features); > + int (*set_status)(struct vhost_dev *vdev, u8 status); > + u8 (*get_status)(struct vhost_dev *vdev); > +}; > + > struct virtio_config_ops > I think there's some overlap here and some of the ops tries to do the > same thing. > > I think it differs in (*set_vq_address)() and (*create_vqs)(). > [create_vqs() introduced in struct vhost_config_ops provides > complimentary functionality to (*find_vqs)() in struct > virtio_config_ops. It seemingly encapsulates the functionality of > (*set_vq_address)(), (*set_vq_num)(), (*set_vq_cb)(),..]. > > Back to the difference between (*set_vq_address)() and (*create_vqs)(), > set_vq_address() directly provides the virtqueue address to the vdpa > device but create_vqs() only provides the parameters of the virtqueue > (like the number of virtqueues, number of buffers) but does not directly > provide the address. IMO the backend client drivers (like net or vhost) > shouldn't/cannot by itself know how to access the vring created on > virtio front-end. The vdpa device/vhost device should have logic for > that. That will help the client drivers to work with different types of > vdpa device/vhost device and can access the vring created by virtio > irrespective of whether the vring can be accessed via mmio or kernel > space or user space. > > I think vdpa always works with client drivers in userspace and providing > userspace address for vring. Sorry for being unclear. What I meant is not replacing vDPA with the vhost(bus) you proposed but the possibility of replacing virtio-pci-epf with vDPA in: My question is basically for the part of virtio_pci_epf_send_command(), so it looks to me you have a vendor specific API to replace the virtio-pci layout of the BAR: +static int virtio_pci_epf_send_command(struct virtio_pci_device *vp_dev, +                       u32 command) +{ +    struct virtio_pci_epf *pci_epf; +    void __iomem *ioaddr; +    ktime_t timeout; +    bool timedout; +    int ret = 0; +    u8 status; + +    pci_epf = to_virtio_pci_epf(vp_dev); +    ioaddr = vp_dev->ioaddr; + +    mutex_lock(&pci_epf->lock); +    writeb(command, ioaddr + HOST_CMD); +    timeout = ktime_add_ms(ktime_get(), COMMAND_TIMEOUT); +    while (1) { +        timedout = ktime_after(ktime_get(), timeout); +        status = readb(ioaddr + HOST_CMD_STATUS); + Several questions: - It's not clear to me how the synchronization is done between the RC and EP. E.g how and when the value of HOST_CMD_STATUS can be changed.  If you still want to introduce a new transport, a virtio spec patch would be helpful for us to understand the device API. - You have you vendor specific layout (according to virtio_pci_epb_table()), so I guess you it's better to have a vendor specific vDPA driver instead - The advantage of vendor specific vDPA driver is that it can 1) have less codes 2) support userspace drivers through vhost-vDPA (instead of inventing new APIs since we can't use vfio-pci here). >>> "Virtio Over NTB" should anyways be a new transport. >>>> Does that make any sense? >>> yeah, in the approach I used the initial features are hard-coded in >>> vhost-rpmsg (inherent to the rpmsg) but when we have to use adapter >>> layer (vhost only for accessing virtio ring and use virtio drivers on >>> both front end and backend), based on the functionality (e.g, rpmsg), >>> the vhost should be configured with features (to be presented to the >>> virtio) and that's why additional layer or APIs will be required. >> A question here, if we go with vhost bus approach, does it mean the >> virtio device can only be implemented in EP's userspace? > The vhost bus approach doesn't provide any restriction in where the > virto backend device should be created. This series creates two types of > virtio backend device (one for PCIe endpoint and the other for NTB) and > both these devices are created in kernel. Ok. Thanks > > Thanks > Kishon > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BFC0C433E2 for ; Tue, 15 Sep 2020 08:19:11 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A1BB21974 for ; Tue, 15 Sep 2020 08:19:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="M7qnzUAG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A1BB21974 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id C6A7086462; Tue, 15 Sep 2020 08:19:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0+F-l8nOuqXq; Tue, 15 Sep 2020 08:19:09 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 8B4C786429; Tue, 15 Sep 2020 08:19:09 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 69BACC0864; Tue, 15 Sep 2020 08:19:09 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id E72E0C0051 for ; Tue, 15 Sep 2020 08:19:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id E16EA86462 for ; Tue, 15 Sep 2020 08:19:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q5pfyJR-qJlU for ; Tue, 15 Sep 2020 08:19:06 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by whitealder.osuosl.org (Postfix) with ESMTPS id 92F4A86429 for ; Tue, 15 Sep 2020 08:19:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600157945; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3bhDFHrLKx2Ugr++K3UZXsMiyEdJCQXQW25owbTuEPc=; b=M7qnzUAG/TbOi3ONJ+hprfvJXwUQ0rXuUXrLXZAUQ6wroHPIIvJiqFgAhO4mCqv/IMMJxj rAI5lsdsEikAXeTXiXayhbP3KyiQpLQ/LkjxsLRhRpI4x1BYba75In5pM72Dvp0VCcNh4a eZK/b2EAVb6Re4CU0GImc5WmbjBLt0U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-592-zNagHMNCPB-SgFEqX8TqPw-1; Tue, 15 Sep 2020 04:19:03 -0400 X-MC-Unique: zNagHMNCPB-SgFEqX8TqPw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 53E0480F040; Tue, 15 Sep 2020 08:19:01 +0000 (UTC) Received: from [10.72.13.94] (ovpn-13-94.pek2.redhat.com [10.72.13.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1A9D55DDB8; Tue, 15 Sep 2020 08:18:47 +0000 (UTC) Subject: Re: [RFC PATCH 00/22] Enhance VHOST to enable SoC-to-SoC communication To: Kishon Vijay Abraham I , Cornelia Huck References: <20200702082143.25259-1-kishon@ti.com> <20200702055026-mutt-send-email-mst@kernel.org> <603970f5-3289-cd53-82a9-aa62b292c552@redhat.com> <14c6cad7-9361-7fa4-e1c6-715ccc7e5f6b@ti.com> <59fd6a0b-8566-44b7-3dae-bb52b468219b@redhat.com> <45a8a97c-2061-13ee-5da8-9877a4a3b8aa@ti.com> <20200828123409.4cd2a812.cohuck@redhat.com> <9cd58cd1-0041-3d98-baf7-6e5bc2e7e317@redhat.com> From: Jason Wang Message-ID: <5733dbfc-76c1-45dc-6dce-ef5449eacc73@redhat.com> Date: Tue, 15 Sep 2020 16:18:46 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Cc: Ohad Ben-Cohen , Allen Hubbe , Lorenzo Pieralisi , Dave Jiang , kvm@vger.kernel.org, linux-ntb@googlegroups.com, "Michael S. Tsirkin" , linux-pci@vger.kernel.org, linux-doc@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , netdev@vger.kernel.org, Stefan Hajnoczi , Jon Mason , Bjorn Helgaas , Paolo Bonzini , virtualization@lists.linux-foundation.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" SGkgS2lzaG9uOgoKT24gMjAyMC85LzE0IOS4i+WNiDM6MjMsIEtpc2hvbiBWaWpheSBBYnJhaGFt IEkgd3JvdGU6Cj4+IFRoZW4geW91IG5lZWQgc29tZXRoaW5nIHRoYXQgaXMgZnVuY3Rpb25hbCBl cXVpdmFsZW50IHRvIHZpcnRpbyBQQ0kKPj4gd2hpY2ggaXMgYWN0dWFsbHkgdGhlIGNvbmNlcHQg b2YgdkRQQSAoZS5nIHZEUEEgcHJvdmlkZXMgYWx0ZXJuYXRpdmVzIGlmCj4+IHRoZSBxdWV1ZV9z ZWwgaXMgaGFyZCBpbiB0aGUgRVAgaW1wbGVtZW50YXRpb24pLgo+IE9rYXksIEkganVzdCB0cmll ZCB0byBjb21wYXJlIHRoZSAnc3RydWN0IHZkcGFfY29uZmlnX29wcycgYW5kICdzdHJ1Y3QKPiB2 aG9zdF9jb25maWdfb3BzJyAoIGludHJvZHVjZWQgaW4gW1JGQyBQQVRDSCAwMy8yMl0gdmhvc3Q6 IEFkZCBvcHMgZm9yCj4gdGhlIFZIT1NUIGRyaXZlciB0byBjb25maWd1cmUgVkhPU1QgZGV2aWNl KS4KPgo+IHN0cnVjdCB2ZHBhX2NvbmZpZ19vcHMgewo+IAkvKiBWaXJ0cXVldWUgb3BzICovCj4g CWludCAoKnNldF92cV9hZGRyZXNzKShzdHJ1Y3QgdmRwYV9kZXZpY2UgKnZkZXYsCj4gCQkJICAg ICAgdTE2IGlkeCwgdTY0IGRlc2NfYXJlYSwgdTY0IGRyaXZlcl9hcmVhLAo+IAkJCSAgICAgIHU2 NCBkZXZpY2VfYXJlYSk7Cj4gCXZvaWQgKCpzZXRfdnFfbnVtKShzdHJ1Y3QgdmRwYV9kZXZpY2Ug KnZkZXYsIHUxNiBpZHgsIHUzMiBudW0pOwo+IAl2b2lkICgqa2lja192cSkoc3RydWN0IHZkcGFf ZGV2aWNlICp2ZGV2LCB1MTYgaWR4KTsKPiAJdm9pZCAoKnNldF92cV9jYikoc3RydWN0IHZkcGFf ZGV2aWNlICp2ZGV2LCB1MTYgaWR4LAo+IAkJCSAgc3RydWN0IHZkcGFfY2FsbGJhY2sgKmNiKTsK PiAJdm9pZCAoKnNldF92cV9yZWFkeSkoc3RydWN0IHZkcGFfZGV2aWNlICp2ZGV2LCB1MTYgaWR4 LCBib29sIHJlYWR5KTsKPiAJYm9vbCAoKmdldF92cV9yZWFkeSkoc3RydWN0IHZkcGFfZGV2aWNl ICp2ZGV2LCB1MTYgaWR4KTsKPiAJaW50ICgqc2V0X3ZxX3N0YXRlKShzdHJ1Y3QgdmRwYV9kZXZp Y2UgKnZkZXYsIHUxNiBpZHgsCj4gCQkJICAgIGNvbnN0IHN0cnVjdCB2ZHBhX3ZxX3N0YXRlICpz dGF0ZSk7Cj4gCWludCAoKmdldF92cV9zdGF0ZSkoc3RydWN0IHZkcGFfZGV2aWNlICp2ZGV2LCB1 MTYgaWR4LAo+IAkJCSAgICBzdHJ1Y3QgdmRwYV92cV9zdGF0ZSAqc3RhdGUpOwo+IAlzdHJ1Y3Qg dmRwYV9ub3RpZmljYXRpb25fYXJlYQo+IAkoKmdldF92cV9ub3RpZmljYXRpb24pKHN0cnVjdCB2 ZHBhX2RldmljZSAqdmRldiwgdTE2IGlkeCk7Cj4gCS8qIHZxIGlycSBpcyBub3QgZXhwZWN0ZWQg dG8gYmUgY2hhbmdlZCBvbmNlIERSSVZFUl9PSyBpcyBzZXQgKi8KPiAJaW50ICgqZ2V0X3ZxX2ly cSkoc3RydWN0IHZkcGFfZGV2aWNlICp2ZHYsIHUxNiBpZHgpOwo+Cj4gCS8qIERldmljZSBvcHMg Ki8KPiAJdTMyICgqZ2V0X3ZxX2FsaWduKShzdHJ1Y3QgdmRwYV9kZXZpY2UgKnZkZXYpOwo+IAl1 NjQgKCpnZXRfZmVhdHVyZXMpKHN0cnVjdCB2ZHBhX2RldmljZSAqdmRldik7Cj4gCWludCAoKnNl dF9mZWF0dXJlcykoc3RydWN0IHZkcGFfZGV2aWNlICp2ZGV2LCB1NjQgZmVhdHVyZXMpOwo+IAl2 b2lkICgqc2V0X2NvbmZpZ19jYikoc3RydWN0IHZkcGFfZGV2aWNlICp2ZGV2LAo+IAkJCSAgICAg IHN0cnVjdCB2ZHBhX2NhbGxiYWNrICpjYik7Cj4gCXUxNiAoKmdldF92cV9udW1fbWF4KShzdHJ1 Y3QgdmRwYV9kZXZpY2UgKnZkZXYpOwo+IAl1MzIgKCpnZXRfZGV2aWNlX2lkKShzdHJ1Y3QgdmRw YV9kZXZpY2UgKnZkZXYpOwo+IAl1MzIgKCpnZXRfdmVuZG9yX2lkKShzdHJ1Y3QgdmRwYV9kZXZp Y2UgKnZkZXYpOwo+IAl1OCAoKmdldF9zdGF0dXMpKHN0cnVjdCB2ZHBhX2RldmljZSAqdmRldik7 Cj4gCXZvaWQgKCpzZXRfc3RhdHVzKShzdHJ1Y3QgdmRwYV9kZXZpY2UgKnZkZXYsIHU4IHN0YXR1 cyk7Cj4gCXZvaWQgKCpnZXRfY29uZmlnKShzdHJ1Y3QgdmRwYV9kZXZpY2UgKnZkZXYsIHVuc2ln bmVkIGludCBvZmZzZXQsCj4gCQkJICAgdm9pZCAqYnVmLCB1bnNpZ25lZCBpbnQgbGVuKTsKPiAJ dm9pZCAoKnNldF9jb25maWcpKHN0cnVjdCB2ZHBhX2RldmljZSAqdmRldiwgdW5zaWduZWQgaW50 IG9mZnNldCwKPiAJCQkgICBjb25zdCB2b2lkICpidWYsIHVuc2lnbmVkIGludCBsZW4pOwo+IAl1 MzIgKCpnZXRfZ2VuZXJhdGlvbikoc3RydWN0IHZkcGFfZGV2aWNlICp2ZGV2KTsKPgo+IAkvKiBE TUEgb3BzICovCj4gCWludCAoKnNldF9tYXApKHN0cnVjdCB2ZHBhX2RldmljZSAqdmRldiwgc3Ry dWN0IHZob3N0X2lvdGxiICppb3RsYik7Cj4gCWludCAoKmRtYV9tYXApKHN0cnVjdCB2ZHBhX2Rl dmljZSAqdmRldiwgdTY0IGlvdmEsIHU2NCBzaXplLAo+IAkJICAgICAgIHU2NCBwYSwgdTMyIHBl cm0pOwo+IAlpbnQgKCpkbWFfdW5tYXApKHN0cnVjdCB2ZHBhX2RldmljZSAqdmRldiwgdTY0IGlv dmEsIHU2NCBzaXplKTsKPgo+IAkvKiBGcmVlIGRldmljZSByZXNvdXJjZXMgKi8KPiAJdm9pZCAo KmZyZWUpKHN0cnVjdCB2ZHBhX2RldmljZSAqdmRldik7Cj4gfTsKPgo+ICtzdHJ1Y3Qgdmhvc3Rf Y29uZmlnX29wcyB7Cj4gKwlpbnQgKCpjcmVhdGVfdnFzKShzdHJ1Y3Qgdmhvc3RfZGV2ICp2ZGV2 LCB1bnNpZ25lZCBpbnQgbnZxcywKPiArCQkJICB1bnNpZ25lZCBpbnQgbnVtX2J1ZnMsIHN0cnVj dCB2aG9zdF92aXJ0cXVldWUgKnZxc1tdLAo+ICsJCQkgIHZob3N0X3ZxX2NhbGxiYWNrX3QgKmNh bGxiYWNrc1tdLAo+ICsJCQkgIGNvbnN0IGNoYXIgKiBjb25zdCBuYW1lc1tdKTsKPiArCXZvaWQg KCpkZWxfdnFzKShzdHJ1Y3Qgdmhvc3RfZGV2ICp2ZGV2KTsKPiArCWludCAoKndyaXRlKShzdHJ1 Y3Qgdmhvc3RfZGV2ICp2ZGV2LCB1NjQgdmhvc3RfZHN0LCB2b2lkICpzcmMsIGludCBsZW4pOwo+ ICsJaW50ICgqcmVhZCkoc3RydWN0IHZob3N0X2RldiAqdmRldiwgdm9pZCAqZHN0LCB1NjQgdmhv c3Rfc3JjLCBpbnQgbGVuKTsKPiArCWludCAoKnNldF9mZWF0dXJlcykoc3RydWN0IHZob3N0X2Rl diAqdmRldiwgdTY0IGRldmljZV9mZWF0dXJlcyk7Cj4gKwlpbnQgKCpzZXRfc3RhdHVzKShzdHJ1 Y3Qgdmhvc3RfZGV2ICp2ZGV2LCB1OCBzdGF0dXMpOwo+ICsJdTggKCpnZXRfc3RhdHVzKShzdHJ1 Y3Qgdmhvc3RfZGV2ICp2ZGV2KTsKPiArfTsKPiArCj4gc3RydWN0IHZpcnRpb19jb25maWdfb3Bz Cj4gSSB0aGluayB0aGVyZSdzIHNvbWUgb3ZlcmxhcCBoZXJlIGFuZCBzb21lIG9mIHRoZSBvcHMg dHJpZXMgdG8gZG8gdGhlCj4gc2FtZSB0aGluZy4KPgo+IEkgdGhpbmsgaXQgZGlmZmVycyBpbiAo KnNldF92cV9hZGRyZXNzKSgpIGFuZCAoKmNyZWF0ZV92cXMpKCkuCj4gW2NyZWF0ZV92cXMoKSBp bnRyb2R1Y2VkIGluIHN0cnVjdCB2aG9zdF9jb25maWdfb3BzIHByb3ZpZGVzCj4gY29tcGxpbWVu dGFyeSBmdW5jdGlvbmFsaXR5IHRvICgqZmluZF92cXMpKCkgaW4gc3RydWN0Cj4gdmlydGlvX2Nv bmZpZ19vcHMuIEl0IHNlZW1pbmdseSBlbmNhcHN1bGF0ZXMgdGhlIGZ1bmN0aW9uYWxpdHkgb2YK PiAoKnNldF92cV9hZGRyZXNzKSgpLCAoKnNldF92cV9udW0pKCksICgqc2V0X3ZxX2NiKSgpLC4u XS4KPgo+IEJhY2sgdG8gdGhlIGRpZmZlcmVuY2UgYmV0d2VlbiAoKnNldF92cV9hZGRyZXNzKSgp IGFuZCAoKmNyZWF0ZV92cXMpKCksCj4gc2V0X3ZxX2FkZHJlc3MoKSBkaXJlY3RseSBwcm92aWRl cyB0aGUgdmlydHF1ZXVlIGFkZHJlc3MgdG8gdGhlIHZkcGEKPiBkZXZpY2UgYnV0IGNyZWF0ZV92 cXMoKSBvbmx5IHByb3ZpZGVzIHRoZSBwYXJhbWV0ZXJzIG9mIHRoZSB2aXJ0cXVldWUKPiAobGlr ZSB0aGUgbnVtYmVyIG9mIHZpcnRxdWV1ZXMsIG51bWJlciBvZiBidWZmZXJzKSBidXQgZG9lcyBu b3QgZGlyZWN0bHkKPiBwcm92aWRlIHRoZSBhZGRyZXNzLiBJTU8gdGhlIGJhY2tlbmQgY2xpZW50 IGRyaXZlcnMgKGxpa2UgbmV0IG9yIHZob3N0KQo+IHNob3VsZG4ndC9jYW5ub3QgYnkgaXRzZWxm IGtub3cgaG93IHRvIGFjY2VzcyB0aGUgdnJpbmcgY3JlYXRlZCBvbgo+IHZpcnRpbyBmcm9udC1l bmQuIFRoZSB2ZHBhIGRldmljZS92aG9zdCBkZXZpY2Ugc2hvdWxkIGhhdmUgbG9naWMgZm9yCj4g dGhhdC4gVGhhdCB3aWxsIGhlbHAgdGhlIGNsaWVudCBkcml2ZXJzIHRvIHdvcmsgd2l0aCBkaWZm ZXJlbnQgdHlwZXMgb2YKPiB2ZHBhIGRldmljZS92aG9zdCBkZXZpY2UgYW5kIGNhbiBhY2Nlc3Mg dGhlIHZyaW5nIGNyZWF0ZWQgYnkgdmlydGlvCj4gaXJyZXNwZWN0aXZlIG9mIHdoZXRoZXIgdGhl IHZyaW5nIGNhbiBiZSBhY2Nlc3NlZCB2aWEgbW1pbyBvciBrZXJuZWwKPiBzcGFjZSBvciB1c2Vy IHNwYWNlLgo+Cj4gSSB0aGluayB2ZHBhIGFsd2F5cyB3b3JrcyB3aXRoIGNsaWVudCBkcml2ZXJz IGluIHVzZXJzcGFjZSBhbmQgcHJvdmlkaW5nCj4gdXNlcnNwYWNlIGFkZHJlc3MgZm9yIHZyaW5n LgoKClNvcnJ5IGZvciBiZWluZyB1bmNsZWFyLiBXaGF0IEkgbWVhbnQgaXMgbm90IHJlcGxhY2lu ZyB2RFBBIHdpdGggdGhlIAp2aG9zdChidXMpIHlvdSBwcm9wb3NlZCBidXQgdGhlIHBvc3NpYmls aXR5IG9mIHJlcGxhY2luZyB2aXJ0aW8tcGNpLWVwZiAKd2l0aCB2RFBBIGluOgoKTXkgcXVlc3Rp b24gaXMgYmFzaWNhbGx5IGZvciB0aGUgcGFydCBvZiB2aXJ0aW9fcGNpX2VwZl9zZW5kX2NvbW1h bmQoKSwgCnNvIGl0IGxvb2tzIHRvIG1lIHlvdSBoYXZlIGEgdmVuZG9yIHNwZWNpZmljIEFQSSB0 byByZXBsYWNlIHRoZSAKdmlydGlvLXBjaSBsYXlvdXQgb2YgdGhlIEJBUjoKCgorc3RhdGljIGlu dCB2aXJ0aW9fcGNpX2VwZl9zZW5kX2NvbW1hbmQoc3RydWN0IHZpcnRpb19wY2lfZGV2aWNlICp2 cF9kZXYsCivCoMKgwqAgwqDCoMKgIMKgwqDCoCDCoMKgwqAgwqDCoMKgwqDCoMKgIHUzMiBjb21t YW5kKQoreworwqDCoMKgIHN0cnVjdCB2aXJ0aW9fcGNpX2VwZiAqcGNpX2VwZjsKK8KgwqDCoCB2 b2lkIF9faW9tZW0gKmlvYWRkcjsKK8KgwqDCoCBrdGltZV90IHRpbWVvdXQ7CivCoMKgwqAgYm9v bCB0aW1lZG91dDsKK8KgwqDCoCBpbnQgcmV0ID0gMDsKK8KgwqDCoCB1OCBzdGF0dXM7CisKK8Kg wqDCoCBwY2lfZXBmID0gdG9fdmlydGlvX3BjaV9lcGYodnBfZGV2KTsKK8KgwqDCoCBpb2FkZHIg PSB2cF9kZXYtPmlvYWRkcjsKKworwqDCoMKgIG11dGV4X2xvY2soJnBjaV9lcGYtPmxvY2spOwor wqDCoMKgIHdyaXRlYihjb21tYW5kLCBpb2FkZHIgKyBIT1NUX0NNRCk7CivCoMKgwqAgdGltZW91 dCA9IGt0aW1lX2FkZF9tcyhrdGltZV9nZXQoKSwgQ09NTUFORF9USU1FT1VUKTsKK8KgwqDCoCB3 aGlsZSAoMSkgeworwqDCoMKgIMKgwqDCoCB0aW1lZG91dCA9IGt0aW1lX2FmdGVyKGt0aW1lX2dl dCgpLCB0aW1lb3V0KTsKK8KgwqDCoCDCoMKgwqAgc3RhdHVzID0gcmVhZGIoaW9hZGRyICsgSE9T VF9DTURfU1RBVFVTKTsKKwoKU2V2ZXJhbCBxdWVzdGlvbnM6CgotIEl0J3Mgbm90IGNsZWFyIHRv IG1lIGhvdyB0aGUgc3luY2hyb25pemF0aW9uIGlzIGRvbmUgYmV0d2VlbiB0aGUgUkMgCmFuZCBF UC4gRS5nIGhvdyBhbmQgd2hlbiB0aGUgdmFsdWUgb2YgSE9TVF9DTURfU1RBVFVTIGNhbiBiZSBj aGFuZ2VkLsKgIApJZiB5b3Ugc3RpbGwgd2FudCB0byBpbnRyb2R1Y2UgYSBuZXcgdHJhbnNwb3J0 LCBhIHZpcnRpbyBzcGVjIHBhdGNoIAp3b3VsZCBiZSBoZWxwZnVsIGZvciB1cyB0byB1bmRlcnN0 YW5kIHRoZSBkZXZpY2UgQVBJLgotIFlvdSBoYXZlIHlvdSB2ZW5kb3Igc3BlY2lmaWMgbGF5b3V0 IChhY2NvcmRpbmcgdG8gCnZpcnRpb19wY2lfZXBiX3RhYmxlKCkpLCBzbyBJIGd1ZXNzIHlvdSBp dCdzIGJldHRlciB0byBoYXZlIGEgdmVuZG9yIApzcGVjaWZpYyB2RFBBIGRyaXZlciBpbnN0ZWFk Ci0gVGhlIGFkdmFudGFnZSBvZiB2ZW5kb3Igc3BlY2lmaWMgdkRQQSBkcml2ZXIgaXMgdGhhdCBp dCBjYW4gMSkgaGF2ZSAKbGVzcyBjb2RlcyAyKSBzdXBwb3J0IHVzZXJzcGFjZSBkcml2ZXJzIHRo cm91Z2ggdmhvc3QtdkRQQSAoaW5zdGVhZCBvZiAKaW52ZW50aW5nIG5ldyBBUElzIHNpbmNlIHdl IGNhbid0IHVzZSB2ZmlvLXBjaSBoZXJlKS4KCgo+Pj4gIlZpcnRpbyBPdmVyIE5UQiIgc2hvdWxk IGFueXdheXMgYmUgYSBuZXcgdHJhbnNwb3J0Lgo+Pj4+IERvZXMgdGhhdCBtYWtlIGFueSBzZW5z ZT8KPj4+IHllYWgsIGluIHRoZSBhcHByb2FjaCBJIHVzZWQgdGhlIGluaXRpYWwgZmVhdHVyZXMg YXJlIGhhcmQtY29kZWQgaW4KPj4+IHZob3N0LXJwbXNnIChpbmhlcmVudCB0byB0aGUgcnBtc2cp IGJ1dCB3aGVuIHdlIGhhdmUgdG8gdXNlIGFkYXB0ZXIKPj4+IGxheWVyICh2aG9zdCBvbmx5IGZv ciBhY2Nlc3NpbmcgdmlydGlvIHJpbmcgYW5kIHVzZSB2aXJ0aW8gZHJpdmVycyBvbgo+Pj4gYm90 aCBmcm9udCBlbmQgYW5kIGJhY2tlbmQpLCBiYXNlZCBvbiB0aGUgZnVuY3Rpb25hbGl0eSAoZS5n LCBycG1zZyksCj4+PiB0aGUgdmhvc3Qgc2hvdWxkIGJlIGNvbmZpZ3VyZWQgd2l0aCBmZWF0dXJl cyAodG8gYmUgcHJlc2VudGVkIHRvIHRoZQo+Pj4gdmlydGlvKSBhbmQgdGhhdCdzIHdoeSBhZGRp dGlvbmFsIGxheWVyIG9yIEFQSXMgd2lsbCBiZSByZXF1aXJlZC4KPj4gQSBxdWVzdGlvbiBoZXJl LCBpZiB3ZSBnbyB3aXRoIHZob3N0IGJ1cyBhcHByb2FjaCwgZG9lcyBpdCBtZWFuIHRoZQo+PiB2 aXJ0aW8gZGV2aWNlIGNhbiBvbmx5IGJlIGltcGxlbWVudGVkIGluIEVQJ3MgdXNlcnNwYWNlPwo+ IFRoZSB2aG9zdCBidXMgYXBwcm9hY2ggZG9lc24ndCBwcm92aWRlIGFueSByZXN0cmljdGlvbiBp biB3aGVyZSB0aGUKPiB2aXJ0byBiYWNrZW5kIGRldmljZSBzaG91bGQgYmUgY3JlYXRlZC4gVGhp cyBzZXJpZXMgY3JlYXRlcyB0d28gdHlwZXMgb2YKPiB2aXJ0aW8gYmFja2VuZCBkZXZpY2UgKG9u ZSBmb3IgUENJZSBlbmRwb2ludCBhbmQgdGhlIG90aGVyIGZvciBOVEIpIGFuZAo+IGJvdGggdGhl c2UgZGV2aWNlcyBhcmUgY3JlYXRlZCBpbiBrZXJuZWwuCgoKT2suCgpUaGFua3MKCgo+Cj4gVGhh bmtzCj4gS2lzaG9uCj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlzdApWaXJ0dWFsaXphdGlvbkBsaXN0cy5s aW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFp bG1hbi9saXN0aW5mby92aXJ0dWFsaXphdGlvbg==