From: Jeremy Kerr <jk@ozlabs.org>
To: OpenBMC Patches <openbmc-patches@stwcx.xyz>, openbmc@lists.ozlabs.org
Cc: Brad Bishop <bradleyb@fuzziesquirrel.com>,
Andrew Jeffery <andrew@aj.id.au>
Subject: Re: [PATCH docs] Take a stab at a proper DBUS API document.
Date: Thu, 12 May 2016 16:56:09 +0800 [thread overview]
Message-ID: <57344529.8020901@ozlabs.org> (raw)
In-Reply-To: <1462996814-824-2-git-send-email-openbmc-patches@stwcx.xyz>
Hi Brad,
This is awesome, thanks for taking the time and writing up the proper
content here.
Since your change will establish a few conventions around how the
interfaces will be properly documented, I'm being extra-nitpicky about
this, so have a few changes listed below. If you'd prefer, I can do this
reformatting myself, but we should still address this somehow, before
merging.
> +# OpenBMC DBUS API
Most of the other docs use the ====/---- style of for level 1 & level 2
headers, as it makes the text version of the markdown look more like a
header.
> +The Phosphor distibution provides sample applications that implement off all the interfaces and objects listed below. Alternative or more feature complete applications are possible by implementing parts of this DBUS API.
Can we wrap at 80 columns, where it makes sense? Things that *need* to
be wider are fine, but this makes things readable for folks who use
80-cols by default.
> +| name | in signature | out signature | description |
> +| ------------ | ------------ | ------------- | ---------------------------------------- |
> +| sendMessage | yyyyyay | x | Send an IPMI message to the host processor firmware. |
Should we backtick-escape these names (and paths)? It'll also avoid any
issues with inline < and > characters (which Chris picked up in his
review).
Looks like this table format is also compatible with the pandoc markdown
implementation, which is great news if/when we want to create a PDF
document including this.
Speaking of which, pandoc also supports a few different methods of doing
tables, some of which allow us to break long lines (which may make the
text-format of the doc easier to read):
http://pandoc.org/README.html#tables
However, if we do end up using one of these, we'll need to check that it
still renders correctly in github.
Cheers,
Jeremy
next prev parent reply other threads:[~2016-05-12 8:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 20:00 [PATCH docs] Take a stab at a proper DBUS API document OpenBMC Patches
2016-05-11 20:00 ` OpenBMC Patches
2016-05-12 8:56 ` Jeremy Kerr [this message]
2016-05-12 19:00 ` Brad Bishop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57344529.8020901@ozlabs.org \
--to=jk@ozlabs.org \
--cc=andrew@aj.id.au \
--cc=bradleyb@fuzziesquirrel.com \
--cc=openbmc-patches@stwcx.xyz \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.