From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0okK-0001O6-16 for qemu-devel@nongnu.org; Thu, 12 May 2016 07:25:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0okI-0000hE-O7 for qemu-devel@nongnu.org; Thu, 12 May 2016 07:25:35 -0400 Sender: Paolo Bonzini References: <1462552005-4887-1-git-send-email-eblake@redhat.com> <1462552005-4887-7-git-send-email-eblake@redhat.com> From: Paolo Bonzini Message-ID: <57346821.90709@redhat.com> Date: Thu, 12 May 2016 13:25:21 +0200 MIME-Version: 1.0 In-Reply-To: <1462552005-4887-7-git-send-email-eblake@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 06/19] scsi-disk: Switch to byte-based aio block access List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: kwolf@redhat.com, qemu-block@nongnu.org On 06/05/2016 18:26, Eric Blake wrote: > @@ -340,11 +338,12 @@ static void scsi_do_read(SCSIDiskReq *r, int ret) > r->req.aiocb = dma_blk_read(s->qdev.conf.blk, r->req.sg, r->sector, > scsi_dma_complete, r); This is broken, it should be changed to an offset in the previous patch. Please rename the function too, so that it is obvious that you have changed all callers. How was this patch tested? Paolo > } else { > - n = scsi_init_iovec(r, SCSI_DMA_BUF_SIZE); > + scsi_init_iovec(r, SCSI_DMA_BUF_SIZE); > block_acct_start(blk_get_stats(s->qdev.conf.blk), &r->acct, > - n * BDRV_SECTOR_SIZE, BLOCK_ACCT_READ); > - r->req.aiocb = blk_aio_readv(s->qdev.conf.blk, r->sector, &r->qiov, n, > - scsi_read_complete, r); > + SCSI_DMA_BUF_SIZE, BLOCK_ACCT_READ); > + r->req.aiocb = blk_aio_preadv(s->qdev.conf.blk, > + r->sector << BDRV_SECTOR_BITS, &r->qiov, > + 0, scsi_read_complete, r); > }