From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42623)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1b0olK-0002v3-75
	for qemu-devel@nongnu.org; Thu, 12 May 2016 07:26:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1b0olI-0000oY-3n
	for qemu-devel@nongnu.org; Thu, 12 May 2016 07:26:37 -0400
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1462552005-4887-1-git-send-email-eblake@redhat.com>
	<1462552005-4887-7-git-send-email-eblake@redhat.com>
	<57346821.90709@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <57346863.2010005@redhat.com>
Date: Thu, 12 May 2016 13:26:27 +0200
MIME-Version: 1.0
In-Reply-To: <57346821.90709@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v7 06/19] scsi-disk: Switch to byte-based
 aio block access
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, qemu-block@nongnu.org



On 12/05/2016 13:25, Paolo Bonzini wrote:
>> >          r->req.aiocb = dma_blk_read(s->qdev.conf.blk, r->req.sg, r->sector,
>> >                                      scsi_dma_complete, r);
> This is broken, it should be changed to an offset in the previous patch.
> 
> Please rename the function too, so that it is obvious that you have
> changed all callers.

Oh, dma_blk_read is still sector-based...

Paolo